Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159748 --- This has been pushed to trunk. Please close the review. - Nate C

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Attila Doroszlai
> On Dec. 20, 2016, 7:31 p.m., Nate Cole wrote: > > I don't seem to be getting a clean merge with this diff. Yes, the change comitted in the meantime for AMBARI-19195 introduced conflict. - Attila --- This is an automatically generated

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/ --- (Updated Dec. 20, 2016, 9:26 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159736 --- I don't seem to be getting a clean merge with this diff. - Nate C

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159733 --- Ship it! Ship It! - Jonathan Hurley On Dec. 20, 2016, 11:55

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159730 --- Ship it! ambari-server/src/test/java/org/apache/ambari/server/

Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, and Nate Cole. Bugs: