Re: Review Request 57945: Log Search Configuration API

2017-04-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review171725 --- Ship it! Ship It! - Oliver Szabo On April 12, 2017, 9:39

Re: Review Request 57945: Log Search Configuration API

2017-04-12 Thread Miklos Gergely
> On March 29, 2017, 3:50 p.m., Oliver Szabo wrote: > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java > > Lines 71 (patched) > > > > > > as its a

Re: Review Request 57945: Log Search Configuration API

2017-04-12 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 12, 2017, 9:39 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-04-12 Thread Miklos Gergely
> On April 10, 2017, 7:51 p.m., Oliver Szabo wrote: > > ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml > > Lines 52 (patched) > > > > > > not really an issue but compile is the default scope so its not

Re: Review Request 57945: Log Search Configuration API

2017-04-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 11, 2017, 3:18 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-04-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 11, 2017, 2:08 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-04-10 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 10, 2017, 9:38 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-04-10 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review171466 --- ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml Lines

Re: Review Request 57945: Log Search Configuration API

2017-04-10 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 10, 2017, 3:04 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-04-10 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 10, 2017, 9:36 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-04-03 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated April 3, 2017, 7:26 p.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170765 ---

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170721 --- Ship it! Patch looks fine, just a minor suggestion for a

Re: Review Request 57945: Log Search Configuration API

2017-03-31 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated March 31, 2017, 10:15 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-03-30 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170636 --- Fix it, then Ship it! Ship It!

Re: Review Request 57945: Log Search Configuration API

2017-03-30 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated March 30, 2017, 11:31 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170411 ---

Re: Review Request 57945: Log Search Configuration API

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170409 ---

Re: Review Request 57945: Log Search Configuration API

2017-03-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated March 29, 2017, 2:06 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-03-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated March 27, 2017, 1:22 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 57945: Log Search Configuration API

2017-03-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170147 --- ambari-logsearch/ambari-logsearch-config-impl/pom.xml Lines 1

Review Request 57945: Log Search Configuration API

2017-03-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: