Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-16 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/ --- (Updated Май 16, 2017, 4:32 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-16 Thread Dmytro Sen
> On Май 15, 2017, 8:56 п.п., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-host-aggregator/src/main/java/org/apache/hadoop/metrics2/host/aggregator/AggregatorApplication.java > > Lines 61 (patched) > > > >

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-15 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review175038 --- Without goind throught full patch it is always a good idea to

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-15 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review175020 ---

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/ --- (Updated Апрель 28, 2017, 4:41 п.п.) Review request for Ambari, Aravindan

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-28 Thread Dmytro Sen
> On Апрель 26, 2017, 8:48 п.п., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/aggregator.py > > Lines 44 (patched) > > > > > > Protocol support for https? Maybe not

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/ --- (Updated Апрель 28, 2017, 1:26 п.п.) Review request for Ambari, Aravindan

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-26 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review173087 ---

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-26 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/ --- (Updated Апрель 26, 2017, 4:44 п.п.) Review request for Ambari, Aravindan

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-14 Thread Dmytro Sen
> On Апрель 13, 2017, 5:11 п.п., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > > Line 498 (original), 498 (patched) > >

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-14 Thread Dmytro Sen
> On Апрель 13, 2017, 5:31 п.п., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > > Line 153 (original), 157 (patched) > >

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Sid Wagle
> On April 13, 2017, 5:31 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > > Line 153 (original), 157 (patched) > >

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171905 ---

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171904 ---

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171899 ---

Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-20758