Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-27 Thread Miklos Gergely
> On July 26, 2017, 6:43 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java > > Lines 67 (patched) > > > > > >

Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60943/#review181476 --- Fix it, then Ship it! Patch looks fine, just a minor comment

Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-20 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60943/ --- (Updated July 20, 2017, 9:54 a.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-18 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60943/ --- (Updated July 19, 2017, 12:53 a.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-18 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60943/#review180846 ---

Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-18 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60943/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: