Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62414/#review185754 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Robert Levas
> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > > Lines 1176 (patched) > > > > > > Unless this would be used for something else

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Jonathan Hurley
> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > > Lines 1091-1092 (original), 1095-1099 (patched) > > > > > > Only if you are m

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62414/#review185717 --- Ship it! Ship It! ambari-server/src/main/java/org/apache/amba

Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62414/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-21999 h