Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187753 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 11, 2017,

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187702 --- Ship it! Ship It! - Jayush Luniya On Oct. 11, 2017, 4:17

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Vitalyi Brodetskyi
> On Жов. 11, 2017, 8:43 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > > Lines 1075 (patched) > > > > > > Why not set quickLinksConfigurations

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Vitalyi Brodetskyi
> On Жов. 11, 2017, 8:43 після полудня, Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > > Lines 1037 (patched) > > > > > > Why not set themes itself instead of

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Jayush Luniya
> On Oct. 11, 2017, 6:45 p.m., Madhuvanthi Radhakrishnan wrote: > > We might want to add it to trunk itself. Thanks The serviceInfo.clone() is something I added for the mpack generator. So the patch won't be applicable there. Lets just fix this in the feature branch. Eventually we will be

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187697 ---

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187681 --- Ship it! We might want to add it to trunk itself. Thanks -

Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-11 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/ --- Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi