Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-31 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/#review189718 --- Ship it! Ship It! - Robert Levas On Oct. 24, 2017, 2:02 p.m.

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-25 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/#review189196 --- Ship it! Ship It! - Attila Magyar On Oct. 24, 2017, 6:02 p.m

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-25 Thread Eugene Chekanskiy
> On Oct. 25, 2017, 7:28 a.m., Attila Magyar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > > Lines 469 (patched) > > > > > > How does regenerate missing keytabs work

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-25 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/#review189176 --- ambari-server/src/main/java/org/apache/ambari/server/agent/Heartb

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-24 Thread Eugene Chekanskiy
> On Oct. 20, 2017, 3:58 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java > > Lines 393-396 (patched) > > > > > > This may not b

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-24 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/ --- (Updated Oct. 24, 2017, 6:02 p.m.) Review request for Ambari, Attila Magyar, Ba

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/#review188838 --- The patch looks really good, but I am concerned that it may break

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/#review188836 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63180/ --- Review request for Ambari, Attila Magyar, Balázs Bence Sári, Laszlo Puskas, Robe