----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/ -----------------------------------------------------------
Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton. Bugs: AMBARI-22600 https://issues.apache.org/jira/browse/AMBARI-22600 Repository: ambari Description ------- Log Feeder needs to clone filters for different input threads (for wildcard pattern). As different threads tried to access the same grok filter object (mutable) that could cause to some docs used the wrong path (or other fields), especially when a grok error happened. (on error, in the code, we checked some objects regarding that what to do, but other threads changed those objects) Also some other changes: - use sdi_* dynamic fields - add new input log files - add new config to grok filter: skip_on_error (can be useful for filter chains) Diffs ----- ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java afd903e ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java 49d7e76 ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java 7df0b6e ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-storm.json 34bdcf0 ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log 6a10ad9 ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-2-TestAgg2-4-5/6700/worker.log e69de29 Diff: https://reviews.apache.org/r/64349/diff/1/ Testing ------- done, i need to write some unit tests for the filter cloning. Thanks, Oliver Szabo