Re: Review Request 32597: Improving async preemptor efficiency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review78150 --- This patch does not apply cleanly on master (3ab8a9e), do you need t

Review Request 32597: Improving async preemptor efficiency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1219

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78142 --- Master (3ab8a9e) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78139 --- @Reviewbot retry - Kevin Sweeney On March 27, 2015, 5:02 p.m., Ke

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78137 --- Master (3ab8a9e) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78135 --- @reviewbot retry - Kevin Sweeney On March 27, 2015, 5:02 p.m., Ke

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78134 --- Master (f0a3f9c) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 27, 2015, 5:02 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32329: Extract job key from RPC parameters

> On March 27, 2015, 11:44 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetters.java, > > lines 25-26 > > > > > > I don't think I've ever run into the scenario where a

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78127 --- Ship it! Looks good to me in general. I still think we could probab

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review78125 --- Master (f0a3f9c) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32329: Extract job key from RPC parameters

> On March 23, 2015, 1:59 p.m., Bill Farner wrote: > > config/pmd/custom.xml, line 61 > > > > > > Please add a comment explaining the use case we're advocating with this. Added. > On March 23, 2015, 1:59 p.m., Bill F

Re: Review Request 32329: Extract job key from RPC parameters

> On March 23, 2015, 1:59 p.m., Joshua Cohen wrote: > > Thanks, this is already much easier to follow. > > > > One general question on the overall approach: do you think the DRY benefits > > of using composed `StructFieldGetter`s to generate the functions that allow > > walking from the starti

Re: Review Request 32329: Extract job key from RPC parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 27, 2015, 4:14 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78113 --- Ship it! Master (45f2a84) is green with this patch. ./build-suppo

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated March 27, 2015, 1:50 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78109 --- @ReviewBot retry - Kevin Sweeney On March 27, 2015, 12:48 p.m., K

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78107 --- src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh

Re: Review Request 32559: Add Kerberos support to the scheduler

> On March 27, 2015, 6:09 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, > > line 42 > > > > > > It feels like most of this stuff c

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78102 --- Master (45f2a84) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/ --- (Updated March 27, 2015, 12:48 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 32559: Add Kerberos support to the scheduler

> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote: > > examples/vagrant/provision-dev-cluster.sh, line 20 > > > > > > Is this needed to build kerberos in the test script? Do we need to > > build it from source? Can w

Re: Review Request 32559: Add Kerberos support to the scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32559/#review78075 --- examples/vagrant/provision-dev-cluster.sh

Re: Review Request 32554: Enable gradle daemon in Vagrant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32554/#review78061 --- Ship it! Ship It! - Maxim Khutornenko On March 26, 2015, 10:45 p