Re: Review Request 33106: Simplify AttributeAggregate.

2015-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33106/#review79821 --- Ship it! Master (eb9e408) is green with this patch. ./build-suppo

Review Request 33106: Simplify AttributeAggregate.

2015-04-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33106/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review79817 --- Ship it! Master (eb9e408) is green with this patch. ./build-suppo

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-11 Thread Stephan Erb
> On April 10, 2015, 7:59 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/executor/test_thermos_task_runner.py, line 213 > > > > > > Patching private methods for testing is a smell and it hinders > > refac

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 11:52 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 11, 2015, 11:52 p.m.) Review request for Aurora, Joshua Cohen an

Re: Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

2015-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/#review79809 --- Master (eb9e408) is red with this patch. ./build-support/jenkins/b

Review Request 33105: Return Iterable from TaskStore.fetchTasks to allow for streaming.

2015-04-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33105/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur

Re: Review Request 33103: Skip known flaky tests.

2015-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/#review79807 --- Ship it! Master (eb9e408) is green with this patch. ./build-suppo

Review Request 33103: Skip known flaky tests.

2015-04-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33103/ --- Review request for Aurora, Joshua Cohen and Brian Wickman. Repository: aurora