Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/#review81255 --- Master (352e0ef) is green with this patch. ./build-support/jenkins

Review Request 33458: Implementing PendingTaskProcessor benchmark.

2015-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 33455: Use "a" mode instead of "w" when opening stdout and stderr.

2015-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33455/#review81243 --- Master (352e0ef) is green with this patch. ./build-support/jenkins

Re: Review Request 33456: Adding logging threadpool executor.

2015-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81240 --- Ship it! Master (352e0ef) is green with this patch. ./build-suppo

Review Request 33456: Adding logging threadpool executor.

2015-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Review Request 33455: Use "a" mode instead of "w" when opening stdout and stderr.

2015-04-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33455/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description -

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-22 Thread Kevin Sweeney
> On April 22, 2015, 11:17 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/spi/Permissions.java, lines 90-94 > > > > > > You probably want Enums.getIfPresent() instead or may be even forgo

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81191 --- Ship it! src/main/java/org/apache/aurora/scheduler/spi/Permissions

Re: Review Request 33433: Revert "Revert "Make health check configurable""

2015-04-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review81188 --- I think we need to hold off on this patch until 0.8.0 is released.

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81174 --- Ship it! Ship It! - Joshua Cohen On April 21, 2015, 11 p.m., Kev

Re: Review Request 33433: Revert "Revert "Make health check configurable""

2015-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review81144 --- Ship it! Master (8fd21a1) is green with this patch. ./build-suppo

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-04-22 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/ --- (Updated April 22, 2015, 11:56 a.m.) Review request for Aurora. Changes -

Review Request 33433: Revert "Revert "Make health check configurable""

2015-04-22 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/ --- Review request for Aurora. Repository: aurora Description --- This rever