Re: Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/ --- (Updated April 29, 2015, 4:45 a.m.) Review request for Aurora and Kevin Sweeney

Re: Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/#review81924 --- Master (e311dbe) is green with this patch. ./build-support/jenkins

Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1290 https://issu

Re: Review Request 33658: Remove redundant enable_api_security argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/#review81921 --- Ship it! Master (e311dbe) is green with this patch. ./build-suppo

Re: Review Request 33658: Remove redundant enable_api_security argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/#review81920 --- Master (e311dbe) is red with this patch. ./build-support/jenkins/b

Re: Review Request 33658: Remove redundant enable_api_security argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/ --- (Updated April 29, 2015, 2:30 a.m.) Review request for Aurora and Kevin Sweeney

Review Request 33658: Remove redundant enable_api_security argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1291 https://issu

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81915 --- Looks good overall. A few comments left. src/jmh/java/org/apache/a

Re: Review Request 33612: Add a task store implementation that uses a relational database.

> On April 28, 2015, 11:48 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 131 > > > > > > This feels like a potential for flakiness. Why 5? Any reason agains

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81913 --- Master (e311dbe) is green with this patch. ./build-support/jenkins

Re: Review Request 33456: Adding logging threadpool executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33456/#review81912 --- Ship it! I'll let you make the call here. I think the decorator me

Re: Review Request 33608: Added a status update throughput benchmark.

> On April 28, 2015, 8:35 p.m., Maxim Khutornenko wrote: > > Thanks for the thorough review! > On April 28, 2015, 8:35 p.m., Maxim Khutornenko wrote: > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java, > > line 45 > >

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 29, 2015, 12:48 a.m.) Review request for Aurora and Maxim Khutor

Re: Review Request 33608: Added a status update throughput benchmark.

> On April 28, 2015, 1:30 a.m., Kevin Sweeney wrote: > > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, lines > > 105-110 > > > > > > You probably want > > http://docs.guava-libraries.googlecode

Re: Review Request 33456: Adding logging threadpool executor.

> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review81885 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java

Re: Review Request 33456: Adding logging threadpool executor.

> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33456: Adding logging threadpool executor.

> On April 27, 2015, 8 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java, line 71 > > > > > > Have you considered creating factory methods that apply decorators to > > ExecutorS

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81856 --- src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java

Re: Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/#review81875 --- Ship it! Master (32cd1d5) is green with this patch. ./build-suppo

Review Request 33612: Add a task store implementation that uses a relational database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33612/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko.

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81864 --- Ship it! Master (c760095) is green with this patch. ./build-suppo

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/ --- (Updated April 28, 2015, 12:01 p.m.) Review request for Aurora, David McLaughli

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81855 --- Ship it! Ship It! - Maxim Khutornenko On April 28, 2015, 6:16 p.

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81853 --- Ship it! Master (e9d723d) is green with this patch. ./build-suppo

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81851 --- Ship it! Ship It! - Joshua Cohen On April 27, 2015, 11:24 p.m.,

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/ --- (Updated April 28, 2015, 6:16 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/#review81850 --- Ship it! Ship It! - Bill Farner On April 28, 2015, 5:24 p.m., Ma

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

> On April 28, 2015, 5:13 p.m., Maxim Khutornenko wrote: > > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java, line 128 > > > > > > This benchmark is nearly identical to the role summary one. Any chanc

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/#review81843 --- Master (e9d723d) is green with this patch. ./build-support/jenkins

Re: Review Request 33458: Implementing PendingTaskProcessor benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33458/ --- (Updated April 28, 2015, 5:24 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 33611: Add benchmarks for fetching tasks over the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33611/#review81836 --- src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java <

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81826 --- Ship it! Ship It! - Bill Farner On April 27, 2015, 11:24 p.m., K

Re: Review Request 33537: Document Aurora security features.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33537/#review81824 --- Ship it! Looks great! Just found one line with repeated text. doc