Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82077 --- Master (f77daf7) is green with this patch. ./build-support/jenkins

Re: Review Request 33608: Added a status update throughput benchmark.

> On April 29, 2015, 10:38 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line > > 179 > > > > > > This requires libmesos.so to be available, which i don't think we

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 30, 2015, 12:35 a.m.) Review request for Aurora and Maxim Khutor

Re: Review Request 33608: Added a status update throughput benchmark.

> On April 29, 2015, 10:31 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java, > > line 45 > > > > > > If anything, you should expose Scheduler.class to hide the >

Re: Review Request 33705: Don't retry API requests that fail with auth errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33705/#review82071 --- Ship it! Master (f77daf7) is green with this patch. ./build-suppo

Review Request 33705: Don't retry API requests that fail with auth errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33705/ --- Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-1248

Re: Review Request 33676: Always require slave checkpointing.

> On April 29, 2015, 9:50 p.m., Kevin Sweeney wrote: > > Actually I may have jumped the gun here - can you verify that mesos will > > behave sanely when we flip frameworkInfo.checkpoint from false to true (as > > everyone who has been using the defaults in 0.7.0 will encounter when they > > at

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82049 --- Sorry, one last drive-by that is probably a ship-blocker, albeit min

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review82048 --- src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModu

Re: Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/#review82043 --- Ship it! Ship It! - Kevin Sweeney On April 29, 2015, 2:36 p.m.,

Re: Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/#review82042 --- Master (e34bf7c) is green with this patch. ./build-support/jenkins

Re: Review Request 33676: Always require slave checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33676/#review82040 --- Actually I may have jumped the gun here - can you verify that mesos

Re: Review Request 33676: Always require slave checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33676/#review82038 --- Ship it! Ship It! - Kevin Sweeney On April 29, 2015, 8:04 a.m.,

Re: Review Request 33677: Remove dead code related to Java executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review82035 --- Master (e34bf7c) is green with this patch. ./build-support/jenkins

Re: Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/ --- (Updated April 29, 2015, 9:36 p.m.) Review request for Aurora and Kevin Sweeney

Re: Review Request 33658: Remove redundant enable_api_security argument.

> On April 29, 2015, 6:13 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, > > line 150 > > > > > > ": " Done. - Bill

Re: Review Request 33658: Remove redundant enable_api_security argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/ --- (Updated April 29, 2015, 9:24 p.m.) Review request for Aurora and Kevin Sweeney

Re: Review Request 33677: Remove dead code related to Java executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review82029 --- @ReviewBot retry I could not repro the failed announcer test, i sus

Re: Review Request 33659: Add support for shorthand names of security realm modules.

> On April 29, 2015, 7:35 p.m., Kevin Sweeney wrote: > > docs/security.md, line 57 > > > > > > The only weird thing is that IniRealm handles both AUTHN and AUTHZ. So > > there's a potential misconfiguration: > > >

Re: Review Request 33659: Add support for shorthand names of security realm modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33659/#review82002 --- docs/security.md

Re: Review Request 33677: Remove dead code related to Java executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review82001 --- Ship it! wow - Brian Wickman On April 29, 2015, 3:25 p.m., Bill

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81999 --- Master (e311dbe) is green with this patch. ./build-support/jenkins

Re: Review Request 33676: Always require slave checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33676/#review81994 --- The upstream ticket referenced was fixed in 0.22.0 - should we wait

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/#review81993 --- Ship it! Ship It! - Maxim Khutornenko On April 29, 2015, 6:12 p.

Re: Review Request 33658: Remove redundant enable_api_security argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33658/#review81990 --- Ship it! Thanks for taking this on! src/main/java/org/apache/auro

Re: Review Request 33608: Added a status update throughput benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33608/ --- (Updated April 29, 2015, 6:12 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 33608: Added a status update throughput benchmark.

> On April 29, 2015, 1:42 a.m., Maxim Khutornenko wrote: > > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line > > 106 > > > > > > s/public/private Done. > On April 29, 2015, 1:42 a.m., Maxi

Re: Review Request 33677: Remove dead code related to Java executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/#review81968 --- Master (e311dbe) is red with this patch. ./build-support/jenkins/b

Review Request 33677: Remove dead code related to Java executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33677/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-195 https://issue

Re: Review Request 33676: Always require slave checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33676/#review81967 --- Master (e311dbe) is green with this patch. ./build-support/jenkins

Review Request 33676: Always require slave checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33676/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-716 https://issue