Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
> On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: > > Have you investigated using the [Console > > Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we > > can use the Shiro filter directly and avoid adding another mechanism to > > configure security as well as avoid addi

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84851 --- This change lgtm but I will need to ask you to do the following thin

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
> On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: > > Have you investigated using the [Console > > Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we > > can use the Shiro filter directly and avoid adding another mechanism to > > configure security as well as avoid addi

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
> On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: > > Have you investigated using the [Console > > Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we > > can use the Shiro filter directly and avoid adding another mechanism to > > configure security as well as avoid addi

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Kevin Sweeney
> On May 21, 2015, 4:34 p.m., Kevin Sweeney wrote: > > Have you investigated using the [Console > > Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we > > can use the Shiro filter directly and avoid adding another mechanism to > > configure security as well as avoid addin

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84837 --- src/main/python/apache/aurora/client/api/__init__.py

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
> On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: > > Have you investigated using the [Console > > Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we > > can use the Shiro filter directly and avoid adding another mechanism to > > configure security as well as avoid addi

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84825 --- Master (998993d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84821 --- Might be worth adding tests for the conditional startup of the admin

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84823 --- Have you investigated using the [Console Servlet](http://www.h2data

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/ --- (Updated May 21, 2015, 4:28 p.m.) Review request for Aurora, Joshua Cohen and B

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84818 --- This patch does not apply cleanly on master (998993d), do you need t

Review Request 34570: Use set-literals and set-comprehensions where possible

2015-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/ --- Review request for Aurora, Joshua Cohen and Brian Wickman. Repository: aurora

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84805 --- Master (998993d) is red with this patch. ./build-support/jenkins/b

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84799 --- @ReviewBot retry - Bhuvan Arumugam On May 21, 2015, 9:54 p.m., Bh

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/#review84798 --- Master (998993d) is green with this patch. ./build-support/jenkins

Re: Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- (Updated May 21, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and Za

Review Request 34568: run tasks as user that match aurora-role

2015-05-21 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34568/ --- Review request for Aurora. Repository: aurora Description --- The tasks

Re: Review Request 34566: Adding H2 management console.

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/#review84794 --- Ship it! Master (998993d) is green with this patch. ./build-suppo

Review Request 34566: Adding H2 management console.

2015-05-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34566/ --- Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-1287

Re: Review Request 34501: Defaulting TemporaryStorage to in-memory task store.

2015-05-21 Thread Kevin Sweeney
> On May 20, 2015, 3:17 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java, > > lines 72-76 > > > > > > How is the db storage going to graduate to production i

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review84744 --- Ship it! Master (998993d) is green with this patch. ./build-suppo

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-21 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/ --- (Updated May 21, 2015, 10:27 a.m.) Review request for Aurora and Jake Farrell.

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-21 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/ --- (Updated May 21, 2015, 10:26 a.m.) Review request for Aurora and Jake Farrell.