Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89214 --- Ship it! Ship It! - Brian Wickman On June 24, 2015, 12:22 a.m.,

Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Brian Wickman
> On June 24, 2015, 12:31 a.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. > > Maxim Khutornenko wrote: > Should not we rather rely on task reconciliation to do any cleanup > instead? Force GCing a task d

Re: Review Request 35813: Removing GC executor code.

2015-06-24 Thread Kevin Sweeney
> On June 23, 2015, 5:31 p.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. > > Maxim Khutornenko wrote: > Should not we rather rely on task reconciliation to do any cleanup > instead? Force GCing a task do

Review Request 35839: Add exact times to update UI.

2015-06-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35839/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1371

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 24, 2015, 9:08 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 24, 2015, 9:09 p.m.) Review request for Aurora, Kevin Sweeney and

Review Request 35840: Don't warn about unoptimized Operation SAVE_JOB_INSTANCE_UPDATE_EVENT

2015-06-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1369 https://issues

Re: Review Request 35839: Add exact times to update UI.

2015-06-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35839/#review89233 --- Ship it! Ship It! - Bill Farner On June 24, 2015, 7:05 p.m., Dav

Re: Review Request 35839: Add exact times to update UI.

2015-06-24 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35839/#review89236 --- Ship it! Ship It! - Joshua Cohen On June 24, 2015, 7:05 p.m., Da

Re: Review Request 35839: Add exact times to update UI.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35839/#review89237 --- Master (4b8c34c) is green with this patch. ./build-support/jenkins

Re: Review Request 35840: Don't warn about unoptimized Operation SAVE_JOB_INSTANCE_UPDATE_EVENT

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/#review89240 --- Master (4b8c34c) is green with this patch. ./build-support/jenkins

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89244 --- Ship it! Master (4b8c34c) is green with this patch. ./build-suppo

Re: Review Request 35840: Don't warn about unoptimized Operation SAVE_JOB_INSTANCE_UPDATE_EVENT

2015-06-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/#review89248 --- src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager

Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- Review request for Aurora, Brian Brazil and Maxim Khutornenko. Bugs: AURORA-136

Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora D

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/ --- (Updated June 24, 2015, 2:52 p.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 9:55 p.m.) Review request for Aurora, Brian Brazil and

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89252 --- src/main/python/apache/aurora/config/schema/base.py (line 48)

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89255 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
> On June 24, 2015, 9:57 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 48 > > > > > > Convention is to not capitalize acronyms like HTTP, but to render them > > as Http (here

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 10:06 p.m.) Review request for Aurora, Brian Brazil and

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89258 --- Master (d28bd4f) is red with this patch. ./build-support/jenkins/b

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89262 --- FYI i've raised a mailing list discussion questioning whether we sho

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 10:13 p.m.) Review request for Aurora, Brian Brazil and

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

2015-06-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35842/#review89257 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
> On June 24, 2015, 10:14 p.m., Bill Farner wrote: > > FYI i've raised a mailing list discussion questioning whether we should > > continue this abstraction. Figured i'd drop a note here in case it changes > > the shape of this patch. If we didn't have the abstraction, wouldn't this code revi

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Bill Farner
> On June 24, 2015, 10:14 p.m., Bill Farner wrote: > > FYI i've raised a mailing list discussion questioning whether we should > > continue this abstraction. Figured i'd drop a note here in case it changes > > the shape of this patch. > > Brian Wickman wrote: > If we didn't have the abstr

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89270 --- Master (d28bd4f) is red with this patch. ./build-support/jenkins/b

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/ --- (Updated June 24, 2015, 10:45 p.m.) Review request for Aurora, Brian Brazil and

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/ --- (Updated June 24, 2015, 10:46 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/#review89278 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89282 --- Ship it! Master (d28bd4f) is green with this patch. ./build-suppo