Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
> On June 25, 2015, 7:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the get

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-26 Thread Brian Brazil
> On June 25, 2015, 10:14 a.m., Brian Brazil wrote: > > docs/configuration-reference.md, line 449 > > > > > > If we're making this configurable, I think that we should make it apply > > to the healthcheck config too.

Re: Review Request 35847: Split http lifecycle into a composition layer.

2015-06-26 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35847/#review89513 --- Ship it! Ship It! - Brian Brazil On June 24, 2015, 10:45 p.m., B

Review Request 35928: Avoid unintentional use of TaskStatus.Reason default value.

2015-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35928/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1327 https://issue

Re: Review Request 35840: Don't warn about unoptimized Operations

2015-06-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/ --- (Updated June 26, 2015, 7:29 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35840: Don't warn about unoptimized Operations

2015-06-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/ --- (Updated June 26, 2015, 7:32 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35928: Avoid unintentional use of TaskStatus.Reason default value.

2015-06-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35928/#review89522 --- Ship it! Master (56bb1e6) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 26, 2015, 7:45 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35840: Don't warn about unoptimized Operations

2015-06-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/#review89525 --- Master (56bb1e6) is green with this patch. ./build-support/jenkins

Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository: auro

Re: Review Request 35840: Don't warn about unoptimized Operations

2015-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35840/#review89529 --- Ship it! Ship It! - Bill Farner On June 26, 2015, 5:32 p.m., Ste

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/#review89527 --- Ship it! - Zameer Manji On June 26, 2015, 10:50 a.m., Bill Farner

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Kevin Sweeney
> On June 25, 2015, 10:59 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the ge

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/#review89531 --- Ship it! Ship It! - Kevin Sweeney On June 26, 2015, 10:50 a.m.,

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89536 --- This patch does not apply cleanly on master (2ef6a05), do you need t

Re: Review Request 35932: Remove unnecessary uses of type witness.

2015-06-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/#review89535 --- This patch does not apply cleanly on master (2ef6a05), do you need t

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 26, 2015, 9 p.m.) Review request for Aurora, Kevin Sweeney and Ma

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review89548 --- Ship it! Master (2ef6a05) is green with this patch. ./build-suppo

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-26 Thread Stephan Erb
> On June 25, 2015, 7:59 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > > > > > Add getters for these fields and access them below via the get

Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/ --- Review request for Aurora, Joe Smith, Maxim Khutornenko, and Bill Farner. Bugs:

Re: Review Request 35954: Prevent quota from being set below current production reservation.

2015-06-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35954/#review89594 --- Ship it! Master (2ef6a05) is green with this patch. ./build-suppo