Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review93004 --- Master (3d9ed87) is green with this patch. ./build-support/jenkins

Re: Review Request 36710: Add an executor service decorator that gates async operations.

2015-07-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36710/#review93000 --- Ship it! Ship It! - Kevin Sweeney On July 23, 2015, 10:20 a.m.,

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92997 --- @ReviewBot retry - Kevin Sweeney On July 24, 2015, 2:38 p.m., Kev

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92996 --- Ship it! LGTM once the bot is happy. - Bill Farner On July 24, 2

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92995 --- Master (3d9ed87) is red with this patch. ./build-support/jenkins/b

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92989 --- Ship it! rad - Brian Wickman On July 24, 2015, 9:38 p.m., Kevin

Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

2015-07-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/ --- Review request for Aurora, Bill Farner and Brian Wickman. Repository: aurora

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Kevin Sweeney
Me too, but I'm okay with killing the sdist targets as an intermediate step and reintroducing them with a non-pants build On Friday, July 24, 2015, Brian Wickman wrote: > > > > On July 24, 2015, 5:57 p.m., Brian Wickman wrote: > > > src/main/python/apache/thermos/observer/BUILD, line 74 > > > <

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
> On July 24, 2015, 5:57 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/BUILD, line 74 > > > > > > This puts an aurora dependency on thermos and I imagine causes a cycle > > in the build graph

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Bill Farner
> On July 24, 2015, 5:57 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/BUILD, line 74 > > > > > > This puts an aurora dependency on thermos and I imagine causes a cycle > > in the build graph

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Kevin Sweeney
> On July 24, 2015, 10:57 a.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/BUILD, line 74 > > > > > > This puts an aurora dependency on thermos and I imagine causes a cycle > > in the build grap

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
> On July 24, 2015, 5:57 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/BUILD, line 74 > > > > > > This puts an aurora dependency on thermos and I imagine causes a cycle > > in the build graph

Re: Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/#review92952 --- Ship it! Master (55a95ba) is green with this patch. ./build-suppo

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Bill Farner
> On July 24, 2015, 5:57 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/observer/BUILD, line 74 > > > > > > This puts an aurora dependency on thermos and I imagine causes a cycle > > in the build graph

Re: Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/#review92948 --- Ship it! Ship It! - Steve Niemitz On July 24, 2015, 6 p.m., Bill

Review Request 36785: Add retroactive NEWS entry for 0.8.0.

2015-07-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36785/ --- Review request for Aurora and Steve Niemitz. Bugs: AURORA-1403 https://issu

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

2015-07-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review92944 --- src/main/python/apache/thermos/observer/BUILD (line 74)