Re: Review Request 37455: Moving ResourceAggregates into scheduler package.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37455/#review95361 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 4:53 p.m., Ma

Re: Review Request 37455: Moving ResourceAggregates into scheduler package.

2015-08-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37455/#review95360 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37379: Updating to Mesos 0.23.0.

2015-08-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95357 --- Ship it! Master (76d5a49) is green with this patch. ./build-suppo

Re: Review Request 37379: Updating to Mesos 0.23.0.

2015-08-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/ --- (Updated Aug. 13, 2015, 11:59 p.m.) Review request for Aurora and Kevin Sweeney

Re: Review Request 37379: Updating to Mesos 0.23.0.

2015-08-13 Thread Maxim Khutornenko
> On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: > > NEWS, line 11 > > > > > > Replace with "Upgraded mesos to 0.23.0" Done. > On Aug. 13, 2015, 11:53 p.m., Kevin Sweeney wrote: > > build-support/python/make-me

Re: Review Request 37379: Updating to Mesos 0.23.0.

2015-08-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37379/#review95354 --- NEWS (line 11)

Re: Review Request 37455: Moving ResourceAggregates into scheduler package.

2015-08-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37455/ --- (Updated Aug. 13, 2015, 11:53 p.m.) Review request for Aurora and Zameer Manji.

Review Request 37455: Moving ResourceAggregates into scheduler package.

2015-08-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37455/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1415 https://issue

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

2015-08-13 Thread Maxim Khutornenko
> On Aug. 13, 2015, 10:03 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 54 > > > > > > If we are going to keep this class in the long term since it is now > > more th

Re: Review Request 37366: Resources: finalizing Resources.java refactoring.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37366/#review95342 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 2:46 p.m., Ma

Re: Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/#review95341 --- Ship it! src/main/java/org/apache/aurora/scheduler/ResourceSlot.ja

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95338 --- src/main/resources/scheduler/assets/js/controllers.js (line 334)

Re: Review Request 37447: Making scheduler loop continue after mismatch.

2015-08-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37447/#review95336 --- Ship it! Master (887ffd2) is green with this patch. ./build-suppo

Re: Review Request 37447: Making scheduler loop continue after mismatch.

2015-08-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37447/#review95334 --- Ship it! Ship It! - Zameer Manji On Aug. 13, 2015, 2:25 p.m., Ma

Re: Review Request 37447: Making scheduler loop continue after mismatch.

2015-08-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37447/#review95332 --- Ship it! Ship It! - Kevin Sweeney On Aug. 13, 2015, 2:25 p.m., M

Review Request 37447: Making scheduler loop continue after mismatch.

2015-08-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37447/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-1435

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95329 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 13, 2015, 6:42 p.m

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/#review95319 --- Ship it! Master (887ffd2) is green with this patch. ./build-suppo

Re: Review Request 37365: Add a new UI page to show all tasks (active and completed) for a specific instance id.

2015-08-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37365/ --- (Updated Aug. 13, 2015, 6:42 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review95270 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 5, 2015, 5:32 p.m.

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-13 Thread Maxim Khutornenko
> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > LGTM overall. I don't have enough docker/debian expertise to deliver best > > value though. > > Bill Farner wrote: > If you are not willing to give a ship, can you please tap someone who you > would be more comfortable with giving

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-13 Thread Maxim Khutornenko
> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > build-artifact.sh, line 40 > > > > > > realpath wasn't available in our vanilla Vagrant environment. Perhaps > > add a check and/or apt-get it? > > Bill Fa

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-13 Thread Bill Farner
> On Aug. 10, 2015, 5:34 p.m., Maxim Khutornenko wrote: > > LGTM overall. I don't have enough docker/debian expertise to deliver best > > value though. If you are not willing to give a ship, can you please tap someone who you would be more comfortable with giving one? > On Aug. 10, 2015, 5:3