Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96048 --- build.gradle (line 93)

Re: Review Request 37663: Adding REVOCABLE_RESOURCES FrameworkInfo capability.

2015-08-21 Thread Maxim Khutornenko
On Aug. 21, 2015, 12:35 a.m., Zameer Manji wrote: Don't forget to create tickets about documenting this flag. Good point. Created a general feature doc ticket. On Aug. 21, 2015, 12:35 a.m., Zameer Manji wrote:

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Zameer Manji
On Aug. 21, 2015, 8:41 a.m., Kevin Sweeney wrote: commons-args/src/main/java/com/twitter/common/args/Arg.java, line 1 https://reviews.apache.org/r/37666/diff/1/?file=1045968#file1045968line1 Strip the Twitter header here and replace it with the standard license-header. I filed

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/ --- (Updated Aug. 21, 2015, 11:02 a.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Zameer Manji
On Aug. 21, 2015, 11:04 a.m., Maxim Khutornenko wrote: It would be great to preserve all commit history with this import. Any chance you could follow the sapling split procedure? It's a bit involved but pretty well documented here: https://github.com/jsirois/sapling Once the reviewers

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37666/#review96066 --- This patch does not apply cleanly on master (f4446a6), do you need

Re: Review Request 37663: Adding REVOCABLE_RESOURCES FrameworkInfo capability.

2015-08-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37663/#review96065 --- Ship it! Master (f4446a6) is green with this patch.

Re: Review Request 37666: Import of Twitter Commons.

2015-08-21 Thread Maxim Khutornenko
On Aug. 21, 2015, 6:04 p.m., Maxim Khutornenko wrote: It would be great to preserve all commit history with this import. Any chance you could follow the sapling split procedure? It's a bit involved but pretty well documented here: https://github.com/jsirois/sapling Zameer Manji

Re: Review Request 37087: Add all Docker options supported by Mesos

2015-08-21 Thread Luiz Ozaki
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37087/#review96099 --- Hi, I've been testing this merge and I'm getting the following