Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Joe Smith
> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > I'm proposing some changes in this review which I think will greatly > > simplify the code. > > Maxim Khutornenko wrote: > I agree there are ways to improve this functionality but given this is > mostly a restore of the old (and

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- (Updated Sept. 17, 2015, 12:26 p.m.) Review request for Aurora, Maxim

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Joe Smith
> On Sept. 16, 2015, 2:54 p.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java, line 40 > > > > > > Since the properties we are interested in are basically a Map

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99429 --- This is now on master. Thanks for the contribution! - Zameer Manji

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99430 --- Ship it! Master (d98bfc8) is green with this patch.

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review99428 --- Ship it! Ship It! - Zameer Manji On Sept. 17, 2015, 12:26 p.m.,

Review Request 38478: Fixing SQL schema data types.

2015-09-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38478/ --- Review request for Aurora, Joshua Cohen and Joe Smith. Bugs: AURORA-1494

Re: Review Request 38478: Fixing SQL schema data types.

2015-09-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38478/#review99465 --- Ship it! Ship It! - Bill Farner On Sept. 17, 2015, 5:36 p.m.,