Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104250 --- Ship it! Master (4a1ed1f) is green with this patch. ./build-supp

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 27, 2015, 9:17 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/#review104246 --- Master (4a1ed1f) is red with this patch. ./build-support/jenkins/

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 27, 2015, 9:14 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 39670: Modify ClusterStateImpl to be thread safe.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39670/ --- (Updated Oct. 27, 2015, 9:12 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104242 --- Master (c20346c) is red with this patch. ./build-support/jenkins/

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104239 --- Ship it! Master (c20346c) is green with this patch. ./build-supp

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-27 Thread Bill Farner
> On Oct. 26, 2015, 5:02 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java, > > line 124 > > > > > > My money is on this being the problem. The stack trace i

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104235 --- @ReviewBot retry - Zameer Manji On Oct. 27, 2015, 4:38 p.m., Zam

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review104234 --- Master (c20346c) is red with this patch. ./build-support/jenkins/

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-27 Thread Zameer Manji
> On Oct. 26, 2015, 5:02 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java, > > line 124 > > > > > > My money is on this being the problem. The stack trace i

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-27 Thread Bill Farner
> On Oct. 26, 2015, 5:02 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java, > > line 124 > > > > > > My money is on this being the problem. The stack trace i

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-27 Thread Zameer Manji
> On Oct. 26, 2015, 5:02 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java, > > line 124 > > > > > > My money is on this being the problem. The stack trace i

Re: Review Request 39670: Create immutable copy of offers for PendingTaskProcessor.

2015-10-27 Thread Zameer Manji
> On Oct. 26, 2015, 4:59 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java, > > line 133 > > > > > > Couldn't we run into the same `ConcurrentModificationExce

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/ --- (Updated Oct. 27, 2015, 4:38 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/ --- (Updated Oct. 27, 2015, 3:33 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104211 --- Master (c20346c) is red with this patch. ./build-support/jenkins/

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104205 --- @ReviewBot retry Investigating whether this is a flaky check - can

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104200 --- Master (c20346c) is red with this patch. ./build-support/jenkins/

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104186 --- Ship it! Ship It! - Zameer Manji On Oct. 27, 2015, 10:44 a.m.,

Re: Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/#review104184 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 27, 2015, 5:44 p.

Review Request 39691: Suppress no-op delete log noise during scheduler startup.

2015-10-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39691/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --