Re: Review Request 30695: Implements log rotation in the Thermos runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review109957 --- src/main/python/apache/thermos/core/runner.py (line 718)

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Dec. 11, 2015, 1:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/runner.py, line 718 > > > > > > I am not sure if it is a good idea to always enforce the gloabal > > settings, instead of

Re: Review Request 41154: Add support for performing health checks with a shell command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110040 --- src/main/python/apache/aurora/config/schema/base.py (line 46)

Re: Review Request 41154: Add support for performing health checks with a shell command.

> On Dec. 11, 2015, 4:06 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 50 > > > > > > I second Zameer's concerns about logical conflict between the new > >

Re: Review Request 41154: Add support for performing health checks with a shell command.

> On Dec. 11, 2015, 7:43 p.m., Zameer Manji wrote: > > Overall this LGTM. The only thing holding back my shipit is a possible > > addition to the e2e test suite. > > > > Bill, Maxim, Josh: Do you think this change requires an addition to the e2e > > suite? I'm on the fence. It seems overkill

Re: Review Request 41154: Add support for performing health checks with a shell command.

> On Dec. 12, 2015, 12:06 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 50 > > > > > > I second Zameer's concerns about logical conflict between the new > >

Re: Review Request 41154: Add support for performing health checks with a shell command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review109992 --- Overall this LGTM. The only thing holding back my shipit is a

Re: Review Request 41226: Handling task event race in updater.

> On Dec. 11, 2015, 7:07 p.m., Bill Farner wrote: > > Can you take a stab at illustrating in the description how this problem > > manifests? The current shape of the patch feels like it papers over a > > problem that we might be left to solve again, so thinking about the problem > > at a

Re: Review Request 30695: Implements log rotation in the Thermos runner.

> On Dec. 11, 2015, 5:20 a.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/runner.py, line 718 > > > > > > I am not sure if it is a good idea to always enforce the gloabal > > settings, instead of

Re: Review Request 41226: Handling task event race in updater.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41226/#review109984 --- Can you take a stab at illustrating in the description how this