Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/ --- (Updated Dec. 14, 2015, 10:39 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/#review110436 --- Ship it! Master (c66d9f5) is green with this patch. ./build-supp

Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/ --- (Updated Dec. 14, 2015, 10 p.m.) Review request for Aurora and Maxim Khutornenk

Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Bill Farner
> On Dec. 14, 2015, 9:54 p.m., Maxim Khutornenko wrote: > > build.gradle, line 308 > > > > > > Remove in favor of https://reviews.apache.org/r/41391/? Yeah, this snuck in because i couldn't stand waiting 1+ minutes

Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/#review110425 --- Reviewer notes. build.gradle (line 89)

Re: Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/#review110426 --- Ship it! build.gradle (line 307)

Review Request 41392: Upgrade to jetty 9.3.6.v20151106.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/ --- Review request for Aurora. Repository: aurora Description --- Jetty 7 an

Re: Review Request 41391: Disable task caching for the generateBuildProperties task.

2015-12-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41391/#review110422 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 15, 2015, 4:44 a.

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110417 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 15, 2015, 4:57 a.

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110412 --- Ship it! Master (f91ecd1) is green with this patch. ./build-supp

Re: Review Request 41391: Disable task caching for the generateBuildProperties task.

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41391/#review110408 --- Ship it! Master (f91ecd1) is green with this patch. ./build-supp

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/ --- (Updated Dec. 15, 2015, 4:57 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110405 --- Master (f91ecd1) is red with this patch. ./build-support/jenkins/

Review Request 41391: Disable task caching for the generateBuildProperties task.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41391/ --- Review request for Aurora, Joe Smith and Zameer Manji. Repository: aurora Des

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110404 --- @ReviewBot retry - Dmitriy Shirchenko On Dec. 15, 2015, 3:56 a.m

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
> On Dec. 15, 2015, 4:06 a.m., Aurora ReviewBot wrote: > > Master (f91ecd1) is red with this patch. > > ./build-support/jenkins/build.sh > > > > virtualenv-12.1.1/virtualenv_support/ > > virtualenv-12.1.1/virtualenv_support/__init__.py > > virtualenv-12.1.1/virtualenv_support/pip-6.1.1-py2.py3

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110396 --- Master (f91ecd1) is red with this patch. ./build-support/jenkins/

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
> On Dec. 12, 2015, 12:06 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 51 > > > > > > Please, don't use 'type' for a field name. It's too generic and clashes > > with p

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/ --- (Updated Dec. 15, 2015, 3:56 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 41368: Remove the client-side updater.

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110334 --- Ship it! Master (f91ecd1) is green with this patch. ./build-supp

Review Request 41368: Remove the client-side updater.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-785

Re: Review Request 41367: Document mesos.hostname in reference

2015-12-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41367/#review110313 --- Ship it! Master (bf43f8c) is green with this patch. ./build-supp

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41315/ --- (Updated Dec. 14, 2015, 2:02 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 41367: Document mesos.hostname in reference

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41367/#review110315 --- Ship it! Thanks! - Bill Farner On Dec. 14, 2015, 1:58 p.m., Chr

Re: Review Request 41367: Document mesos.hostname in reference

2015-12-14 Thread Chris Bannister
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41367/ --- (Updated Dec. 14, 2015, 1:58 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41315/#review110314 --- Ship it! Ship It! - Vinod Kone On Dec. 14, 2015, 9:25 p.m., Bil

Review Request 41367: Document mesos.hostname in reference

2015-12-14 Thread Chris Bannister
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41367/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41315/ --- (Updated Dec. 14, 2015, 1:25 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Bill Farner
> On Dec. 14, 2015, 4:47 a.m., Stephan Erb wrote: > > I'd vote for sticking with 0.24.1, as Mesos devs have just recently urged > > users not to skip updates > > (http://www.mail-archive.com/user@mesos.apache.org/msg05379.html). > > Maxim Khutornenko wrote: > +1. I don't think we can skip

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Bill Farner
> On Dec. 14, 2015, 10:38 a.m., Zameer Manji wrote: > > Mind linking this to https://issues.apache.org/jira/browse/AURORA-1543 and > > assigning the ticket to yourself? Thanks for the reminder, done. - Bill --- This is an automatically

Re: Review Request 41154: Add support for performing health checks with a shell command.

2015-12-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41154/#review110285 --- Ship it! So long as a blocking ticket is filed for AURORA-1525 I'm

Re: Review Request 41331: Upgrade to pants 0.0.64 and pex 1.1.1.

2015-12-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41331/#review110284 --- Ship it! Ship It! - Zameer Manji On Dec. 13, 2015, 3:32 p.m., J

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41315/#review110281 --- Ship it! Mind linking this to https://issues.apache.org/jira/brows

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41315/#review110259 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 12, 2015, 4:49 p.

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Maxim Khutornenko
> On Dec. 14, 2015, 12:47 p.m., Stephan Erb wrote: > > I'd vote for sticking with 0.24.1, as Mesos devs have just recently urged > > users not to skip updates > > (http://www.mail-archive.com/user@mesos.apache.org/msg05379.html). +1. I don't think we can skip 0.24 due to protobuf -> JSON forma

Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.

2015-12-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41315/#review110215 --- Ship it! I'd vote for sticking with 0.24.1, as Mesos devs have jus

Re: Review Request 41331: Upgrade to pants 0.0.64 and pex 1.1.1.

2015-12-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41331/#review110213 --- Ship it! Ship It! - Stephan Erb On Dec. 14, 2015, 12:32 a.m., J