Re: Review Request 41732: Slight documentation overhaul

> On Dec. 27, 2015, 11:20 p.m., Stephan Erb wrote: > > Looks like you have pushed the previous version without the review changes. > > Bill Farner wrote: > Oy, sorry about that. I yanked it from your branch (since i can't pull > the patch with binaries) and neglected to check if it

Re: Review Request 41711: Move all command line argument declarations to modules or SchedulerMain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41711/#review111980 --- Ship it! LGTM. Removing the access of global state is good as it

Re: Review Request 41743: Added a note for committers on formatting commit messages generated by ./rbt patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41743/#review111994 --- CONTRIBUTING.md (line 83)

Re: Review Request 41743: Added a note for committers on formatting commit messages generated by ./rbt patch

> On Dec. 28, 2015, 7:58 a.m., Joshua Cohen wrote: > > CONTRIBUTING.md, line 83 > > > > > > Let me know if you think this should be 100 chars? Yeah, makes sense to match other column limits we use. - Bill

Re: Review Request 41743: Added a note for committers on formatting commit messages generated by ./rbt patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41743/#review112007 --- Ship it! Ship It! - Bill Farner On Dec. 28, 2015, 7:58 a.m.,

Re: Review Request 41743: Added a note for committers on formatting commit messages generated by ./rbt patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41743/ --- (Updated Dec. 28, 2015, 5:15 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 41743: Added a note for committers on formatting commit messages generated by ./rbt patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41743/#review112002 --- Ship it! Master (f56ea26) is green with this patch.

Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41755/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1566

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41755/#review112083 --- Ship it! Master (eec985d) is green with this patch.

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41755/ --- (Updated Dec. 28, 2015, 4:15 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

> On Dec. 25, 2015, 10:10 a.m., Stephan Erb wrote: > > I will implemnet all recommended changes. > On Dec. 25, 2015, 10:10 a.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 62 > > > > >

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112116 ---

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112117 --- Ship it! Master (41c71d9) is green with this patch.

Review Request 41763: Update a handful of dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41763/ --- Review request for Aurora, Joshua Cohen and John Sirois. Repository: aurora

Re: Review Request 41763: Update a handful of dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41763/#review112118 --- Master (41c71d9) is green with this patch.

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41755/#review112088 --- Ship it! Not sure if you saw but setting classpath to null was

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote: > > Not sure if you saw but setting classpath to null was the suggested work > > around on my post on the gradle forum. Ouch - did not. I played for a good while trying to build up the proper classpath and finally gave up trying to unset-it.

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41755/#review112099 --- Ship it! Master (eec985d) is green with this patch.

Re: Review Request 41201: Preserve env variables for tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review112098 --- Ship it! Ship It! - Bill Farner On Dec. 27, 2015, 8:36 p.m.,

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote: > > Not sure if you saw but setting classpath to null was the suggested work > > around on my post on the gradle forum. > > John Sirois wrote: > Ouch - did not. I played for a good while trying to build up the proper > classpath and

Review Request 41756: Adapt to gradle upgrade in aurora repo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41756/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1566

Re: Review Request 41755: Upgrade to Gradle 2.10 to pick up perf wins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41755/ --- (Updated Dec. 28, 2015, 4:59 p.m.) Review request for Aurora, Bill Farner and