Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2015-12-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review112365 --- Master (aac7aad) is red with this patch. ./build-support/jenkins/

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2015-12-30 Thread Bill Farner
> On Dec. 30, 2015, 4:14 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java, > > line 123 > > > > > > It might be slightly less churn to move these in t

Re: Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2015-12-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review112363 --- Ship it! I'd be happy with these commits landing as they come, but

Re: Review Request 41786: Remove several scheduler command line arguments.

2015-12-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41786/#review112362 --- Ship it! Ship It! - Zameer Manji On Dec. 29, 2015, 5:52 p.m., B

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

2015-12-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112361 --- Ship it! Ship It! - Zameer Manji On Dec. 29, 2015, 9:09 a.m., B

Review Request 41804: Proposal - shim interfaces to preface args system overhaul.

2015-12-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora D

Re: Review Request 41785: Remove scheduler log scaffolding

2015-12-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review112360 --- Can only test reviews with 1 parent, found 2: https://revie

Re: Review Request 41813: Fixup invalid error message formatting.

2015-12-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41813/#review112358 --- Ship it! Ship It! - Bill Farner On Dec. 30, 2015, 3:53 p.m., Jo

Re: Review Request 41812: Fixup multi-parent error message.

2015-12-30 Thread John Sirois
> On Dec. 30, 2015, 4:50 p.m., John Sirois wrote: > > build-support/jenkins/review_feedback.py, line 133 > > > > > > Rushed this one - 'RB#%d' is no longer correct. > > Another xix RB coming. Over here: https://

Review Request 41813: Fixup invalid error message formatting.

2015-12-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41813/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 41812: Fixup multi-parent error message.

2015-12-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41812/#review112356 --- build-support/jenkins/review_feedback.py (line 133)

Re: Review Request 41785: Remove scheduler log scaffolding

2015-12-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review112355 --- @ReviewBot retry - John Sirois On Dec. 29, 2015, 11:29 p.m., Bil

Re: Review Request 41812: Fixup multi-parent error message.

2015-12-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41812/#review112353 --- Ship it! Ship It! - Bill Farner On Dec. 30, 2015, 3:33 p.m., Jo

Review Request 41812: Fixup multi-parent error message.

2015-12-30 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41812/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 41809: Allow custom announce path

2015-12-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112352 --- Pausing review here - in-flight discussion on the linked ticket. -

Re: Review Request 41809: Allow custom announce path

2015-12-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/#review112351 --- Master (43f58bb) is red with this patch. ./build-support/jenkins/

Review Request 41809: Allow custom announce path

2015-12-30 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41809/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora D

Re: Review Request 41762: Upgrade ZooKeeper dep to 3.4.2

2015-12-30 Thread Stephan Erb
> On Dec. 29, 2015, 1:37 p.m., Stephan Erb wrote: > > Looks like the 3.4 client also requires a 3.4 ZK server [1]. So, would it > > be possible to get a deprecation cycle for that change (i.e., announce in > > 0.12 and bump in 0.13)? > > > > Unfortunately, we are still running our masters on a