Re: Review Request 42042: Proof of concept - param interface implementations defined based on command line args

2016-01-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42042/#review113395 --- Master (206a48b) is red with this patch. ./build-support/jenkins/

Review Request 42042: Proof of concept - param interface implementations defined based on command line args

2016-01-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42042/ --- Review request for Aurora and John Sirois. Repository: aurora Description ---

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread John Sirois
> On Jan. 7, 2016, 4:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default? Should

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Zameer Manji
> On Jan. 7, 2016, 3:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default? Should

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113359 --- Master (206a48b) is green with this patch. ./build-support/jenkin

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread John Sirois
> On Jan. 7, 2016, 4:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default? Should

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Zameer Manji
> On Jan. 7, 2016, 3:21 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 126 > > > > > > Are there any perf implications from having it ON by default? Should

Re: Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/#review113355 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java

Review Request 42041: Enable H2 query statistics collection.

2016-01-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42041/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Repository: auror

Re: Review Request 42034: Adding gpg key for jsir...@apache.org.

2016-01-07 Thread John Sirois
> On Jan. 7, 2016, 2:13 p.m., Zameer Manji wrote: > > Don't forget to put it in the `dev/aurora` and `release/aurora` directories > > on the dist svn. Yup - have those staged. - John --- This is an automatically generated e-mail. To re

Re: Review Request 42034: Adding gpg key for jsir...@apache.org.

2016-01-07 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42034/#review113325 --- Ship it! Don't forget to put it in the `dev/aurora` and `release/a

Re: Review Request 42034: Adding gpg key for jsir...@apache.org.

2016-01-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42034/#review113321 --- Ship it! Master (367e6b7) is green with this patch. ./build-supp

Review Request 42034: Adding gpg key for jsir...@apache.org.

2016-01-07 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42034/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

2016-01-07 Thread Stephan Erb
> On Jan. 6, 2016, 10:02 nachm., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 561 > > > > > > Is this timeout change intentional? > > Martin Hrabovcin wrote: > I've changed this va

Re: Review Request 41785: Replace scheduler log scaffolding with logback

2016-01-07 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review113300 --- Ship it! commons/src/main/java/org/apache/aurora/common/net/http/

Re: Review Request 41785: Replace scheduler log scaffolding with logback

2016-01-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41785/#review113305 --- Master (367e6b7) is green with this patch. ./build-support/jenkin

Re: Review Request 40922: Thermos: Add ability to specify process outputs destination

2016-01-07 Thread Martin Hrabovcin
> On Jan. 6, 2016, 9:02 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/process.py, line 561 > > > > > > Is this timeout change intentional? I've changed this value to .1 because tests were taking s