Re: Review Request 42332: Trigger shutdown on task pruning failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114623 --- Ship it! Master (4dff5da) is green with this patch. ./build-supp

Review Request 42332: Trigger shutdown on task pruning failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Bugs: AURORA-1582

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114613 --- Master (4dff5da) is green with this patch. ./build-support/jenkin

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114611 --- Ship it! Ship It! - John Sirois On Jan. 14, 2016, 4:58 p.m., Za

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/ --- (Updated Jan. 14, 2016, 3:58 p.m.) Review request for Aurora, John Sirois and M

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114608 --- Master (4dff5da) is green with this patch. ./build-support/jenkin

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114607 --- Ship it! src/main/java/org/apache/aurora/scheduler/base/AsyncUtil

Review Request 42328: Add metric for counting uncaught exceptions in async executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Bugs: AURORA-1582

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114589 --- Amol, can you please rebase so I can apply this change? - Zameer M

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114580 --- Ship it! Ship It! - Zameer Manji On Jan. 14, 2016, 1:10 p.m., A

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114579 --- Ship it! Master (a80260e) is green with this patch. ./build-supp

Re: Review Request 42321: fix typo in the user guide about Task Updates

> On Jan. 14, 2016, 2:24 p.m., John Sirois wrote: > > Ship It! Thanks for going from PR -> RB! - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42321/#review114576 -

Re: Review Request 42321: fix typo in the user guide about Task Updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42321/#review114576 --- Ship it! Ship It! - John Sirois On Jan. 14, 2016, 2:23 p.m., An

Review Request 42321: fix typo in the user guide about Task Updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42321/ --- Review request for Aurora. Repository: aurora Description --- fix typo i

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/ --- (Updated Jan. 14, 2016, 1:10 p.m.) Review request for Aurora, Joshua Cohen, Max

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

> On Jan. 14, 2016, 12:29 p.m., Bill Farner wrote: > > One more drive-by: in the test I don't believe you need captures. EasyMock > > gives you access to call arguments (EasyMock.getCurrentArguments I believe) > > within the andAnswer. This unfortunately requires you to cast, but I find > >

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

> On Jan. 14, 2016, 12:26 p.m., Bill Farner wrote: > > On mobile and can't comment on the specific line, but you should qualify > > the `Filter` binding with a binding annotation. This is best practice for > > any binding that is moderately generic. Ack. - Amol ---

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114560 --- One more drive-by: in the test I don't believe you need captures.

Re: Review Request 42046: Allow for plugging in cli-configurable filters that are invoked post shiro filters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42046/#review114557 --- On mobile and can't comment on the specific line, but you should qu

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114532 --- Ship it! Ship It! - Dmitriy Shirchenko On Jan. 14, 2016, 6:23 p

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114535 --- Ship it! Master (952ef6d) is green with this patch. ./build-supp

Re: Review Request 42126: Accept resource offers from multiple framework roles.

> On Jan. 14, 2016, 6:31 p.m., Maxim Khutornenko wrote: > > Ship It! Waiting for Dmitriy to sign off before committing it to master. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114529 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 14, 2016, 6:23 p.

Re: Review Request 42126: Accept resource offers from multiple framework roles.

> On Jan. 14, 2016, 6:14 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, > > line 95 > > > > > > This is still not technically correct. If rol

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ --- (Updated Jan. 14, 2016, 6:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114519 --- src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverS

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114496 --- Ship it! Master (952ef6d) is green with this patch. ./build-supp

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ --- (Updated Jan. 14, 2016, 4:32 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 42126: Accept resource offers from multiple framework roles.

> On Jan. 14, 2016, 1:06 a.m., Dmitriy Shirchenko wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > lines 216-217 > > > > > > Is this intentionally commented out? > > Zhi

Re: Review Request 42126: Accept resource offers from multiple framework roles.

> On Jan. 14, 2016, 2:45 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > line 216 > > > > > > I assume this line will be restored once `AcceptedOffer`

Re: Review Request 42126: Accept resource offers from multiple framework roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/ --- (Updated Jan. 14, 2016, 6:46 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 42126: New class to allocate resources of multiple roles from offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42126/#review114478 --- src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryIm

Re: Review Request 42126: New class to allocate resources of multiple roles from offer.

> On Jan. 13, 2016, 5:06 p.m., Dmitriy Shirchenko wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > lines 216-217 > > > > > > Is this intentionally commented out? > > Zhi