Re: Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42532/#review115313 --- Master (fe13e4e) is green with this patch. ./build-support/jenkin

Re: Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42532/#review115309 --- Ship it! Ship It! - John Sirois On Jan. 19, 2016, 6:28 p.m., Bi

Review Request 42532: Revert "Shim interfaces to preface args system overhaul."

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42532/ --- Review request for Aurora and John Sirois. Repository: aurora Description ---

Re: Review Request 42387: working version of jessie builds

> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote: > > specs/debian/aurora-scheduler.postinst, line 38 > > > > > > `specs/debian/aurora-scheduler.init` uses > > `PIDFILE=/var/run/aurora-scheduler.pid` - who uses `/va

Re: Review Request 42387: working version of jessie builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 20, 2016, 12:59 a.m.) Review request for Aurora, Benjamin Staffin

Re: Review Request 42387: working version of jessie builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115281 --- I'm running through a test presently - will report back. specs/de

Re: Review Request 42387: working version of jessie builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 20, 2016, 12:04 a.m.) Review request for Aurora, Benjamin Staffin

Re: Review Request 42387: working version of jessie builds

> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote: > > This built fine for me, and installed fine as well, but the resulting > > scheduler has stdout and stderr attached to /dev/null which needs to be > > fixed (no logs). I had a harder time than I might resoning through things > > since this

Re: Review Request 42387: working version of jessie builds

> On Jan. 17, 2016, 10:54 a.m., Stephan Erb wrote: > > specs/debian/aurora-scheduler.init, line 73 > > > > > > IIRC the `start-stop-daemon` does not restart failed processes. How > > does this interact with Aurora co

Re: Review Request 42387: working version of jessie builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 19, 2016, 11:23 p.m.) Review request for Aurora, Benjamin Staffin

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115250 --- Master (317aa4d) is green with this patch. ./build-support/jenkin

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115244 --- Ship it! Looking forward to the followup change that collapses som

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java, > > line 67 > > > > > > The defaults aren't applied consistently here, not sometimes at

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42177/#review115236 --- Ship it! Ship It! - Bill Farner On Jan. 19, 2016, 10:46 a.m., Z

Re: Review Request 42445: Upgrade pants to 0.0.68.

> On Jan. 19, 2016, 1:06 p.m., John Sirois wrote: > > I'm going to patch this in presently, but wave hellow to Joe! /wave - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42445/#review11

Re: Review Request 42445: Upgrade pants to 0.0.68.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42445/#review115233 --- I'm going to patch this in presently, but wave hellow to Joe! - Jo

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#review115222 --- Ship it! Ship It! - Joshua Cohen On Jan. 12, 2016, 7:58 p.m., G

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#review115223 --- George, there's a merge conflict in NEWS, can you rebase and post a

Re: Review Request 42387: working version of jessie builds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115221 --- specs/debian/aurora-scheduler.init (line 73)

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42177/#review115210 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 19, 2016, 6:46 p.

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

> On Jan. 19, 2016, 6:39 p.m., Maxim Khutornenko wrote: > > examples/vagrant/upstart/mesos-master.conf, line 27 > > > > > > Is this really needed? All logs are currently dumped under > > /var/log/upstart if I remembe

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

> On Jan. 19, 2016, 10:39 a.m., Maxim Khutornenko wrote: > > examples/vagrant/upstart/mesos-master.conf, line 27 > > > > > > Is this really needed? All logs are currently dumped under > > /var/log/upstart if I rememb

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42177/ --- (Updated Jan. 19, 2016, 6:46 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

> On Jan. 19, 2016, 6:39 p.m., Maxim Khutornenko wrote: > > examples/vagrant/upstart/mesos-master.conf, line 27 > > > > > > Is this really needed? All logs are currently dumped under > > /var/log/upstart if I remembe

Re: Review Request 42177: Vagrant change to reserve part of the dev cluster's resources to 'aurora-role'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42177/#review115204 --- examples/vagrant/upstart/mesos-master.conf (line 27)

Re: Review Request 42475: Fixup broken jmh benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42475/#review115203 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 18, 2016, 10:37 p

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115197 --- Ship it! Ship It! - John Sirois On Jan. 19, 2016, 10:49 a.m., B

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/ --- (Updated Jan. 19, 2016, 9:49 a.m.) Review request for Aurora, John Sirois and Z

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

> On Jan. 19, 2016, 9:36 a.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java, > > line 168 > > > > > > The comment can go now that this is wrapped in a presen

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115191 --- Ship it! src/main/java/org/apache/aurora/scheduler/log/mesos/Meso

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/ --- (Updated Jan. 19, 2016, 9:31 a.m.) Review request for Aurora, John Sirois and Z

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

> On Jan. 19, 2016, 8:34 a.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java, > > line 178 > > > > > > This will need some adjustment to keep the improved failu

Re: Review Request 41804: Shim interfaces to preface args system overhaul.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41804/#review115175 --- Ship it! src/main/java/org/apache/aurora/scheduler/log/mesos/Meso