Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116134 --- Ship it! Master (5684c64) is green with this patch.

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-25 Thread Bill Farner
> On Jan. 25, 2016, 10:27 a.m., Stephan Erb wrote: > > General question: How do we want to handle corresponding updates in the > > packaging repo? In an immediate additional review request or in a general > > overhaul before the next release? Great question! So far it's been ad-hoc, with an

Re: Review Request 42727: Remove the --announcer-enable executor flag.

2016-01-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42727/#review116136 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 25, 2016,

Re: Review Request 42737: fixng reference in table of contents to Docker Object(s)

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42737/#review116164 --- Ship it! Master (98a4c0e) is green with this patch.

Review Request 42737: fixng reference in table of contents to Docker Object(s)

2016-01-25 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42737/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 42737: fixng reference in table of contents to Docker Object(s)

2016-01-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42737/#review116160 --- Ship it! Ship It! - Bill Farner On Jan. 25, 2016, 12:40

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

2016-01-25 Thread Bill Farner
> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will

Review Request 42748: [1/3] Introduce a thrift java code generator.

2016-01-25 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42748/ --- Review request for Aurora. Repository: aurora Description --- This

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

2016-01-25 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116204 --- NB: Please hold off on review pending an email to dev@ explaining

Re: Review Request 42749: [2/3] Add an annotation processor to generate db views.

2016-01-25 Thread John Sirois
> On Jan. 25, 2016, 3:55 p.m., Aurora ReviewBot wrote: > > Master (39815a3) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :buildSrc:thriftGen:classes > > :buildSrc:thriftGen:jar > > :buildSrc:compileJava UP-TO-DATE > > :buildSrc:compileGroovy > >

Re: Review Request 42565: Remove support for adding guice modules via command line arguments.

2016-01-25 Thread Zameer Manji
> On Jan. 21, 2016, 6:44 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java, > > line 80 > > > > > > Just to be clear, this command line argument will

Re: Review Request 42749: [2/3] Add an annotation processor to generate db views.

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42749/#review116208 --- Master (39815a3) is red with this patch.

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116207 --- Master (39815a3) is red with this patch.

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

2016-01-25 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- (Updated Jan. 25, 2016, 4:22 p.m.) Review request for Aurora. Changes

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116219 --- Master (39815a3) is red with this patch.

Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

2016-01-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42759/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1258

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

2016-01-25 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42748/#review116199 --- NB: Please hold off on review pending an email to dev@ explaining

Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

2016-01-25 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/ --- Review request for Aurora. Repository: aurora Description --- This

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42748/#review116206 --- Ship it! Master (39815a3) is green with this patch.

Re: Review Request 42756: [3/3] Convert thrift codegen to use ThriftGen.

2016-01-25 Thread John Sirois
> On Jan. 25, 2016, 3:55 p.m., Aurora ReviewBot wrote: > > Master (39815a3) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :buildSrc:compileGroovy > > :buildSrc:processResources UP-TO-DATE > > :buildSrc:classes > > :buildSrc:jar > > :buildSrc:assemble > >

Re: Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42759/#review116223 --- Ship it! Master (39815a3) is green with this patch.

Re: Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

2016-01-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42759/#review116222 ---

Re: Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

2016-01-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42759/ --- (Updated Jan. 26, 2016, 2:42 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

2016-01-25 Thread Maxim Khutornenko
> On Jan. 26, 2016, 12:08 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 759 > > > > > > `int` cannot be `null`, so `@Nullable` is out of place

Re: Review Request 42759: Re-purposing addInstances RPC to act as scaleOut

2016-01-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42759/#review116265 --- Ship it! Master (39815a3) is green with this patch.