Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/ --- (Updated Jan. 27, 2016, 11:17 p.m.) Review request for Aurora, Bill Farner,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116637 --- Ship it! NEWS (line 45)

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116647 --- Ship it! Ship It! - Zhitao Li On Jan. 27, 2016, 10:52 p.m.,

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/#review116682 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 26, 2016,

Re: Review Request 42748: [1/3] Introduce a thrift java code generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42748/#review116653 --- A few notes for reviewers.

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116643 --- Ship it! Master (c417f9d) is green with this patch.

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116650 --- Ship it! Master (e240fdc) is green with this patch.

Re: Review Request 42882: Improving job update query performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42882/#review116671 --- Ship it! This is one of the places where i'm impressed with

Review Request 42879: Allow dots and hyphens in metric names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42879/ --- Review request for Aurora, Joe Smith and Maxim Khutornenko. Bugs: AURORA-1282

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/ --- (Updated Jan. 27, 2016, 11:52 p.m.) Review request for Aurora, Bill Farner,

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

> On Jan. 27, 2016, 11:31 p.m., Zhitao Li wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 77 > > > > > > Hmm, I think this is missing a trailing dot. Uups, good catch. -

Re: Review Request 42845: Enable H2 logging to slf4j.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116634 --- Master (e2a973e) is green with this patch.

Re: Review Request 42882: Improving job update query performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42882/#review116678 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2016, 4:25

Re: Review Request 42879: Allow dots and hyphens in metric names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42879/#review116679 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 27, 2016,

Review Request 42898: Fixup release-candidate script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42898/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 42896: Remove timestamp from task IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42896/#review116720 --- Master (89fad5a) is green with this patch.

Re: Review Request 42898: Fixup release-candidate script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42898/#review116718 --- Ship it! Master (89fad5a) is green with this patch.

Re: Review Request 42896: Remove timestamp from task IDs.

> On Jan. 28, 2016, 5:56 a.m., Aurora ReviewBot wrote: > > Master (89fad5a) is green with this patch. > > ./build-support/jenkins/build.sh > > > > However, it appears that it might lack test coverage. > > > > I will refresh this build result if you post a review containing > > "@ReviewBot

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/ --- (Updated Jan. 27, 2016, 6:22 p.m.) Review request for Aurora, John Sirois and

Review Request 42896: Remove timestamp from task IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42896/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora

Re: Review Request 42896: Remove timestamp from task IDs.

> On Jan. 27, 2016, 9:56 p.m., Aurora ReviewBot wrote: > > Master (89fad5a) is green with this patch. > > ./build-support/jenkins/build.sh > > > > However, it appears that it might lack test coverage. > > > > I will refresh this build result if you post a review containing > > "@ReviewBot

Re: Review Request 42898: Fixup release-candidate script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42898/#review116717 --- Re-read http://markmail.org/message/jpgktgo5czkwb65b and it looks

Re: Review Request 35990: Map Aurora task metadata to Mesos task labels

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35990/#review116639 ---

Re: Review Request 42879: Allow dots and hyphens in metric names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42879/#review116658 --- Ship it! Master (e240fdc) is green with this patch.

Re: Review Request 42882: Improving job update query performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42882/ --- (Updated Jan. 28, 2016, 12:25 a.m.) Review request for Aurora, Bill Farner and

Review Request 42882: Improving job update query performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42882/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora

Re: Review Request 42882: Improving job update query performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42882/#review116675 --- Master (e240fdc) is green with this patch.

Re: Review Request 42845: Enable H2 logging to slf4j.

> On Jan. 27, 2016, 9:56 a.m., Bill Farner wrote: > > Are you sure this patch does what you want? When i apply the patch and run > > the scheduler in vagrant, the `h2database` logger shows as level `WARN` in > > `/logconfig`. When at level `DEBUG`, there is likely far more verbose you > >

Re: Review Request 42845: Enable H2 logging to slf4j.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116602 --- Are you sure this patch does what you want? When i apply the

Re: Review Request 42845: Enable H2 logging to slf4j.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116604 --- Ship it! Fine to ship, suggested a bit of minor cleanup.

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/ --- (Updated Jan. 27, 2016, 1:15 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 42811: Remove deprecated fields made redundant by JobKey.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42811/#review116615 --- Maxim - ping? - Bill Farner On Jan. 26, 2016, 11:04 a.m., Bill

Re: Review Request 42816: Remove deprecated `HealthCheckConfig` fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42816/#review116613 --- Rebasing against master to fixup NEWS conflict before submitting.

Review Request 42869: Fix stray printf style log replacement token when logging triggered cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42869/ --- Review request for Aurora, John Sirois and Maxim Khutornenko. Repository:

Re: Review Request 42869: Fix stray printf style log replacement token when logging triggered cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42869/#review116623 --- Ship it! Ship It! - John Sirois On Jan. 27, 2016, 2:16

Re: Review Request 42845: Enable H2 logging to slf4j.

> On Jan. 27, 2016, 10:41 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, lines > > 118-119 > > > > > > Please change this to explain that level 4 indicates intent

Re: Review Request 42845: Enable H2 logging to slf4j.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/ --- (Updated Jan. 27, 2016, 1:38 p.m.) Review request for Aurora, Maxim

Re: Review Request 42845: Enable H2 logging to slf4j.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42845/#review116630 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 27, 2016,

Re: Review Request 42869: Fix stray printf style log replacement token when logging triggered cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42869/#review116631 --- Master (e2a973e) is green with this patch.

Re: Review Request 42869: Fix stray printf style log replacement token when logging triggered cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42869/#review116632 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2016, 1:16