Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130236 --- Ship it! Master (d339036) is green with this patch. ./build-s

Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-945

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130229 --- Ship it! Master (d339036) is green with this patch. ./build-s

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 23, 2016, 12:16 a.m.) Review request for Aurora, Joshua Cohen, B

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130215 --- Ship it! Master (95dcca5) is green with this patch. ./build-s

Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

2016-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130214 --- Ship it! Master (95dcca5) is green with this patch. ./build-s

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 22, 2016, 10:48 p.m.) Review request for Aurora, Joshua Cohen, B

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Maxim Khutornenko
> On April 22, 2016, 6:55 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java, > > line 210 > > > > > > Instead of having a switch statement here, perhaps it

Re: Review Request 46591: Add GPU design document

2016-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46591/#review130212 --- Ship it! Master (95dcca5) is green with this patch. ./build-s

Re: Review Request 46591: Add GPU design document

2016-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46591/#review130211 --- Ship it! Ship It! - Maxim Khutornenko On April 22, 2016, 10:

Review Request 46591: Add GPU design document

2016-04-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46591/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

2016-04-22 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130208 --- Ship it! Ship It! - Stephan Erb On April 22, 2016, 11:54 p.m

Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

2016-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1631

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130140 --- src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBod

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130120 --- Master (95dcca5) is red with this patch. ./build-support/jenkins

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/ --- (Updated April 22, 2016, 4:45 p.m.) Review request for Aurora, Joshua Cohen, Bi

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Maxim Khutornenko
> On April 22, 2016, 3:15 p.m., Joshua Cohen wrote: > > Overall looks good to me. One question though: what happens in the scenario > > where we receive a TaskConfig that has both the individual task-level > > resources populated as well as the new resource collection. Further, what > > happen

Re: Review Request 46459: Schema changes for resource management refactoring

2016-04-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46459/#review130096 --- Overall looks good to me. One question though: what happens in the