Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130886 --- @ReviewBot retry - Stephan Erb On April 28, 2016, 12:44 a.m., S

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130863 --- Master (e817eb1) is red with this patch. ./build-support/jenkins

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/ --- (Updated April 28, 2016, 12:44 a.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130859 --- Ship it! Ship It! - Maxim Khutornenko On April 27, 2016, 10:

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130857 --- Master (7e30ebe) is red with this patch. ./build-support/jenkins

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Stephan Erb
> On April 24, 2016, 5:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java, line 51 > > > > > > Does this default value effect the same behavior as before the patch? > >

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/ --- (Updated April 28, 2016, 12:12 a.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/#review130855 --- Ship it! Master (7e30ebe) is green with this patch. ./build-s

Re: Review Request 46603: Introduce command line option to control the offer filter duration

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46603/ --- (Updated April 27, 2016, 11:49 p.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/ --- (Updated April 27, 2016, 11:36 p.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 46739: using-aurora

2016-04-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46739/#review130840 --- Awesome :-) Great to have you on the list! - Stephan Erb On Apr

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

2016-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/#review130830 --- Master (a5b9603) is red with this patch. ./build-support/jenkins

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

2016-04-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/ --- (Updated April 27, 2016, 6:38 p.m.) Review request for Aurora, Joshua Cohen, Bi

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

2016-04-27 Thread Maxim Khutornenko
> On April 27, 2016, 5:43 p.m., Bill Farner wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 281 > > > > > > Can you document this, and call out which fields will be set/expected > > by which ve

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

2016-04-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/#review130813 --- Fix it, then Ship it! LGTM, left issues to give the async ship.

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

2016-04-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/#review130812 --- Ship it! Ship It! - Zameer Manji On April 26, 2016, 5:31 p.m

Re: Review Request 46739: using-aurora

2016-04-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46739/#review130796 --- Ship it! Ship It! - Joshua Cohen On April 27, 2016, 1:22 p.m

Re: Review Request 46716: ResourceAggregate schema changes for resource refactoring.

2016-04-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46716/#review130795 --- Ship it! Ship It! - Joshua Cohen On April 27, 2016, 12:31 a.

Re: Review Request 46739: using-aurora

2016-04-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46739/#review130783 --- Ship it! Master (534c469) is green with this patch. ./build-s

Review Request 46739: using-aurora

2016-04-27 Thread se choi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46739/ --- Review request for Aurora. Repository: aurora Description --- using-auro