Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146582 --- Ship it! This makes me a little nervous, but I don't think

Re: Review Request 51307: Catch IOError.

2016-08-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review146579 --- Master (c115ac6) is red with this patch.

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review118107 --- NEWS (line 6)

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146578 --- Ship it! Ship It! - Stephan Erb On Aug. 23, 2016, 10:45

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Stephan Erb
> On Aug. 23, 2016, 11:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/helper.py, lines 104-109 > > > > > > In the non-docker usecase, Thermos will by default run as uid 0 and > > setuid

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Zameer Manji
> On Aug. 23, 2016, 2:20 p.m., Stephan Erb wrote: > > src/main/python/apache/thermos/core/helper.py, lines 104-109 > > > > > > In the non-docker usecase, Thermos will by default run as uid 0 and > > setuid launched

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146574 --- src/main/python/apache/thermos/core/helper.py (lines 104 - 109)

Re: Review Request 51307: Catch IOError.

2016-08-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/#review146573 --- Ship it! Ship It! - Joshua Cohen On Aug. 23, 2016, 9:12

Re: Review Request 51307: Catch IOError.

2016-08-23 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/ --- (Updated Aug. 23, 2016, 9:12 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51348: Fix thermos killing heuristic to permit setuid(2).

2016-08-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51348/#review146571 --- Ship it! Master (c115ac6) is green with this patch.

Re: Review Request 51307: Catch IOError.

2016-08-23 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51307/ --- (Updated Aug. 23, 2016, 9:03 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51298: A few executor fixes for filesystem isolation:

2016-08-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51298/#review146568 --- Ship it! Master (c115ac6) is green with this patch.

Re: Review Request 51298: A few executor fixes for filesystem isolation:

2016-08-23 Thread Joshua Cohen
> On Aug. 22, 2016, 10:41 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 235 > > > > > > ... then this if would not be needed. One could potentially invoke the sandbox

Re: Review Request 51301: Use a fixed Debian mirror rather than relying on httpredir

2016-08-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51301/#review146536 --- Ship it! Ship It! - Joshua Cohen On Aug. 22, 2016, 9:05

Re: Review Request 51306: Only warn about terminated executors if their exit code is not 0.

2016-08-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51306/#review146495 --- Master (9b34a40) is green with this patch.

Re: Review Request 51306: Only warn about terminated executors if their exit code is not 0.

2016-08-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51306/#review146491 --- @ReviewBot retry - Stephan Erb On Aug. 23, 2016, 12:48 a.m.,