---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---
(Updated Oct. 5, 2016, 1:46 p.m.)
Review request for Aurora, Joshua Cohen and S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151499
---
Master (251ef5a) is red with this patch.
./build-support/jenkins
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---
(Updated Oct. 5, 2016, 2:04 p.m.)
Review request for Aurora, Joshua Cohen and S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/
---
(Updated Oct. 5, 2016, 2:10 p.m.)
Review request for Aurora, Joshua Cohen and S
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151502
---
The new code looks good to me. Thanks for your follow-up.
Please
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51893/#review151503
---
Master (251ef5a) is red with this patch.
./build-support/jenkins
If you don't think it's too much work, I think Stephan's idea is ideal.
The mutability of `reason` can result in bugs later.
On Wed, Oct 5, 2016 at 11:31 AM, Pradyumna Kaushik
wrote:
> Hi,
>
> Should I go ahead and work on Stephan's idea of returning a Map String> or should I hold it for now u
+1, I was nervous about the mutability, but I mistakenly thought that the
tasks groups being used was request scoped. That's not the case though, so
we should definitely not be mutating it.
On Wed, Oct 5, 2016 at 2:21 PM, Zameer Manji wrote:
> If you don't think it's too much work, I think Steph
That would be the perfect place for the test, thanks for adding it!
On Wed, Oct 5, 2016 at 2:43 PM, Pradyumna Kaushik
wrote:
> Zameer,
>
> Alright. I will start making changes to incorporate Stephan's idea.
> Also, I didn't seem to find an existing test for PendingTasks. Please let
> me know whe
Well, I guess to be specific, the perfect place would be:
src/test/java/org/apache/aurora/scheduler/http ;).
On Wed, Oct 5, 2016 at 2:46 PM, Joshua Cohen wrote:
> That would be the perfect place for the test, thanks for adding it!
>
> On Wed, Oct 5, 2016 at 2:43 PM, Pradyumna Kaushik > wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151539
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 4, 2016, 11:09 p.m.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52531/
---
(Updated Oct. 5, 2016, 12:54 p.m.)
Review request for Aurora and Zameer Manji.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52531/
---
(Updated Oct. 5, 2016, 12:55 p.m.)
Review request for Aurora and Zameer Manji.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52531/#review151542
---
Ship it!
LGTM,
I abused my RB admin powers here to clean up th
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151540
---
Kai,
I'm getting conflicts when commiting this.
Can you first re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/
---
(Updated Oct. 5, 2016, 9:49 p.m.)
Review request for Aurora, Joshua Cohen and Z
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/
---
(Updated Oct. 5, 2016, 10:01 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151573
---
Master (640f07b) is red with this patch.
./build-support/jenkins
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52577/
---
Review request for Aurora, Joshua Cohen and John Sirois.
Repository: aurora
D
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52577/#review151576
---
Ship it!
Ship It!
- John Sirois
On Oct. 5, 2016, 4:14 p.m.,
> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote:
> > Master (640f07b) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m# Create file stdout for capturing output.
> > We can't use StringIO mock[0m
> > [1m#
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52577/#review151581
---
Ship it!
Master (640f07b) is green with this patch.
./build-s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151582
---
@ReviewBot retry
- Zameer Manji
On Oct. 5, 2016, 3:01 p.m., Kai
> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote:
> > Master (640f07b) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m# Create file stdout for capturing output.
> > We can't use StringIO mock[0m
> > [1m#
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52577/
---
(Updated Oct. 6, 2016, 12:38 a.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52579/
---
Review request for Aurora, Joshua Cohen and John Sirois.
Repository: aurora-pac
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52453/#review151585
---
Master (640f07b) is green with this patch.
./build-support/jenki
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52579/#review151586
---
Ship it!
Ship It!
- John Sirois
On Oct. 5, 2016, 4:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52581/
---
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
D
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52581/#review151588
---
Ship it!
presumably a near-zero jitter would help as well:
htt
> On Oct. 5, 2016, 5:32 p.m., John Sirois wrote:
> > presumably a near-zero jitter would help as well:
> > https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40
Umm, nmm, pure shipit.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52581/#review151590
---
Ship it!
Master (640f07b) is green with this patch.
./build-s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52581/#review151608
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 5, 2016, 4:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/
---
Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151613
---
Master (e91130e) is red with this patch.
./build-support/jenkins
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/
---
(Updated Oct. 5, 2016, 6:23 p.m.)
Review request for Aurora, Joshua Cohen, Sant
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151618
---
Ship it!
Master (e91130e) is green with this patch.
./build-s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52588/#review151615
---
Overall looks good to me. One question: the executor currently onl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52591/
---
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Descripti
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52591/#review151621
---
Ship it!
Master (e91130e) is green with this patch.
./build-s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/
---
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Bugs: A
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151623
---
Master (e91130e) is red with this patch.
./build-support/jenkins
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151624
---
@ReviewBot retry
- John Sirois
On Oct. 5, 2016, 9:29 p.m., John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52591/#review151625
---
Ship it!
How did you determine this?
- Zameer Manji
On Oct.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151626
---
Ship it!
src/main/java/org/apache/aurora/scheduler/discovery/Z
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52594/#review151627
---
Master (e91130e) is red with this patch.
./build-support/jenkins
46 matches
Mail list logo