Re: Review Request 51893: Allow cookie based authentication

2016-10-05 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 5, 2016, 1:46 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 51893: Allow cookie based authentication

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151499 --- Master (251ef5a) is red with this patch. ./build-support/jenkins

Re: Review Request 51893: Allow cookie based authentication

2016-10-05 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 5, 2016, 2:04 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 51893: Allow cookie based authentication

2016-10-05 Thread Giulio Eulisse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 5, 2016, 2:10 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 51893: Allow cookie based authentication

2016-10-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151502 --- The new code looks good to me. Thanks for your follow-up. Please

Re: Review Request 51893: Allow cookie based authentication

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151503 --- Master (251ef5a) is red with this patch. ./build-support/jenkins

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-05 Thread Zameer Manji
If you don't think it's too much work, I think Stephan's idea is ideal. The mutability of `reason` can result in bugs later. On Wed, Oct 5, 2016 at 11:31 AM, Pradyumna Kaushik wrote: > Hi, > > Should I go ahead and work on Stephan's idea of returning a Map String> or should I hold it for now u

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-05 Thread Joshua Cohen
+1, I was nervous about the mutability, but I mistakenly thought that the tasks groups being used was request scoped. That's not the case though, so we should definitely not be mutating it. On Wed, Oct 5, 2016 at 2:21 PM, Zameer Manji wrote: > If you don't think it's too much work, I think Steph

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-05 Thread Joshua Cohen
That would be the perfect place for the test, thanks for adding it! On Wed, Oct 5, 2016 at 2:43 PM, Pradyumna Kaushik wrote: > Zameer, > > Alright. I will start making changes to incorporate Stephan's idea. > Also, I didn't seem to find an existing test for PendingTasks. Please let > me know whe

Re: Review Request 51993: Added the 'reason' to the /pendingTasks endpoint

2016-10-05 Thread Joshua Cohen
Well, I guess to be specific, the perfect place would be: src/test/java/org/apache/aurora/scheduler/http ;). On Wed, Oct 5, 2016 at 2:46 PM, Joshua Cohen wrote: > That would be the perfect place for the test, thanks for adding it! > > On Wed, Oct 5, 2016 at 2:43 PM, Pradyumna Kaushik > wrote: >

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151539 --- Ship it! Ship It! - Zameer Manji On Oct. 4, 2016, 11:09 p.m.

Re: Review Request 52531: AURORA-1712 Debian Jessie packagaes are embedding the mesos egg build for Ubuntu trusty

2016-10-05 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/ --- (Updated Oct. 5, 2016, 12:54 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 52531: Build Debian Jessie and Ubuntu Xenial specific mesos eggs

2016-10-05 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/ --- (Updated Oct. 5, 2016, 12:55 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 52531: Build Debian Jessie and Ubuntu Xenial specific mesos eggs

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52531/#review151542 --- Ship it! LGTM, I abused my RB admin powers here to clean up th

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151540 --- Kai, I'm getting conflicts when commiting this. Can you first re

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 5, 2016, 9:49 p.m.) Review request for Aurora, Joshua Cohen and Z

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/ --- (Updated Oct. 5, 2016, 10:01 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151573 --- Master (640f07b) is red with this patch. ./build-support/jenkins

Review Request 52577: Update to Gradle 3.1.

2016-10-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52577/ --- Review request for Aurora, Joshua Cohen and John Sirois. Repository: aurora D

Re: Review Request 52577: Update to Gradle 3.1.

2016-10-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52577/#review151576 --- Ship it! Ship It! - John Sirois On Oct. 5, 2016, 4:14 p.m.,

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Santhosh Kumar Shanmugham
> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote: > > Master (640f07b) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > #

Re: Review Request 52577: Update to Gradle 3.1.

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52577/#review151581 --- Ship it! Master (640f07b) is green with this patch. ./build-s

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151582 --- @ReviewBot retry - Zameer Manji On Oct. 5, 2016, 3:01 p.m., Kai

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Zameer Manji
> On Oct. 5, 2016, 3:13 p.m., Aurora ReviewBot wrote: > > Master (640f07b) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > #

Re: Review Request 52577: Update to Gradle 3.1.

2016-10-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52577/ --- (Updated Oct. 6, 2016, 12:38 a.m.) Review request for Aurora, Joshua Cohen and

Review Request 52579: Update Gradle to 3.1.

2016-10-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52579/ --- Review request for Aurora, Joshua Cohen and John Sirois. Repository: aurora-pac

Re: Review Request 52453: Add support for receiving min_consecutive_successes in health checker

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52453/#review151585 --- Master (640f07b) is green with this patch. ./build-support/jenki

Re: Review Request 52579: Update Gradle to 3.1.

2016-10-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52579/#review151586 --- Ship it! Ship It! - John Sirois On Oct. 5, 2016, 4:58 p.m.,

Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

2016-10-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52581/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora D

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

2016-10-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52581/#review151588 --- Ship it! presumably a near-zero jitter would help as well: htt

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

2016-10-05 Thread John Sirois
> On Oct. 5, 2016, 5:32 p.m., John Sirois wrote: > > presumably a near-zero jitter would help as well: > > https://github.com/apache/aurora/blob/783baaefb9a814ca01fad78181fe3df3de5b34af/src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java#L40 Umm, nmm, pure shipit. - John

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52581/#review151590 --- Ship it! Master (640f07b) is green with this patch. ./build-s

Re: Review Request 52581: Reduce offer_filter_duration to 0secs in Vagrant

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52581/#review151608 --- Ship it! Ship It! - Zameer Manji On Oct. 5, 2016, 4:23 p.m.,

Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151613 --- Master (e91130e) is red with this patch. ./build-support/jenkins

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/ --- (Updated Oct. 5, 2016, 6:23 p.m.) Review request for Aurora, Joshua Cohen, Sant

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151618 --- Ship it! Master (e91130e) is green with this patch. ./build-s

Re: Review Request 52588: Enable per task volume mounts via scheduler API

2016-10-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52588/#review151615 --- Overall looks good to me. One question: the executor currently onl

Review Request 52591: Remove untested classes that no longer exist.

2016-10-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52591/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 52591: Remove untested classes that no longer exist.

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52591/#review151621 --- Ship it! Master (e91130e) is green with this patch. ./build-s

Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Bugs: A

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151623 --- Master (e91130e) is red with this patch. ./build-support/jenkins

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151624 --- @ReviewBot retry - John Sirois On Oct. 5, 2016, 9:29 p.m., John

Re: Review Request 52591: Remove untested classes that no longer exist.

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52591/#review151625 --- Ship it! How did you determine this? - Zameer Manji On Oct.

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151626 --- Ship it! src/main/java/org/apache/aurora/scheduler/discovery/Z

Re: Review Request 52594: Move common/zookeeper to the main aurora project.

2016-10-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52594/#review151627 --- Master (e91130e) is red with this patch. ./build-support/jenkins