Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

> On Oct. 12, 2016, 1:49 a.m., David McLaughlin wrote: > > src/test/python/apache/aurora/executor/common/test_health_checker.py, line > > 500 > > > > > > Maybe I'm misunderstanding something - but this test suite se

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/#review152269 --- Ship it! Master (e9abb22) is green with this patch. ./build-s

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/ --- (Updated Oct. 12, 2016, 5:01 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/#review152252 --- src/test/python/apache/aurora/executor/common/test_health_checker

Re: Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/#review152248 --- Ship it! Master (e9abb22) is green with this patch. ./build-s

Review Request 52766: Fix a bug in insufficient successes during initial_interval_secs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52766/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1791

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152200 --- This is just a first pass, mostly style stuff. Need to circle back

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152203 --- 3rdparty/python/requirements.txt (line 25)

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52479/#review152179 --- docs/features/containers.md (line 77)

Re: Review Request 52669: Move the H2 database off heap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/#review152175 --- Master (e9abb22) is green with this patch. ./build-support/jenki

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your imp

Re: Review Request 52669: Move the H2 database off heap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52669/ --- (Updated Oct. 11, 2016, 8:17 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152169 --- Ship it! Ship It! - Zameer Manji On Oct. 11, 2016, 8:11 a.m.

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152156 --- Ship it! Ship It! - David McLaughlin On Oct. 11, 2016, 3:11

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > lines 246-248 > > > > > > I believe this is not true. Mesos is ignoring the

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 225-240 > > > > > > I am new to the Aurora DB layer, so question ahead: Why do we

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 7:40 a.m., Stephan Erb wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 225-240 > > > > > > I am new to the Aurora DB layer, so question ahead: Why do we

Re: Review Request 52588: Enable per task volume mounts via scheduler API

> On Oct. 8, 2016, 9:40 a.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 207 > > > > > > Thrift noob question: What is the semantic difference to an empty list? > > Do we the n

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152141 --- Ship it! Ship It! - John Sirois On Oct. 11, 2016, 9:11 a.m.,

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/ --- (Updated Oct. 11, 2016, 5:11 p.m.) Review request for Aurora, John Sirois and Z

Re: Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/#review152138 --- Ship it! Master (b272b88) is green with this patch. ./build-s

Re: Review Request 52669: Move the H2 database off heap.

> On Oct. 10, 2016, 12:39 a.m., John Sirois wrote: > > I don't think the micro-benchmarks show anything really. The error bars > > for the off-heap are generally larger than the values themselves! I imagine > > jmh is simply not the right tool for testing off-heap. > > I too though am interest

Re: Review Request 52669: Move the H2 database off heap.

> On Oct. 10, 2016, 8:51 p.m., Zameer Manji wrote: > > build.gradle, line 94 > > > > > > Can you please peel off the rev bumps on to their own patch? We should > > land them anyways. Done. I have filed https://revie

Review Request 52739: Update mybatis, h2, and jmh to their latest versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52739/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora D

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152131 --- Ship it! Master (b272b88) is green with this patch. ./build-s

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 11, 2016, 1:58 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 7, 2016, 3:47 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/common/cookie_auth_module.py, line 31 > > > > > > You should be able to drop the expanduser call now that you're using > > `DEFA