Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53590/#review156035 --- Master (e9a182f) is red with this patch. ./build-support/jenkins

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53590/ --- (Updated Nov. 15, 2016, 10:57 p.m.) Review request for Aurora, Joshua Cohen, St

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

> On Nov. 15, 2016, 1:10 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py, line 308 > > > > > > I think for clarity, debugging, etc the `NoopHealthChecker` should put > >

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

> On Nov. 15, 2016, 9:23 a.m., Joshua Cohen wrote: > > docs/features/job-updates.md, lines 52-53 > > > > > > I know this is not your doing, but since you're in here... this part is > > not really accurate. The update

Re: Review Request 53794: Update Curator to 2.11.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53794/#review155999 --- Ship it! Ship It! - John Sirois On Nov. 15, 2016, 2:22 p.m.,

Re: Review Request 53796: Bump guava dependency to 20.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53796/#review155989 --- Ship it! Master (e9a182f) is green with this patch. ./build-s

Re: Review Request 53796: Bump guava dependency to 20.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53796/ --- (Updated Nov. 15, 2016, 2:09 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 53796: Bump guava dependency to 20.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53796/#review155984 --- Master (e9a182f) is red with this patch. ./build-support/jenkins

Review Request 53796: Bump guava dependency to 20.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53796/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1821

Re: Review Request 53794: Update Curator to 2.11.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53794/#review155980 --- Ship it! Master (e9a182f) is green with this patch. ./build-s

Re: Review Request 53794: Update Curator to 2.11.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53794/#review155979 --- Ship it! Ship It! - Zameer Manji On Nov. 15, 2016, 1:22 p.m.

Review Request 53794: Update Curator to 2.11.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53794/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora D

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53590/#review155975 --- Overall LGTM. The test coverage is fantastic, it covered all of t

Re: Review Request 53687: track percentile values for timed sliding stats. AURORA-118

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53687/#review155959 --- +1 to Zameer's feedback as well, especially w.r.t. to tests. com

Re: Review Request 53590: Change job updates to rely on `health-checks` rather than on `watch_secs`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53590/#review155930 --- Ship it! Overall this looks good to me, thanks for iterating! M

Re: Review Request 53114: aurora job inspect should have a --write-json option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53114/#review155928 --- Ship it! Ship It! - Joshua Cohen On Nov. 11, 2016, 8:16 p.m.