Re: Review Request 54107: changes to intercept and time mybatis invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157530 --- Ship it! Master (8bcad84) is green with this patch. ./build-s

Re: Review Request 54107: changes to intercept and time mybatis invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/ --- (Updated Dec. 1, 2016, 1:53 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54107: changes to intercept and time mybatis invocations

> On Nov. 30, 2016, 6:05 p.m., Mehrdad Nurolahzade wrote: > > src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java, > > lines 152-156 > > > > > > Can't we verify the actual values h

Re: Review Request 54107: changes to intercept and time mybatis invocations

> On Nov. 30, 2016, 7:20 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java, > > line 108 > > > > > > Should we check length of the array?

Re: Review Request 54107: changes to intercept and time mybatis invocations

> On Nov. 30, 2016, 6:03 p.m., Mehrdad Nurolahzade wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java, > > line 59 > > > > > > There is also a `queryCursor()` call. Is there

Re: Review Request 54106: SlaUtil::percentile percentiles interpolation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54106/#review157487 --- Ship it! Ship It! - Joshua Cohen On Nov. 30, 2016, 6:28 a.m.

Re: Review Request 54107: changes to intercept and time mybatis invocations

> On Nov. 29, 2016, 4:18 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java, > > line 119 > > > > > > What is the performance impact of this interceptor?

Re: Review Request 54107: changes to intercept and time mybatis invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157434 --- src/test/java/org/apache/aurora/scheduler/storage/db/Instrumentin

Re: Review Request 54107: changes to intercept and time mybatis invocations

> On Nov. 28, 2016, 8:18 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java, > > line 119 > > > > > > What is the performance impact of this interceptor?

Re: Review Request 54107: changes to intercept and time mybatis invocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54107/#review157427 --- src/main/java/org/apache/aurora/scheduler/storage/db/Instrumentin

Re: Review Request 54107: changes to intercept and time mybatis invocations

> On Nov. 29, 2016, 4:18 a.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java, > > line 46 > > > > > > You shouldn't need to create a mock of `FakeClock