Re: Review Request 54520: Revert BUILD changes in 0c177058.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54520/ --- (Updated Dec. 7, 2016, 9:51 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 54520: Revert BUILD changes in 0c177058.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54520/#review158499 --- Ship it! Master (d05ea2b) is green with this patch.

Re: Review Request 54520: Revert BUILD changes in 0c177058.

> On Dec. 7, 2016, 9:41 p.m., John Sirois wrote: > > NB: When AuroraBot goes green I'll submit this TBR and file a follow-up > > issue in Aurora and a corresponding one in pants if needed, to restore the > > BUILD file changes for default targets and default globs. Also note this was a

Re: Review Request 54520: Revert BUILD changes in 0c177058.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54520/#review158497 --- Ship it! Ship It! - Joshua Cohen On Dec. 8, 2016, 4:39

Re: Review Request 54520: Revert BUILD changes in 0c177058.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54520/#review158496 --- NB: When AuroraBot goes green I'll submit this TBR and file a

Review Request 54520: Revert BUILD changes in 0c177058.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54520/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158490 --- Ship it! Ship It! - Joshua Cohen On Dec. 8, 2016, 12:15

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158456 --- Ship it! Master (91ddb07) is green with this patch.

Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/ --- (Updated Dec. 7, 2016, 4:15 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54459: Add message parameter to killTasks

> On Dec. 7, 2016, 10:09 a.m., David McLaughlin wrote: > > LGTM! > > > > Can you add an end to end test > > (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this? > > Cody Gibb wrote: > I noticed several of the existing e2e tests simply run a command, and > then implicitly

Re: Review Request 54459: Add message parameter to killTasks

> On Dec. 7, 2016, 6:09 p.m., David McLaughlin wrote: > > LGTM! > > > > Can you add an end to end test > > (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this? > > Cody Gibb wrote: > I noticed several of the existing e2e tests simply run a command, and > then implicitly

Re: Review Request 53836: Get pants using the same thrift binary as gradle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53836/#review158401 --- Ship it! Ship It! - Stephan Erb On Dec. 7, 2016, 1:30 a.m.,

Re: Review Request 54255: Update to Mesos 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review158355 --- Ship it! Can you add links to the Mesos release notes to the

Re: Review Request 53836: Get pants using the same thrift binary as gradle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53836/#review158399 --- Ship it! Ship It! - Joshua Cohen On Dec. 7, 2016, 12:30

Re: Review Request 54459: Add message parameter to killTasks

> On Dec. 7, 2016, 6:09 p.m., David McLaughlin wrote: > > LGTM! > > > > Can you add an end to end test > > (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this? I noticed several of the existing e2e tests simply run a command, and then implicitly assert that the command exits

Re: Review Request 54255: Update to Mesos 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review158370 --- RELEASE-NOTES.md (line 5)

Re: Review Request 54459: Add message parameter to killTasks

> On Dec. 7, 2016, 6:52 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/hooks/hooked_api.py, line 55 > > > > > > Let's not change the argument order on these methods? It's possible > > someone has

Re: Review Request 54255: Update to Mesos 1.1.0.

> On Dec. 7, 2016, 10:14 a.m., David McLaughlin wrote: > > Re: Testing Done. Can you verify this build of Aurora also runs on Mesos > > 1.0.0, even if it's just manual verification? I'm not sure the implication > > of using those constants - were they also in Mesos 1.0.0? The constatns were

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review158290 --- Thanks for the patch! Looks good to me overall, a few comments

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158363 ---

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158360 ---

Re: Review Request 54255: Update to Mesos 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review158359 --- Re: Testing Done. Can you verify this build of Aurora also runs

Re: Review Request 54459: Add message parameter to killTasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54459/#review158358 --- LGTM! Can you add an end to end test

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158357 --- Ship it! Master (91ddb07) is green with this patch.

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/ --- (Updated Dec. 7, 2016, 5:50 p.m.) Review request for Aurora, Mehrdad

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

> On Dec. 7, 2016, 8:42 a.m., Mehrdad Nurolahzade wrote: > > A general side note: SLA metrics calculation is currently the most > > expensive cpu-bound operation handled by the scheduler (it can take as much > > as 50% master cpu cycles). The calculators seem like a good fit for > >

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

> On Dec. 7, 2016, 4:42 p.m., Mehrdad Nurolahzade wrote: > > A general side note: SLA metrics calculation is currently the most > > expensive cpu-bound operation handled by the scheduler (it can take as much > > as 50% master cpu cycles). The calculators seem like a good fit for > >

Re: Review Request 54439: Add support for an mttu metric (median time to updated)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54439/#review158343 --- A general side note: SLA metrics calculation is currently the

Re: Review Request 54255: Update to Mesos 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review158327 --- Master (91ddb07) is green with this patch.

Re: Review Request 54255: Update to Mesos 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/ --- (Updated Dec. 7, 2016, 12:04 p.m.) Review request for Aurora, Joshua Cohen and