Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review165660 --- @ReviewBot retry - Santhosh Kumar Shanmugham On Feb. 14, 2017,

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
> On Feb. 14, 2017, 9:52 p.m., Aurora ReviewBot wrote: > > Master (9ea8979) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > FAILURES > >

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Santhosh Kumar Shanmugham
> On Feb. 14, 2017, 4:02 p.m., Mehrdad Nurolahzade wrote: > > Looking at it as is, I'm not sure if there is much value to be gained from > > pushing this down to `TaskStore`. > > Do you see any value in pursuing this idea any further? Or shall I restore > > it to previous state? > > Zameer

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review165649 --- Master (9ea8979) is red with this patch.

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Mehrdad Nurolahzade
> On Feb. 14, 2017, 4:02 p.m., Mehrdad Nurolahzade wrote: > > Looking at it as is, I'm not sure if there is much value to be gained from > > pushing this down to `TaskStore`. > > Do you see any value in pursuing this idea any further? Or shall I restore > > it to previous state? > > Zameer

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
> On Jan. 25, 2017, 11:21 a.m., Joshua Cohen wrote: > > build-support/packer/build.sh, line 20 > > > > > > This should probably be reverted? > > Santhosh Kumar Shanmugham wrote: > The current end-to-end test

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
> On Jan. 25, 2017, 11:21 a.m., Joshua Cohen wrote: > > src/main/python/apache/thermos/common/process_util.py, lines 25-37 > > > > > > Rather than continuing to manually construct a json representation of a > >

Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.

2017-02-14 Thread Santhosh Kumar Shanmugham
> On Jan. 25, 2017, 1:07 p.m., Stephan Erb wrote: > > The code change itself is fine. However, it's implications are a little bit > > horrible :) > > > > * We can only apply it once we have released 0.17 (build against Mesos 1.1) > > * Mesos broke +-1 version compatibility here, so users have

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review165623 --- Master (9ea8979) is red with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review165621 --- Master (9ea8979) is red with this patch.

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- (Updated Feb. 15, 2017, 1:48 a.m.) Review request for Aurora, Mehrdad

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2017-02-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- (Updated Feb. 14, 2017, 4:45 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2017-02-14 Thread Zameer Manji
> On Feb. 13, 2017, 9:28 p.m., Santhosh Kumar Shanmugham wrote: > > src/test/sh/org/apache/aurora/e2e/check-fs.sh, line 4 > > > > > > Verify `RO` mode? That feels more like testing what mesos does than what we do.

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2017-02-14 Thread Zameer Manji
> On Feb. 14, 2017, 3:56 p.m., Jason Lai wrote: > > src/main/python/apache/aurora/config/schema/base.py, line 144 > > > > > > Actually according to > >

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2017-02-14 Thread Zameer Manji
> On Feb. 14, 2017, 7:19 a.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 7 > > > > > > s/*/- > > > > Also I think, "Add support for per-task volume mounts for Mesos > > containers to the Aurora config

Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/#review165608 --- This patch does not apply cleanly against master (0e9c086), do

Re: Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review165607 --- This patch does not apply cleanly against master (0e9c086), do

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56575/#review165606 --- Ship it! Master (0e9c086) is green with this patch.

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56575/#review165605 --- Master (0e9c086) is red with this patch.

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Zameer Manji
> On Feb. 14, 2017, 4:02 p.m., Mehrdad Nurolahzade wrote: > > Looking at it as is, I'm not sure if there is much value to be gained from > > pushing this down to `TaskStore`. > > Do you see any value in pursuing this idea any further? Or shall I restore > > it to previous state? I think there

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56575/#review165599 --- Looking at it as is, I'm not sure if there is much value to be

Review Request 56691: [Patch 2/2] RFC for 2nd patch implements OfferReconciler for dynamic reservations proposal

2017-02-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/ --- Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.

Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts.

2017-02-14 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review165597 --- src/main/python/apache/aurora/config/schema/base.py (line 144)

Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations

2017-02-14 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56690/ --- Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.

Re: Review Request 56575: AURORA-1837 Improve task history pruning

2017-02-14 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56575/ --- (Updated Feb. 14, 2017, 3:38 p.m.) Review request for Aurora, David

Re: Review Request 56577: Add basic test scripts for RPM and DEB packages

2017-02-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56577/ --- (Updated Feb. 14, 2017, 11:33 p.m.) Review request for Aurora, John Sirois and

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-14 Thread David McLaughlin
> On Feb. 14, 2017, 7:34 p.m., Zameer Manji wrote: > > Linking this to a ticket would be nice for posterity. > > > > This seems like a useful admin tool. Thanks for adding it. I would probably > > use this in cases where some large jobs go flapping and populate the DB > > with thousands of

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/ --- (Updated Feb. 14, 2017, 9:11 p.m.) Review request for Aurora, Santhosh Kumar

Re: Review Request 56629: Expose task pruning endpoint in aurora_admin

2017-02-14 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56629/#review165562 --- Ship it! Linking this to a ticket would be nice for posterity.