Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180795 --- Master (243d6fa) is red with this patch. ./build-support/jenkins

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-17 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated July 18, 2017, 6:26 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-17 Thread Reza Motamedi
> On July 18, 2017, 12:46 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/thermos/monitoring/resource.py > > Line 54 (original), 53-60 (patched) > > > > > > Can you add some docstrings to these class

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-17 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180775 --- LGTM. Some minor comments. src/main/python/apache/thermos/monito

Re: Review Request 60714: aurora job restart request should be idempotent and retryable

2017-07-17 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60714/#review180756 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On July 15, 20

Re: Review Request 60748: Prototype using cgroups for monitoring Thermos Process resource consumption (CPU and memory)

2017-07-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60748/#review180698 --- I don't have the bandwidth to review this. Can you remove me? I su