Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Reza Motamedi
> On July 18, 2017, 7:15 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/thermos/monitoring/resource.py > > Lines 101 (patched) > > > > > > s/ProcessStatus/process_status/ Done. - Reza

Re: Review Request 60939: Upgrade Mesos version to 1.2.

2017-07-18 Thread Renan DelValle
> On July 18, 2017, 9:46 a.m., Stephan Erb wrote: > > test/deb/ubuntu-trusty/provision.sh > > Line 13 (original), 13 (patched) > > > > > > The same change needs to be applied for ubuntu-xenial as well. > > > >

Review Request 60947: Upgrade Mesos version to 1.2.

2017-07-18 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60947/ --- Review request for Aurora. Repository: aurora-packaging Description ---

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review180836 --- Master (243d6fa) is red with this patch.

Re: Review Request 60939: Upgrade Mesos version to 1.2.

2017-07-18 Thread Santhosh Kumar Shanmugham
> On July 18, 2017, 9:46 a.m., Stephan Erb wrote: > > test/deb/ubuntu-trusty/provision.sh > > Line 13 (original), 13 (patched) > > > > > > The same change needs to be applied for ubuntu-xenial as well. > > > >

Re: Review Request 60939: Upgrade Mesos version to 1.2.

2017-07-18 Thread Renan DelValle
> On July 18, 2017, 9:46 a.m., Stephan Erb wrote: > > test/deb/ubuntu-trusty/provision.sh > > Line 13 (original), 13 (patched) > > > > > > The same change needs to be applied for ubuntu-xenial as well. > > > >

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180825 --- Ship it! Master (243d6fa) is green with this patch.

Re: Review Request 60939: Upgrade Mesos version to 1.2.

2017-07-18 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60939/#review180824 --- Fix it, then Ship it! test/deb/ubuntu-trusty/provision.sh

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated July 18, 2017, 4:14 p.m.) Review request for Aurora, David

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review180811 --- Master (243d6fa) is red with this patch.

Review Request 60942: Remove task level resource fields from thrift interface and db

2017-07-18 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji. Bugs:

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180798 --- Ship it!

Review Request 60939: Upgrade Mesos version to 1.2.

2017-07-18 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60939/ --- Review request for Aurora and Stephan Erb. Repository: aurora-packaging

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review180795 --- Master (243d6fa) is red with this patch.

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/ --- (Updated July 18, 2017, 6:26 a.m.) Review request for Aurora, David

Re: Review Request 60376: Observer task page to load consumption info from history

2017-07-18 Thread Reza Motamedi
> On July 18, 2017, 12:46 a.m., Santhosh Kumar Shanmugham wrote: > > src/main/python/apache/thermos/monitoring/resource.py > > Line 54 (original), 53-60 (patched) > > > > > > Can you add some docstrings to these