Re: Review Request 62220: Add ca-certificates-java to ubuntu-trusty Dockerfile

2017-09-11 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62220/#review185125 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Sept. 11,

Re: Review Request 62220: Add ca-certificates-java to ubuntu-trusty Dockerfile

2017-09-11 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62220/#review185124 --- Ship it! This seems to be a solution to the intermitent errors

Re: Review Request 62135: HomePage implemented in Preact

2017-09-11 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62135/#review185096 --- ui/src/main/js/utils/__tests__/ShallowRender-test.js Lines 44

Re: Review Request 62135: HomePage implemented in Preact

2017-09-11 Thread David McLaughlin
> On Sept. 11, 2017, 4:18 p.m., Joshua Cohen wrote: > > lgtm overall. One question: do you think it's worthwhile to extract the > > shallow render to its own npm module that we depend on? Maybe that would > > make it possible/easier to have it upstreamed to preact? No idea if there > > are

Re: Review Request 62135: HomePage implemented in Preact

2017-09-11 Thread David McLaughlin
> On Sept. 11, 2017, 4:37 p.m., Kai Huang wrote: > > ui/src/main/js/index.js > > Line 5 (original), 5 (patched) > > > > > > Dumb question: I didn't see SchedulerClient defined in > > client/scheduler-client.js. Is it

Re: Review Request 62135: HomePage implemented in Preact

2017-09-11 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62135/#review185088 --- ui/src/main/js/components/Home.js Line 4 (original), 3-5

Re: Review Request 62135: HomePage implemented in Preact

2017-09-11 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62135/#review185062 --- ui/src/main/js/index.js Line 5 (original), 5 (patched)

Re: Review Request 62135: HomePage implemented in Preact

2017-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62135/#review185082 --- Ship it! lgtm overall. One question: do you think it's

Review Request 62220: Add ca-certificates-java to ubuntu-trusty Dockerfile

2017-09-11 Thread Nicolás Donatucci
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62220/ --- Review request for Aurora, Renan DelValle and Santhosh Kumar Shanmugham.