Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62423/#review185836 --- Master (96a5287) is green with this patch.

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Keisuke Nishimoto
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62423/#review185834 --- @ReviewBot retry - Keisuke Nishimoto On Sept. 20, 2017, 7:09

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62423/#review185822 --- Ship it! Ship It! - Bill Farner On Sept. 20, 2017, 12:09

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62423/#review185817 --- Master (96a5287) is red with this patch.

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Keisuke Nishimoto
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62423/ --- (Updated Sept. 20, 2017, 7:09 p.m.) Review request for Aurora. Bugs:

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Keisuke Nishimoto
> On Sept. 20, 2017, 4:55 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java > > Line 148 (original), 150 (patched) > > > > > > This seems to suggest that

Re: Review Request 61249: Cron timezone should be configurable per job

2017-09-20 Thread David McLaughlin
> On Sept. 20, 2017, 4:50 p.m., Bill Farner wrote: > > This seems to be of dubious value, and likely error-prone. There are two > > perspectives here - display, and time scheduling. Per-job configuration > > for TZ display seems unequivocally misguided, and better suited for API > >

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62423/#review185801 ---

Re: Review Request 61249: Cron timezone should be configurable per job

2017-09-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61249/#review185800 --- This seems to be of dubious value, and likely error-prone. There