Re: Review Request 62720: Implement Instance pages in React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62720/#review187221 --- Ship it! Master (0f1e684) is green with this patch. ./build-s

Re: Review Request 62720: Implement Instance pages in React

> On Oct. 5, 2017, 12:28 a.m., Kai Huang wrote: > > ui/src/main/js/components/StateMachine.js > > Lines 37 (patched) > > > > > > Add a key property here to suppress the warnings in the browser console? Done. - Davi

Re: Review Request 62720: Implement Instance pages in React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62720/ --- (Updated Oct. 5, 2017, 11:50 p.m.) Review request for Aurora, Kai Huang and San

Re: Review Request 62763: Create Update Page with React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62763/#review187215 --- This patch does not apply cleanly against master (0f1e684), do you

Re: Review Request 62763: Create Update Page with React

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62763/ --- (Updated Oct. 5, 2017, 10:44 p.m.) Review request for Aurora, Kai Huang and San

Re: Review Request 62692: Move job environment validation to the scheduler.

> On Oct. 3, 2017, 9:49 p.m., Stephan Erb wrote: > > Sorry for jumping in so late. > > > > We have had discussions and some work on this previously (see > > https://issues.apache.org/jira/browse/AURORA-319). I do therefore think it > > makes sense to change the scheduler side to a generic rege

Re: Review Request 62720: Implement Instance pages in React

> On Oct. 4, 2017, 9:42 p.m., Stephan Erb wrote: > > Regarding the question nodejs vs js thrift: nodejs supports both binary > > (good) and compact (better) thrift protocols. This should reduce scheduler > > and client side serialization overhead and lead to a slightly more snappy > > UI. > >