Re: Review Request 62720: Implement Instance pages in React

2017-10-09 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62720/#review187455 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 5,

Re: Review Request 62720: Implement Instance pages in React

2017-10-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62720/#review187437 --- ui/src/main/js/components/__tests__/InstanceHistoryItem-test.js

Re: Review Request 62720: Implement Instance pages in React

2017-10-09 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62720/#review187435 --- Ship it! LGTM, except missing some test cases for showing