---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68078/#review206535
---
Ship it!
Thanks!
- Stephan Erb
On Juli 27, 2018, 4:35 vorm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67967/#review206214
---
Ship it!
Ship It!
- Stephan Erb
On July 18, 2018, 10:27 p.m
> On July 18, 2018, 11:21 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py
> > Lines 159 (patched)
> > <https://reviews.apache.org/r/67967/diff/1/?file=2061542#file2061542line159>
> >
> > Should we use TASK_
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67696/#review206212
---
Ship it!
Ship It!
- Stephan Erb
On July 18, 2018, 12:15 a.m
> On July 17, 2018, 10:52 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
> > Lines 413-417 (patched)
> > <https://reviews.apache.org/r/67696/diff/9/?file=2059744#file2059744line414>
> >
> >
s part
of the latter category.
- Stephan Erb
On July 18, 2018, 10:27 p.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
from config A to B.
Could be that I am missing something entirely here. Would be great if you
could elaborate.
- Stephan Erb
On July 17, 2018, 8:21 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mai
ated e-mail. To reply, visit:
https://reviews.apache.org/r/67584/#review204855
-----------
On Juni 14, 2018, 12:08 vorm., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/
it now and follow
up with an additional performance patch set in the future (hopefully in a week
or two).
- Stephan Erb
On March 20, 2018, 11:41 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To rep
e.org/r/66139/#review199681
---
On March 20, 2018, 11:41 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
-support/jenkins/build.sh`
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0
(new vagrant box)
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0
(old vagrant box)
Thanks,
Stephan Erb
/aurora/e2e/test_end_to_end.sh` against Mesos 1.5.0
(new vagrant box)
Running as we speak:
* `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` against Mesos 1.4.0
(old vagrant box)
Thanks,
Stephan Erb
good catch, thanks!
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review204723
---
On June 13, 201
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67326/#review204633
---
Friendly ping :)
- Stephan Erb
On May 25, 2018, 4:58 p.m
src/main/python/apache/aurora/admin/host_maintenance.py
Line 173 (original), 173 (patched)
<https://reviews.apache.org/r/66716/#comment286244>
Should we already call out the old maintenance mechanism as deprecated in
the RELEASE-NOTES?
- Stephan Erb
filed
https://reviews.apache.org/r/67326/ as a replacement and will close this patch
now. Sorry for letting this one go stale.
- Stephan Erb
On April 9, 2018, 11:10 a.m., se choi wrote:
>
> ---
> This is an automatically generat
/apache/aurora/executor/BUILD
486230db34a22ea5dd0f68da911c0afb1afbcac0
Diff: https://reviews.apache.org/r/67326/diff/1/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Stephan Erb
I am happy about the refactoring overall. It is therefore fine with me to
let this one slide.
- Stephan Erb
On May 11, 2018, 5:18 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67141/#review203528
---
Ship it!
Ship It!
- Stephan Erb
On May 17, 2018, 4:07 a.m
e via pystachio,
> just wanted to settle on the Thrift Schema before making those changes.
>
> Santhosh Kumar Shanmugham wrote:
> Ack.
The changes in `api.thrift` look good to me!
- Stephan
-----------
This is an autom
<https://reviews.apache.org/r/66192/#comment285402>
With the current backfill mechanism, this will break for tasks read from
storage.
- Stephan Erb
On May 15, 2018, 4:19 a.m., Renan DelValle wrote:
>
> ---
> This is an automatic
> On May 16, 2018, 10:22 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java
> > Lines 257-258 (patched)
> > <https://reviews.apache.org/r/67141/diff/1/?file=2023580#file2023580line257>
> >
> > If
ater.
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java
Lines 384 (patched)
<https://reviews.apache.org/r/66716/#comment285387>
isProduction is deprecated. You will need to check the appropriate tier
config here.
- Stephan Erb
On May 15, 20
e can then simply enable the feature toggle by default after next release.
@Jordan Ly, would this address your backwards incompatibility concerns?
- Stephan Erb
On May 15, 2018, 11:15 p.m., Santhosh Kumar Shanmugham wrote:
>
>
ed e-mail. To reply, visit:
https://reviews.apache.org/r/66186/#review200944
---
On April 12, 2018, 12:13 a.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66573/#review200974
---
Ship it!
Ship It!
- Stephan Erb
On April 12, 2018, 3:05 a.m
/
Testing (updated)
---
Successfully verified in vagrant that CPU and memory are reported as expected.
Thanks,
Stephan Erb
> On April 10, 2018, 11:37 a.m., Stephan Erb wrote:
> > Thanks for the patch! We also have another virtulenv version specified
> > here:
> > https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17.
> > Do you think you can bump that one
/aurora/scheduler/preemptor/Preemptor.java
Line 86 (original), 88 (patched)
<https://reviews.apache.org/r/66536/#comment281825>
Witht the removal of the iterator this is a bit outdated.
- Stephan Erb
On April 11, 2018, 12:47 a.m., Jordan Ly
specified here:
https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. Do
you think you can bump that one as well?
- Stephan Erb
On April 9, 2018, 11:10 a.m., se choi wrote:
>
> ---
> This is an automatically ge
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66491/#review200700
---
Ship it!
Ship It!
- Stephan Erb
On April 7, 2018, 2:18 vorm
-of-live is near
https://www.ubuntu.com/info/release-end-of-life, so we could ask on the
mailinglist who is using it and stop building packages for it after 0.20.
- Stephan Erb
On April 6, 2018, 1:58 a.m., Renan DelValle wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66186/#review200265
---
@ReviewBot retry
- Stephan Erb
On March 21, 2018, 12:15 a.m
!
- Stephan Erb
On March 26, 2018, 4:59 a.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66103/#review199934
---
Ship it!
Ship It!
- Stephan Erb
On March 23, 2018, 6:39 p.m
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66192/
> ---
>
> (Updated March 21, 2018, 3:10 a.m.)
>
>
> Review
> On March 22, 2018, 11:31 p.m., Stephan Erb wrote:
> > src/test/python/apache/thermos/monitoring/BUILD
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/66103/diff/7/?file=1985807#file1985807line21>
> >
> > Requests has a few dependencies
er to ensure pants pulls in the correct versions.
- Stephan Erb
On March 22, 2018, 10:52 p.m., Reza Motamedi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66190/#review199774
---
Ship it!
Ship It!
- Stephan Erb
On March 21, 2018, 9:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66199/#review199771
---
Ship it!
Ship It!
- Stephan Erb
On March 21, 2018, 10:38
/test_process_collector_psutil.py
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/66186/#comment279928>
`process_iter` used to be an implementation detail of `Process.children()`
but got removed in https://github.com/giampaolo/psutil/pull/1185/files
- Stephan Erb
On March 21, 2018, 12:
to double check this on a real running observer
Thanks,
Stephan Erb
] TaskObserver: finished
checkpoint refresh in 0.48s
D0320 22:18:59.031919 16250 task_observer.py:142] TaskObserver: finished
checkpoint refresh in 0.49s
D0320 22:19:04.512358 16250 task_observer.py:142] TaskObserver: finished
checkpoint refresh in 0.48s
Thanks,
Stephan Erb
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66139/#review199564
-----------
On March 20, 2018, 12:22 a.m., Stephan Erb wrote:
>
> ---
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66139/#review199490
---
@ReviewBot retry
- Stephan Erb
On March 19, 2018, 5:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66136/#review199421
---
@ReviewBot retry
- Stephan Erb
On March 19, 2018, 3:55 p.m
The regular 2-3 second freezes when navigating the Thermos UI are now almost
gone for me.
Thanks,
Stephan Erb
fa4f0fb7452bf8b85f9f3fa27283f54d7c0fe4f2
Diff: https://reviews.apache.org/r/66136/diff/1/
Testing
---
Manually verified that the observer debug logs still contain useful output.
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65769/#review199394
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 23, 2018, 7:04 p.m
> On March 16, 2018, 7:02 p.m., Stephan Erb wrote:
> > Is this RecoveryTool just a prototype or used for real? If it is the
> > preferred backup way now, we have to update
> > https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md.
>
> Jor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66074/#review199334
---
Ship it!
Ship It!
- Stephan Erb
On March 14, 2018, 11:07
? If it is the preferred
backup way now, we have to update
https://github.com/apache/aurora/blob/master/docs/operations/backup-restore.md.
- Stephan Erb
On Feb. 23, 2018, 7:04 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically ge
.
- Stephan Erb
On Nov. 8, 2017, 11:32 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
On March 7, 2018, 6:50 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65941/
> ---
>
> (Updated March 7, 2018, 6:50 a.m.)
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65873/#review198508
---
Ship it!
Ship It!
- Stephan Erb
On März 2, 2018, 1:14 vorm
d the files anywhere, not
even on Jenkins.
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65598/#review197571
---------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65650/#review197546
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 14, 2018, 9:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197520
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 14, 2018, 6:05 a.m
t read the files
anywhere, not even on Jenkins.
- Stephan Erb
On Feb. 11, 2018, 11:44 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
repeated git clean -xfd && ./build-support/jenkins/build.sh
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196700
---
@ReviewBot retry
- Stephan Erb
On Feb. 2, 2018, 8:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196701
---
@ReviewBot retry
- Stephan Erb
On Feb. 2, 2018, 8:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65476/#review196699
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 2, 2018, 8:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65477/#review196698
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 2, 2018, 8:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65303/#review196583
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 31, 2018, 7:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196563
---
@ReviewBot retry
- Stephan Erb
On Jan. 31, 2018, 11:57 a.m
(original), 49-50 (patched)
<https://reviews.apache.org/r/65434/#comment276262>
Note to reviewers: `config.raw().has_announce()` is already checked above
so I could simplify the condition here. This is just a refactoring and
independent of the behaviour change of this patch.
- Steph
111518739a7d353433ad59b7e48c84c2dbb546db
Diff: https://reviews.apache.org/r/65433/diff/1/
Testing
---
Manually verified that the UI is still working
Thanks,
Stephan Erb
where launching would fail, but we
would still like the task to live on.
- Stephan Erb
On Jan. 25, 2018, 9:43 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/MemTaskStore.java
Line 234 (original), 235 (patched)
<https://reviews.apache.org/r/65303/#comment275620>
Have you considered passing in the predicate filter in here? For index
scans this should help to eliminate a large amount of allocations.
- Stephan Erb
On Jan. 24, 2018, 1:32 a.m., Bill
> On Dec. 12, 2017, 11:15 p.m., Stephan Erb wrote:
> > The code looks fine and reasonable to me. I would still recommend proper
> > scale testing though.
> >
> > At my company, we operate at a small scale and the Mesos replicated log
> > works still
> On Jan. 19, 2018, 8:27 p.m., Stephan Erb wrote:
> > The patch itself looks fine! However, I have difficulties assesing it
> > properly as I am missing a bit of context. What is the main customization
> > that you aim to implement using the new interface?
> >
> On Jan. 19, 2018, 8:27 p.m., Stephan Erb wrote:
> > The patch itself looks fine! However, I have difficulties assesing it
> > properly as I am missing a bit of context. What is the main customization
> > that you aim to implement using the new interface?
> >
-snapshot
./test/test-artifact.sh test/rpm/centos-7
/repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64
Thanks,
Stephan Erb
257#file1927257line41>
> >
> > Also here.
done
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64825/#review194721
----------
, visit:
https://reviews.apache.org/r/64824/#review194522
-----------
On Dec. 23, 2017, 3:45 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65068/#review195135
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 10, 2018, 11:44 a.m
: https://reviews.apache.org/r/64825/diff/1/
Testing
---
./build-artifact.sh builder/rpm/centos-7/ snapshot.tar.gz 0.20.0-snapshot
./test/test-artifact.sh test/rpm/centos-7
/repo/artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64
Thanks,
Stephan Erb
3f97a73249cd6601465be8a0031067715290cb9c
specs/debian/aurora-scheduler.upstart
3c3206887070f72061095b342bfbf8b535c82cff
Diff: https://reviews.apache.org/r/64824/diff/1/
Testing
---
Thanks,
Stephan Erb
specs/debian/aurora-scheduler.upstart
3c3206887070f72061095b342bfbf8b535c82cff
Diff: https://reviews.apache.org/r/64824/diff/1/
Testing
---
Thanks,
Stephan Erb
. Feel free to
ship without me though.
- Stephan Erb
On Dec. 12, 2017, 2:35 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
. Feel free to
ship without me though.
- Stephan Erb
On Dec. 11, 2017, 12:13 p.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
that still passes the
tests, I tried to focus on the bigger picture. This looks OK to me.
- Stephan Erb
On Dec. 12, 2017, 6:46 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
Dec. 9, 2017, 5:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64290/
> ---
>
> (Updated Dec. 9, 2017, 5:32 p.m.)
>
>
> R
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64341/#review193618
---
@ReviewBot retry
- Stephan Erb
On Dec. 11, 2017, 12:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64290/#review193617
---
@ReviewBot retry
- Stephan Erb
On Dec. 9, 2017, 5:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193616
---
Ship it!
Ship It!
- Stephan Erb
On Dec. 12, 2017, 8:15 p.m
a DBMS: How many entries
would you expect in this table?
(From a quick uninformed back-of-the-envelope calculation I would expect
roughtly 5 million entries for a Twitter style cluster, which would be pretty
reasonable)
- Stephan Erb
On Dec. 7, 2017, 7:27 p.m., Bill
:)
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193608
-------
On Dec. 12, 2017, 8:15 p.m., Jordan Ly wrote:
>
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193607
---
@ReviewBot retry
- Stephan Erb
On Dec. 12, 2017, 8:15 p.m
n Dec. 12, 2017, 8:15 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64523/
> ---
>
> (Updated Dec. 12, 2017, 8:15 p.m.)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64523/#review193590
---
@ReviewBot retry
- Stephan Erb
On Dec. 12, 2017, 3:29 a.m
> why it differs, but it does pass consistently for me.
Jordan, will you update your PR? Or do you plan to file one, Bill?
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64534/#review193530
---
@ReviewBot retry
- Stephan Erb
On Dec. 12, 2017, 12:38 p.m
for being
sloppy here.
I have pushed
https://github.com/apache/aurora/commit/301f066369a9ef7262c1702c77004d12bc8eac00
unbreak the build.
- Stephan Erb
On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64534/#review193527
---
@ReviewBot retry
- Stephan Erb
On Dec. 12, 2017, 12:38 p.m
0663a9ad8ae194b63ce6d77dabfe65564e2d26dd
src/test/python/apache/thermos/core/test_process.py
6cb9176e14eccbe7ed10501199a34e5e67d6fe44
Diff: https://reviews.apache.org/r/64534/diff/1/
Testing
---
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193522
---
@ReviewBot retry
- Stephan Erb
On Dec. 12, 2017, 10:05 a.m
quot;\r" "\n" | tee build_outpu
Thanks,
Stephan Erb
1 - 100 of 892 matches
Mail list logo
