Review Request 62830: Switch release checksum to sha512

2017-10-08 Thread Stephan Erb
uild-support/release/verify-release-candidate 3b9beeea981f04253f147eea4262ce809c58bac3 Diff: https://reviews.apache.org/r/62830/diff/1/ Testing --- Thanks, Stephan Erb

Review Request 62829: Fix documentation of pystachio Volume struct

2017-10-08 Thread Stephan Erb
, Stephan Erb

Re: Review Request 62720: Implement Instance pages in React

2017-10-04 Thread Stephan Erb
> On Oct. 4, 2017, 11:42 p.m., Stephan Erb wrote: > > Regarding the question nodejs vs js thrift: nodejs supports both binary > > (good) and compact (better) thrift protocols. This should reduce scheduler > > and client side serialization overhead and lead to a slightl

Re: Review Request 62623: Use a simpler command line argument system

2017-10-04 Thread Stephan Erb
> On Oct. 4, 2017, 12:29 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > > Line 106 (original), 110 (patched) > > <https://reviews.apache.org/r/62623/diff/4/?file=1841457#file1841457line119> >

Re: Review Request 62720: Implement Instance pages in React

2017-10-04 Thread Stephan Erb
binary (good) and compact (better) thrift protocols. This should reduce scheduler and client side serialization overhead and lead to a slightly more snappy UI. - Stephan Erb On Oct. 4, 2017, 7:43 a.m., David McLaughlin wrote

Re: Review Request 62720: Implement Instance pages in React

2017-10-04 Thread Stephan Erb
Is the array index safe here? If we need the guard for `task.taskEvents.length` in `getLastEventTime` shouldn't we also require it here? - Stephan Erb On Oct. 4, 2017, 7:43 a.m., David McLaughlin wrote: > > --- > This

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-10-03 Thread Stephan Erb
> On Sept. 27, 2017, 1:53 a.m., Bill Farner wrote: > > ``` > > /bin/sh: cmake: command not found > > ``` > > > > But now i need to install cmake, so i'm not sure this pays off. > > Bill Farner wrote: > (this = the switch to cmake) > >

Re: Review Request 62652: Remove legacy commons ZK code

2017-10-03 Thread Stephan Erb
gt; > We have not run into this issuse on our cluster where we reverted to the > commons code. > > Stephan Erb wrote: > With these two patches merged I belive Curator should be working fine now: > > * Only failover on ZK session timeout (rather than on con

Re: Review Request 62623: Use a simpler command line argument system

2017-10-03 Thread Stephan Erb
h this patch. Just to be extra sure we don't have any other problems like these. - Stephan Erb On Sept. 30, 2017, 4:07 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-03 Thread Stephan Erb
eply, visit: https://reviews.apache.org/r/62692/#review186700 --- On Oct. 1, 2017, 5:36 p.m., Mauricio Garavaglia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62692/ >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-03 Thread Stephan Erb
merge https://reviews.apache.org/r/45521/ once this RB here has been merged and released. - Stephan Erb On Oct. 1, 2017, 5:36 p.m., Mauricio Garavaglia wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

2017-10-03 Thread Stephan Erb
ordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62700/ > --- > > (Updated Oct. 3, 2017, 7:01 p.

Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client

2017-10-03 Thread Stephan Erb
proper integration test. - Stephan Erb On Oct. 3, 2017, 7:01 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62652: Remove legacy commons ZK code

2017-09-28 Thread Stephan Erb
> On Sept. 28, 2017, 5:22 a.m., David McLaughlin wrote: > > -1. > > > > Please see here for details on the current status of curator in production: > > https://issues.apache.org/jira/browse/AURORA-1840 > > Bill Farner wrote: > Aha, there was no trace of this in the code, thanks for the po

Re: Review Request 62607: Replace Preact and custom testing with React + Enzyme

2017-09-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62607/#review186498 --- @ReviewBot retry - Stephan Erb On Sept. 27, 2017, 11:31 p.m

Re: Review Request 62626: Added additional stop() to prevent errors in run() to stop shutdown in SchedulerMain

2017-09-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62626/#review186497 --- Ship it! Ship It! - Stephan Erb On Sept. 27, 2017, 10:25

Re: Review Request 62601: Remove the rewriteConfigs thrift method

2017-09-27 Thread Stephan Erb
send a mail to the dev mailing list though that we are dropping the feature without a deprecation cycle. If somebody really cares strongly (which I doubt) he/she has a chance to let us know. - Stephan Erb On Sept. 27, 2017, 2:20 a.m., Bill Farner wrote

Re: Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-27 Thread Stephan Erb
ttps://reviews.apache.org/r/62590/#review186342 ----------- On Sept. 26, 2017, 10:50 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 62621: Allow transitions from any state to STOPPED in CallOrderEnforcingStorage

2017-09-27 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62621/#review186464 --- Ship it! Ship It! - Stephan Erb On Sept. 27, 2017, 9:27 p.m

Re: Review Request 62397: Replica Hot Standby

2017-09-27 Thread Stephan Erb
f 1.0 Mesos promised that it should be possible to leave out intermediate versions but we should verify to be sure. - Stephan Erb On Sept. 19, 2017, 7:32 a.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. T

Review Request 62590: WIP: Update to Thrift 0.10.0

2017-09-26 Thread Stephan Erb
/apache/aurora/scheduler/storage/mem/Util.java c28fb65010af5e3db925487929d4e0e12b4101a4 Diff: https://reviews.apache.org/r/62590/diff/1/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Stephan Erb

Re: Review Request 62558: Restore scheduler benchmarks to working order

2017-09-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62558/#review186268 --- Ship it! Ship It! - Stephan Erb On Sept. 26, 2017, 8:04 a.m

Re: Review Request 62558: Restore scheduler benchmarks to working order

2017-09-26 Thread Stephan Erb
having the benchmarks working again comes in handy here. - Stephan Erb On Sept. 26, 2017, 8:04 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62524: Build with gradle 4.2

2017-09-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62524/#review186075 --- Ship it! Ship It! - Stephan Erb On Sept. 23, 2017, 6:12 p.m

Re: Review Request 62517: Update to gradle 4.2

2017-09-22 Thread Stephan Erb
nightly packaging build so we have to fix it in a subsequent patch. - Stephan Erb On Sept. 23, 2017, 12:29 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62423: Improve in-process test ZooKeeper support

2017-09-21 Thread Stephan Erb
commit this atm though. Bill, could you handle that? - Stephan Erb On Sept. 20, 2017, 9:09 p.m., Keisuke Nishimoto wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62220: Add ca-certificates-java to ubuntu-trusty Dockerfile

2017-09-19 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62220/#review185739 --- Ship it! Thanks! - Stephan Erb On Sept. 11, 2017, 4:59 p.m

Re: Review Request 62347: Add Houghton Mifflin Harcourt to adopters list

2017-09-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62347/#review185527 --- Ship it! Great! Thanks for letting us know. - Stephan Erb

Re: Review Request 61249: Cron timezone should be configurable per job

2017-08-30 Thread Stephan Erb
imezone must be populated since they are > all validated via ConfigurationManager. > > Please correct me if i was wrong > > David McLaughlin wrote: > Ah, you're right. I thought validateAndPopulate was only called when the > config was sent to the API. But

Re: Review Request 61918: Fix concurrency issues around banned offers in HostOffers

2017-08-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61918/#review184212 --- Ship it! Thanks for the fix. LGTM! - Stephan Erb On Aug. 30

Re: Review Request 61804: Fix race condition where rescinds are received but not processed before offer is accepted

2017-08-23 Thread Stephan Erb
places as well. - Stephan Erb On Aug. 22, 2017, 11:54 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-08-09 Thread Stephan Erb
es ago). - Stephan Erb On Aug. 7, 2017, 6:53 p.m., Nicolás Donatucci wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-08-07 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60942/#review182277 --- Ship it! Ship It! - Stephan Erb On Aug. 7, 2017, 4:25 p.m

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-08-06 Thread Stephan Erb
ances())] instances = (None if context.options.instance_spec.instance == ALL_INSTANCES else context.options.instance_spec.instance) formatter = DiffFormatter(context, config, cluster, role, env, name) ``` What do you t

Re: Review Request 60437: Add timing metrics in MesosCallbackHandler for backward compatibility.

2017-08-04 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60437/#review182215 --- Ship it! Ship It! - Stephan Erb On June 26, 2017, 7:37 p.m

Re: Review Request 60942: Remove task level resource fields from thrift interface and db

2017-08-03 Thread Stephan Erb
is why we should never wonder why the DBTaskStore is so slow :-D (this has nothing to do with the patch) - Stephan Erb On July 18, 2017, 4:43 p.m., Nicolás Donatucci wrote: > > --- > This is an automatically generated

Re: Review Request 61249: Cron timezone should be configurable per job

2017-08-03 Thread Stephan Erb
t more obvious that this has only a used for cron jobs. src/main/python/apache/aurora/config/schema/base.py Lines 170 (patched) <https://reviews.apache.org/r/61249/#comment258018> This is also a good candiate for renaming for consistency: `cron_time_zone` - Stephan Erb On July 31,

Re: Review Request 61249: Cron timezone should be configurable per job

2017-08-03 Thread Stephan Erb
--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61249/ > --- > > (Updated July 31, 2017, 12:29 p.m.) > > > Review request for Aurora, Joshua Cohen and St

Re: Review Request 61249: Cron timezone should be configurable per job

2017-08-03 Thread Stephan Erb
--- On July 31, 2017, 12:29 p.m., Jing Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61249/ > --- > > (Updated July 31, 2017, 12:29 p.m.) >

Re: Review Request 61249: Cron timezone should be configurable per job

2017-08-03 Thread Stephan Erb
-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61249/ > --- > > (Updated July 31, 2017, 12:29 p.m.) > > > Review request for

Re: Review Request 61402: FIX observer themos extra arguments usage

2017-08-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61402/#review182106 --- Ship it! Ship It! - Stephan Erb On Aug. 3, 2017, 2:51 p.m

Re: Review Request 61016: lock psutil's oneshot

2017-07-21 Thread Stephan Erb
discussed offline before, I am ok with removing `oneshot` for now as it does not seem to work reliable. - Stephan Erb On July 21, 2017, 11:12 p.m., Reza Motamedi wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 61016: lock psutil's oneshot

2017-07-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61016/#review181165 --- @ReviewBot retry - Stephan Erb On July 21, 2017, 11:12 p.m

Re: Review Request 60947: Upgrade Mesos version to 1.2.

2017-07-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60947/#review181147 --- Ship it! Ship It! - Stephan Erb On July 18, 2017, 8:09 p.m

Re: Review Request 60787: Added PayPal to the list of companies using Aurora

2017-07-20 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60787/#review181079 --- Ship it! Ship It! - Stephan Erb On July 12, 2017, 3:36 a.m

Re: Review Request 60939: Upgrade Mesos version to 1.2.

2017-07-18 Thread Stephan Erb
Line 13 (original), 13 (patched) <https://reviews.apache.org/r/60939/#comment256103> The same change needs to be applied for ubuntu-xenial as well. Do we have a bug in our tool chain? I am wondering this would have exploded when trying to build the packages for it. - Stephan Er

Re: Review Request 60376: Observer task page to load consumption info from history

2017-06-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60376/#review179411 --- Ship it! Ship It! - Stephan Erb On June 29, 2017, 8:32 p.m

Re: Review Request 60376: Observer task page to load consumption info from history

2017-06-27 Thread Stephan Erb
results after 10-15 minutes feel free to give up. There might be some further interdependency that I am not spotting right now) - Stephan Erb On June 22, 2017, 10:18 p.m., Reza Motamedi wrote: > > --- > This is an automa

Re: Review Request 60376: Observer task page to load consumption info from history

2017-06-26 Thread Stephan Erb
metrics all the time and eliminate the regular collection instead. This would result in slower UI rending but should yield more consistent latency. - Stephan Erb On June 22, 2017, 10:18 p.m., Reza Motamedi wrote: > > --- > T

Re: Review Request 60306: Ensure Thermos is not overloaded by an unlimited number of lost processes

2017-06-21 Thread Stephan Erb
massive_cpu_spike.png https://reviews.apache.org/media/uploaded/files/2017/06/21/57cbc6e6-2cd5-4e92-995a-e0e05a57c359__massive_cpu_spike.png massive_restart_count.png https://reviews.apache.org/media/uploaded/files/2017/06/21/c4cbab7c-1a48-4cf0-92ab-5fa9444813c7__massive_restart_count.png Thanks, Stephan Erb

Re: Review Request 60306: Ensure Thermos is not overloaded by an unlimited number of lost processes

2017-06-21 Thread Stephan Erb
://reviews.apache.org/media/uploaded/files/2017/06/21/57cbc6e6-2cd5-4e92-995a-e0e05a57c359__massive_cpu_spike.png massive_restart_count.png https://reviews.apache.org/media/uploaded/files/2017/06/21/c4cbab7c-1a48-4cf0-92ab-5fa9444813c7__massive_restart_count.png Thanks, Stephan Erb

Review Request 60306: Ensure Thermos is not overloaded by an unlimited number of lost processes

2017-06-21 Thread Stephan Erb
Diff: https://reviews.apache.org/r/60306/diff/1/ Testing --- ./pants test.pytest src/test/python:: Thanks, Stephan Erb

Re: Review Request 59883: Support specifying a custom ShiroCredentialsMatcher

2017-06-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59883/#review178552 --- Ship it! Ship It! - Stephan Erb On June 20, 2017, 10:47 p.m

Re: Review Request 59883: Support specifying a custom ShiroCredentialsMatcher

2017-06-20 Thread Stephan Erb
. - Stephan Erb On June 20, 2017, 10:47 p.m., Ruben D. Porras wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60208: Add Thrift schema for POSIX RLimit support for Mesos containers

2017-06-20 Thread Stephan Erb
, and maybe even add them to the client DSL (optional). Do you plan to cover those in separate patch? - Stephan Erb On June 19, 2017, 11:04 p.m., Jason Lai wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 59703: Use async HTTP for Web Hooks.

2017-06-20 Thread Stephan Erb
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59703/ > --- > > (Updated June 1, 2017, 8:33 a.m.) > > > Review request for Aurora, Santhosh Kumar Shanmugham,

Re: Review Request 60173: Allow custom Thrift method interceptors to be injected via Guice modules

2017-06-20 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60173/#review178416 --- Ship it! Ship It! - Stephan Erb On June 19, 2017, 8:03 p.m

Review Request 60133: Update h2 to 1.4.196

2017-06-15 Thread Stephan Erb
: https://reviews.apache.org/r/60133/diff/1/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 59962: Prepare release notes for 0.18.0

2017-06-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59962/#review177582 --- Ship it! Ship It! - Stephan Erb On June 10, 2017, 1:44 a.m

Re: Review Request 59966: Set GPG_TTY if not set in the release scripts.

2017-06-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59966/#review177581 --- Ship it! Ship It! - Stephan Erb On June 10, 2017, 4:23 a.m

Re: Review Request 57524: Support setting the rootfs on Mesos Containers.

2017-06-08 Thread Stephan Erb
/c85bffdd6f68312261697eee868d57069adda434/src/main/python/apache/aurora/executor/common/sandbox.py#L302 - Stephan Erb On March 13, 2017, 5:36 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 59495: Adding gpg key for santhk

2017-06-08 Thread Stephan Erb
? - Stephan Erb On May 23, 2017, 11:09 p.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59703: Use async HTTP for Web Hooks.

2017-06-07 Thread Stephan Erb
> On June 6, 2017, 12:14 a.m., Stephan Erb wrote: > > LGTM. > > > > Using an async handler should effectively unblock the event bus. If I > > understand the context correctly, we will now use an unbounded queue within > > netty that will be served by one re

Re: Review Request 59853: Process rescinds in the same thread pool as offers.

2017-06-06 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59853/#review177099 --- Ship it! Ship It! - Stephan Erb On June 6, 2017, 10:56 p.m

Re: Review Request 59733: Adding Configurable Wait Period for Graceful Shutdowns

2017-06-06 Thread Stephan Erb
che.org/r/59733/#comment250638> Please mention the HttpLifecycleConfig here explicitly. A casual reader could think of SIGKILL and SIGTERM when hearing forceful and graceful termination. - Stephan Erb On June 6, 2017, 10:02 p.m

Re: Review Request 59703: Use async HTTP for Web Hooks.

2017-06-06 Thread Stephan Erb
> On June 6, 2017, 12:14 a.m., Stephan Erb wrote: > > LGTM. > > > > Using an async handler should effectively unblock the event bus. If I > > understand the context correctly, we will now use an unbounded queue within > > netty that will be served by one re

Re: Review Request 59733: Adding Configurable Wait Period for Graceful Shutdowns

2017-06-06 Thread Stephan Erb
delay. - Stephan Erb On June 2, 2017, 1:48 a.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59703: Use async HTTP for Web Hooks.

2017-06-05 Thread Stephan Erb
unblock the event bus. If I understand the context correctly, we will now use an unbounded queue within netty that will be served by one request handling thread. So we will just have one outgoing request at the time, correct? - Stephan Erb On June 1, 2017, 8:33 a.m., David McLaughlin wrote

Re: Review Request 59699: Improve task history pruning by batch deleting tasks

2017-06-05 Thread Stephan Erb
s an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59699/ > --- > > (Updated June 2, 2017, 2:01 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, Stephan Erb, and &g

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

2017-05-31 Thread Stephan Erb
omment to be understandable for a future reader. src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java Lines 90 (patched) <https://reviews.apache.org/r/59480/#comment249931> REVOCABLE_MEMORY is missing in this switch statement. - Stephan Erb On June 1, 2017, 12:36 a.m., Davi

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Stephan Erb
-NOTES.md as well. - Stephan Erb On May 30, 2017, 11:21 p.m., Jordan Ly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-31 Thread Stephan Erb
> On May 31, 2017, 12:13 a.m., Stephan Erb wrote: > > Thanks for the patch! That is an interesting idea. I am wondering if it is > > safe in all cases. For example, if I reduce the resource requirements while > > increasing the number of instances, my service could p

Re: Review Request 59640: Prioritize adding instances over updating instances during an update

2017-05-30 Thread Stephan Erb
a more robust alternative. It will be more complicated to implement though... I am not working on very large clusters, so I am kind of interested what the others have to say here. - Stephan Erb On May 30, 2017, 11:21 p.m., J

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

2017-05-30 Thread Stephan Erb
> On May 26, 2017, 10:23 a.m., Stephan Erb wrote: > > I have thought about this in the past as well, and I am slightly skeptical > > if a simple sort by resources is a good approach when using > > oversubscription. Especially given the goal to run almost all > >

Re: Review Request 59480: Expose bin-packing options via OfferManager ordering.

2017-05-26 Thread Stephan Erb
l_ram) + 10 ** (free_revocable_ram/total_revocable_ram) ...`. * Extend the sort by revocable resources with a special case for 0 remaining revocable resources. - Stephan Erb On May 23, 2017, 9:41 a.m., David McLaughlin wrote: > > --- &

Re: Review Request 59478: Fix SchedulingBenchmarks

2017-05-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59478/#review175823 --- Ship it! Ship It! - Stephan Erb On May 23, 2017, 6:32 a.m

Re: Review Request 55071: Disable H2 logging via SLF4J.

2017-05-22 Thread Stephan Erb
/h2database/pull/516. I will follow up with an h2 version bump once released. - Stephan Erb On May 7, 2017, 7:46 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 59417: Bump logback to 1.2.3 and SLF4J to 1.7.25

2017-05-19 Thread Stephan Erb
ack.qos.ch/news.html Diffs - build.gradle b7a4f059b6de8acca882f3cd1e881434f4befbfa Diff: https://reviews.apache.org/r/59417/diff/1/ Testing --- ./gradlew -Pq build Thanks, Stephan Erb

Re: Review Request 59039: Add the ability to customize scheduling logic.

2017-05-14 Thread Stephan Erb
> On May 12, 2017, 4:20 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > > Line 130 (original), 174 (patched) > > <https://reviews.apache.org/r/59039/diff/2/?file=1716093#file1716093line178> > > > >

Re: Review Request 59231: fix update affinity cache name

2017-05-14 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59231/#review174914 --- Ship it! Ship It! - Stephan Erb On May 12, 2017, 6:48 p.m

Re: Review Request 59039: Add the ability to customize scheduling logic.

2017-05-12 Thread Stephan Erb
eduler/state/FirstFitTaskAssignerModule.java Lines 28 (patched) <https://reviews.apache.org/r/59039/#comment248012> For consistency how about renaming `TaskAssignerImpl` to `FirstFitTaskAssignerImpl`? - Stephan Erb On May 11, 2017, 11:46 p.m., Davi

Re: Review Request 59163: Added 'aurora task scp' command for copying to task instances

2017-05-12 Thread Stephan Erb
client documentation https://github.com/apache/aurora/blob/master/docs/reference/client-commands.md#sshing-to-a-specific-task-machine - Stephan Erb On May 11, 2017, 7:13 p.m., Jordan Ly wrote: > > --- > This is an automatically ge

Re: Review Request 59030: AURORA-1869 Reducing storage write lock contention in TaskStatusHandlerImpl

2017-05-08 Thread Stephan Erb
to wait for your testing in the scale environment, then we can see how we want to proceed. - Stephan Erb On May 5, 2017, 11:36 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 55071: Disable H2 logging via SLF4J.

2017-05-07 Thread Stephan Erb
cluster? I believe it should help with gc pressure as it will reduce the (logging/tracing) garbage produced by h2. If it turns out to be true we can think about how to adopt the change properly . - Stephan Erb On Mai 7, 2017, 7:46 nachm., Stephan Erb wrote

Re: Review Request 58979: Expose stats on log storage lock wait time per caller

2017-05-04 Thread Stephan Erb
fear a performance penalty doing this while holding the lock? - Stephan Erb On May 4, 2017, 2:09 a.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 58259: Add update affinity to Scheduler

2017-05-04 Thread Stephan Erb
g/r/58259/#comment246976> than -> that - Stephan Erb On May 4, 2017, 2:09 a.m., David McLaughlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 58259: Add update affinity to Scheduler

2017-05-02 Thread Stephan Erb
--------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58259/ > --- > > (Updated May 2, 2017, 3:32 a.m.) > > > Review request for Aurora,

Re: Review Request 58863: AURORA-1922 Expose stats on the number of jobs stored in MemCronJobStore

2017-05-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58863/#review173519 --- Ship it! Ship It! - Stephan Erb On April 29, 2017, 1:15 a.m

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-25 Thread Stephan Erb
org/r/58611/#review173008 --- On April 21, 2017, 12:36 nachm., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58651: Extend operator documentation

2017-04-25 Thread Stephan Erb
/operator-docs/docs Thanks, Stephan Erb

Re: Review Request 58651: Extend operator documentation

2017-04-25 Thread Stephan Erb
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58651/#review172831 ------- On April 25, 2017, 11:25 p.m., Stephan Erb wrote: > > ---

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-25 Thread Stephan Erb
/#review172951 --- On April 21, 2017, 12:36 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 58636: adding metrics for removals from bicache

2017-04-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58636/#review172759 --- Ship it! Ship It! - Stephan Erb On April 22, 2017, 1:34 a.m

Re: Review Request 58636: adding metrics for removals from bicache

2017-04-23 Thread Stephan Erb
> On April 22, 2017, 6:38 a.m., Mehrdad Nurolahzade wrote: > > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java > > Lines 86 (patched) > > > > > > You can also get eviction stats. I took a stab at this

Review Request 58651: Extend operator documentation

2017-04-23 Thread Stephan Erb
d302e9001bbd441a3c303a9e445bee57dc969ac7 Diff: https://reviews.apache.org/r/58651/diff/1/ Testing --- Rendered version is available at https://github.com/StephanErb/aurora/tree/operator-docs/docs Thanks, Stephan Erb

Re: Review Request 58611: Bump initial_task_kill_retry_interval to 15s.

2017-04-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58611/#review172748 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 12:36 p.m

Re: Review Request 58636: adding metrics for removals from bicache

2017-04-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58636/#review172747 --- @ReviewBot retry - Stephan Erb On April 22, 2017, 1:34 a.m

Re: Review Request 58605: Default watch_secs to 0.

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58605/#review172673 --- Ship it! Ship It! - Stephan Erb On April 21, 2017, 6:32 p.m

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58609/#review172671 --- @ReviewBot retry - Stephan Erb On April 21, 2017, 11:35 a.m

Re: Review Request 58609: Switch Thermos runner to simple disk log layout

2017-04-21 Thread Stephan Erb
> > from twitter.common.log.options import LogOptions > > > > LogOptions.set_simple(True) > > > > (We already do this in our internal fork, no idea why it's done there > > instead of the main project) > > Stephan Erb wrote: > Ther

<    1   2   3   4   5   6   7   8   9   10   >