Re: Review Request 48513: Update rpm services to match debian

s only required by Mesos? - Stephan Erb On June 12, 2016, 1:28 a.m., Kasisnu Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48591: Ensure we can verify release candidates in the Vagrant box

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48591/#review137141 --- @ReviewBot retry - Stephan Erb On June 12, 2016, 12:21 a.m

Review Request 48591: Ensure we can verify release candidates in the Vagrant box

ld-support/release/verify-release-candidate 7aa9c9095bbab1ad497186ec700fde2d52498ea7 Diff: https://reviews.apache.org/r/48591/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 48359: Adding gpg key for serb

--- Switch to longer keys. Repository: aurora Description --- Adding gpg key for serb Diffs (updated) - KEYS e6dfcb78b1d16a7a159c49439821ebb6049c7024 Diff: https://reviews.apache.org/r/48359/diff/ Testing --- Thanks, Stephan Erb

Review Request 48359: Adding gpg key for serb

gpg key for serb Diffs - KEYS e6dfcb78b1d16a7a159c49439821ebb6049c7024 Diff: https://reviews.apache.org/r/48359/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 48218: Document the logfile locations used in the vagrant box

/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 48082: AURORA-1624 Make 'tier' required and remove support for 'production' flag in Job configuration - New thrift API for retrieving tier configuration

/gen/api.thrift (lines 245 - 247) <https://reviews.apache.org/r/48082/#comment201570> Please add deprecation notes in the `RELEASE-NOTES.md`, and update the title/description of the RB to indicate that the `production` flag will not be removed but just deprecated for now. - Stephan Er

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review136375 --- Ship it! Ship It! - Stephan Erb On June 4, 2016, 8:33 p.m

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

proper webserver within my test that actually asserts data is received as requested. I have never done this in Java, but it seems possible (for example with Jetty): https://stackoverflow.com/questions/29758607/how-to-run-jetty-server-for-java-junit-testing - Stephan Erb On Jun

Review Request 48218: Document the logfile locations used in the vagrant box

--- Document the logfile locations used in the vagrant box Diffs - docs/getting-started/vagrant.md 44606009759a68cb142be4f2c7061ad8d0a39066 Diff: https://reviews.apache.org/r/48218/diff/ Testing --- Thanks, Stephan Erb

Review Request 48216: Change the UI to refer to Mesos Agents instead of Mesos Slaves.

/resources/scheduler/assets/js/filters.js ec35d81537b44b7bf76cf4cf134b96d44904fee1 Diff: https://reviews.apache.org/r/48216/diff/ Testing --- * ran ./build-support/jenkins/build.sh * checked in the Vagrant box that /slaves and /agents are both working. Thanks, Stephan Erb

Re: Review Request 48211: fix containers doc example

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48211/#review136072 --- Ship it! Ship It! - Stephan Erb On June 3, 2016, 6:07 p.m

Re: Review Request 48211: fix containers doc example

) <https://reviews.apache.org/r/48211/#comment201046> Shouldn't that be `hello_world_proc` instead? - Stephan Erb On June 3, 2016, 5:43 p.m., Raymond Khalife wrote: > > --- > This is an automatically generated e-m

Re: Review Request 47998: Converting resource counters to use new resource fields

I am confused. Where are those used? src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java (lines 43 - 49) <https://reviews.apache.org/r/47998/#comment200410> If you decide to stick to the new names, please mention the change in the release notes. - Stephan Erb On May

Re: Review Request 47647: Update packaging to work with Aurora 0.13.

sting --- Manually followed the test instructions. Rendered versions are available here https://github.com/StephanErb/aurora-packaging/tree/dedust-0.13 Thanks, Stephan Erb

Re: Review Request 47869: Adding support for GPU resource

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47869/#review135393 --- Ship it! Ship It! - Stephan Erb On May 26, 2016, 10:57 p.m

Re: Review Request 47869: Adding support for GPU resource

ble to schedule a GPU-aware task, there is no risk for a rollback to a version without GPU-support. - Stephan Erb On May 26, 2016, 10:57 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

nal that you use multiple names for the timeout here? (`connectTimeout` vs `timeoutMsec`) - Stephan Erb On May 27, 2016, 12:29 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 22, 2016, 3:28 p.m., Stephan Erb wrote: > > docs/reference/scheduler-configuration.md, line 222 > > <https://reviews.apache.org/r/47440/diff/5/?file=1387598#file1387598line222> > > > > How about something like: "File to configure a HTTP web

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

as security advantages and would als make it easier for users to leverage security features such as the new Mesos Linux Capabilities https://docs.google.com/document/d/1YiTift8TQla2vq3upQr7K-riQ_pQ-FKOCOsysQJROGc/edit?pref=2&pli=1 - Stephan Erb On May 25, 2016, 11:18 p.m., Jos

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

then this is ready to be shipped. Thanks for your patience. - Stephan Erb On May 26, 2016, 11:02 a.m., Chris Bannister wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 47869: Adding support for GPU resource

ted in favor of `set resources`, correct? If yes, please leave a deprecation note here and in the changelog. api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 271 - 276) <https://reviews.apache.org/r/47869/#comment199923> Same as above. - Stephan Erb On May 26, 2016, 3:20

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

> On May 23, 2016, 12:24 a.m., Stephan Erb wrote: > > Looks good. Just one thing: Please add an entry to the release notes. Would be great if you could add the missing release notes entry mentioned above. - Stephan --- T

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47550/#review134856 --- Ship it! Ship It! - Stephan Erb On May 25, 2016, 6:14 p.m

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47697/#review134854 --- @ReviewBot retry - Stephan Erb On May 24, 2016, 10:44 a.m

Re: Review Request 47741: Updating scheduler UI to use new resource objects

/filters.js (lines 97 - 99) <https://reviews.apache.org/r/47741/#comment199597> In https://reviews.apache.org/r/47809/ you call this `"CPUs"` with a unit of `"core(s)"`. I don't really care how you call it, but would be great if it is consistent :-) - Stephan E

Re: Review Request 47741: Updating scheduler UI to use new resource objects

> On May 23, 2016, 11:42 p.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 168 > > <https://reviews.apache.org/r/47741/diff/1/?file=1391847#file1391847line168> > > > > Any reason why this resource is lowercase but all

Re: Review Request 47809: Generalizing resource management on the client

(line 28) <https://reviews.apache.org/r/47809/#comment199592> Now that you print `core(s)` as a display unit, you might as well change the CPU display name to singular and just use `CPU` similar to how it is done for the other resources. - Stephan Erb On May 25, 2016, 5:48 a.m., M

Re: Review Request 47647: Update packaging to work with Aurora 0.13.

ed e-mail. To reply, visit: https://reviews.apache.org/r/47647/#review134600 ------- On May 20, 2016, 6:37 p.m., Stephan Erb wrote: > > --- > This is an automatically

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47697/#review134564 --- @ReviewBot retry - Stephan Erb On May 24, 2016, 10:44 a.m

Re: Review Request 47741: Updating scheduler UI to use new resource objects

) <https://reviews.apache.org/r/47741/#comment199249> Any reason why this resource is lowercase but all others are uppercase? - Stephan Erb On May 23, 2016, 11:26 p.m., Maxim Khutornenko wrote: > > --- > This is a

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

> On May 23, 2016, 5:49 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line > > 120 > > > > > > How about just using `Arg.create()` here, and only set it below i

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

> On May 22, 2016, 3:06 p.m., Aurora ReviewBot wrote: > > Master (9f6a660) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > :processJmhResources UP-TO-DATE > > :jmhClasses > > :checkstyleJmh > > :jsHint > > :checkstyleMain > > :compileTestJava/home/jenkins/jenkins-slav

Re: Review Request 47697: Add -ip option to bind scheduler to a single IP

the release notes. - Stephan Erb On Mai 22, 2016, 2:58 nachm., Chris Bannister wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 19, 2016, midnight, Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 163 > > <https://reviews.apache.org/r/47440/diff/4/?file=1387376#file1387376line163> > > > > By using the object as-is, we have

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

; I have the impression that both `testTaskChangedState` and `testCallEndpoint` are not properly exercicing the actual webhook class. Maxim, what do you think? Maybe an e2e test would be the best course of action here. - Stephan Erb On May 19, 2016, 4:16 a.m., Dmitriy Sh

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 10:56 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 76 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line76> > > > > Given that state changes happen very frequent

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

> On May 17, 2016, 4:51 a.m., George Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 86 > > > > > > Should this be dispatched on another thread or added to a queue for > > future

Review Request 47647: Update packaging to work with Aurora 0.13.

://github.com/StephanErb/aurora-packaging/tree/dedust-0.13 Thanks, Stephan Erb

Re: Review Request 45521: Remove client-side validation of environment names

need to pick it up myself someday :-). - Stephan Erb On March 31, 2016, 7:55 a.m., Benjamin Staffin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46803: AURORA-1458: Add tier into the UI "show config" summary.

> On April 29, 2016, 3:20 a.m., Maxim Khutornenko wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 139 > > > > > > I am not too keen on having a column for an optional field that will > > most

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

> On May 18, 2016, 12:19 a.m., Maxim Khutornenko wrote: > > What's the status of this renaming effort in Mesos? If it's still influx > > I'd rather prefer we wait out. > > Stephan Erb wrote: > The renaming is ranked high on the Mesos roadmap > h

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

nt198461> I am surprised to find this one here. Are you planning to bundle a default config file? - Stephan Erb On May 18, 2016, 11:12 p.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 47550: AURORA-1492 Improve "aurora update start" command output

) <https://reviews.apache.org/r/47550/#comment198440> At that point, the update has already been started and the printout might not reflect all changes as they have already been applied. - Stephan Erb On May 18, 2016, 10:55 p.m., Mehrdad Nurolahzade

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

guration-tutorial.md c40022b0d25bfc17797d59955e761726d8c52f9c docs/reference/configuration.md eb0af3ee375a0bf02677b693549238c05f09821e docs/reference/task-lifecycle.md 1477364c9cd10e8759e41f0f87b91e7c8a7e38eb Diff: https://reviews.apache.org/r/47495/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

------ On May 18, 2016, 12:19 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47495/ > ---

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

ging into it now, was is clearly the > better option ;). > Done :-) - Stephan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47495/#review133741 --------

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

o reply, visit: https://reviews.apache.org/r/47495/#review133750 ----------- On May 18, 2016, 12:19 a.m., Stephan Erb wrote: > > --- > This is an automaticall

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

ache.org/r/47495/#review133648 --- On May 18, 2016, 12:19 a.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

nce/configuration.md eb0af3ee375a0bf02677b693549238c05f09821e docs/reference/task-lifecycle.md 1477364c9cd10e8759e41f0f87b91e7c8a7e38eb Diff: https://reviews.apache.org/r/47495/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

nce/configuration.md eb0af3ee375a0bf02677b693549238c05f09821e docs/reference/task-lifecycle.md 1477364c9cd10e8759e41f0f87b91e7c8a7e38eb Diff: https://reviews.apache.org/r/47495/diff/ Testing --- Thanks, Stephan Erb

Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

ce/task-lifecycle.md 1477364c9cd10e8759e41f0f87b91e7c8a7e38eb Diff: https://reviews.apache.org/r/47495/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

; Given that state changes happen very frequently, should we consider using a persistent HTTP connection? - Stephan Erb On May 17, 2016, 8:44 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-

Re: Review Request 47325: Removing Resources and ResourceSlot classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47325/#review133283 --- Ship it! Ship It! - Stephan Erb On Mai 13, 2016, 2:07 vorm

Re: Review Request 47373: Batching explicit task reconciliation calls

/scheduler/reconciliation/TaskReconciler.java (line 138) <https://reviews.apache.org/r/47373/#comment197561> Is that really copy necessary? - Stephan Erb On Mai 14, 2016, 1:23 vorm., Maxim Khutornenko wrote: > > ---

Re: Review Request 47050: Migrating preemptor and scheduling filter to ResourceBag.

/preemptor/PreemptionVictimFilter.java (lines 127 - 129) <https://reviews.apache.org/r/47050/#comment196761> Could you please double check the comment? It does not seem to correctly reflect the code. - Stephan Erb On May 10, 2016, 7:54 p.m., Maxim Khutornenko

Review Request 47099: Fix dead link in documentation

--- Fix dead link in documentation Diffs - docs/features/resource-isolation.md b9cdfebfd2c4635ee51c6fefdba3ceadb0c08212 Diff: https://reviews.apache.org/r/47099/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46835/#review132052 --- Ship it! Ship It! - Stephan Erb On May 6, 2016, 5:42 p.m

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

che.org/r/46835/#comment196095> You missed one additional `unwrapped` reference here - Stephan Erb On May 6, 2016, 4:23 p.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 46997: Replacing IResourceAggregate in resource calculations.

/ResourceBag.java (line 33) <https://reviews.apache.org/r/46997/#comment196051> You define the `ResourceBag` as a bag of *unique* resource values. Wouldn't `ResourceSet` then be a better name for the class? - Stephan Erb On May 6, 2016, 2:36 a.m., Maxim Khutor

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

le level of abstraction. This should make it easier to understand. - Stephan Erb On May 4, 2016, 8:41 p.m., Joshua Cohen wrote: > > --- > This is an automatically generat

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

) <https://reviews.apache.org/r/46835/#comment195594> This can be removed, I guess. - Stephan Erb On May 4, 2016, 12:04 a.m., Joshua Cohen wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

he framework name in vagrant. Aurora happily re-registered without a fallout. Thanks, Stephan Erb

Re: Review Request 46835: Add client and scheduler support for launching tasks using the Mesos unified containerizer

835/#comment195566> How would I do the mounting? Via the global container mounts scheduler option? So, once we have mounted the passwd and group file, is `thermos_run_as_job_role` still needed? Shouldn't that allow us to use the normal setuid of thermos? - Stephan Erb

Re: Review Request 46786: Add missing Mesos dependency to packer build script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46786/#review130923 --- Ship it! Ship It! - Stephan Erb On April 28, 2016, 5:48 p.m

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46596/#review130886 --- @ReviewBot retry - Stephan Erb On April 28, 2016, 12:44 a.m

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

abeb6d Diff: https://reviews.apache.org/r/46596/diff/ Testing --- * ./gradlew -Pq build * Changed the framework name in vagrant. Aurora happily re-registered without a fallout. Thanks, Stephan Erb

Re: Review Request 46603: Introduce command line option to control the offer filter duration

same behavior as before the patch? > > Stephan Erb wrote: > Using a default of `0` is indeed a behaviour change. I am happy to > discuss if we want this change or not. > > With a timeout of `5` secs (this was the former hardcoded default): > > * W

Re: Review Request 46603: Introduce command line option to control the offer filter duration

startup time for a filter duration of 0 seconds * 29s startup time for the hardcoded former default of 5 seconds Thanks, Stephan Erb

Re: Review Request 46603: Introduce command line option to control the offer filter duration

for a filter duration of 0 seconds * 29s startup time for the hardcoded former default of 5 seconds Thanks, Stephan Erb

Re: Review Request 46596: Command line flag to change FrameworkInfo.name

tingsModuleTest.java dc964b8dac1b8e21e86ad331216c57fa11abeb6d Diff: https://reviews.apache.org/r/46596/diff/ Testing --- * ./gradlew -Pq build * Changed the framework name in vagrant. Aurora happily re-registered without a fallout. Thanks, Stephan Erb

Re: Review Request 46739: using-aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46739/#review130840 --- Awesome :-) Great to have you on the list! - Stephan Erb On

Re: Review Request 46603: Introduce command line option to control the offer filter duration

: https://reviews.apache.org/r/46603/#review130306 --- On April 23, 2016, 6:35 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 46603: Introduce command line option to control the offer filter duration

duration of 0 seconds * 29s startup time for the hardcoded former default of 5 seconds Thanks, Stephan Erb

Re: Review Request 46603: Introduce command line option to control the offer filter duration

of 5 seconds here. What do other thinks? Maybe we can also get input from people running multiple frameworks next to Aurora. - Stephan Erb On April 23, 2016, 6:22 p.m., Stephan Erb wrote: > > --- > This is an automatically gener

Review Request 46603: Introduce command line option to control the offer filter duration

started a job with 5 instances and recorded the time from `PENDING` to `RUNNING` for the slowest ones: * 7s startup time for a filter duration of 0 seconds * 29s startup time for the hardcoded former default of 5 seconds Thanks, Stephan Erb

Review Request 46596: Command line flag to change FrameworkInfo.name

hanged the framework name in vagrant. Aurora happily re-registered without a fallout. Thanks, Stephan Erb

Review Request 46591: Add GPU design document

Description --- Add GPU design document Diffs - docs/development/design-documents.md b01cfd7b126e28c42afbf5b148efd453a4a9d4b6 Diff: https://reviews.apache.org/r/46591/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 46587: Deprecating --restart-threshold option in 'aurora job restart'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46587/#review130208 --- Ship it! Ship It! - Stephan Erb On April 22, 2016, 11:54

Re: Review Request 46346: Add @Timed annotations to cron stores.

mehow? Just from reading `/vars` it will be difficult for operators to figure out that those are covering cron jobs. - Stephan Erb On April 18, 2016, 11:07 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-

Re: Review Request 46150: Discuss guest-additions version mismatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46150/#review128696 --- Ship it! Ship It! - Stephan Erb On April 13, 2016, 5:58

Re: Review Request 46098: AURORA-1584: Aurora 0.13.0 release candidate missing CHANGELOG

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46098/#review128433 --- Ship it! Ship It! - Stephan Erb On April 12, 2016, 5:03 p.m

Re: Review Request 45177: Setting DiscoveryInfo.

the e2e tests. - Stephan Erb On April 6, 2016, 1 a.m., Zhitao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45782: Adding jq to package build.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45782/#review127344 --- Ship it! Ship It! - Stephan Erb On April 6, 2016, 1:02 a.m

Re: Review Request 45779: Small Documentation fixes and nitpicks.

service ports section. Would you mind to fix that as well? - Stephan Erb On April 5, 2016, 11:51 nachm., Tony Dong wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45718: Remove lock-related constructs from the API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127222 --- Ship it! Ship It! - Stephan Erb On April 5, 2016, 11 nachm

Re: Review Request 45721: thermos local-time

> On April 5, 2016, 4:17 a.m., John Sirois wrote: > > Do you have any thoughts on why localtime should be the winner here? > > > > Imagine these scenarios: > > You're an operator for a cluster that lives 3 timezones away > > You're an operator for 3 clusters, each in different timezones. > > >

Re: Review Request 45718: Remove lock-related constructs from the API.

scheduler affected by this change? Will it still be around but only show information for on-going updates? - Stephan Erb On April 5, 2016, 4:09 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127094 --- Ship it! Ship It! - Stephan Erb On April 5, 2016, 4:53 a.m

Re: Review Request 45177: Setting DiscoveryInfo.

I don't think the limitation is very severe right now (given that this is still a beta feature). However you should probably be aware of that. Maybe you could mention it in the documentation. - Stephan Erb On April 4, 2016, 9:4

Re: Review Request 45694: Remove deprecated executor argument '-announcer-enable'

> On April 4, 2016, 8:38 p.m., Stephan Erb wrote: > > RELEASE-NOTES.md, line 24 > > <https://reviews.apache.org/r/45694/diff/1/?file=1324738#file1324738line24> > > > > Seems like we missed to add that to the scheduler command line > > documentation. Wo

Re: Review Request 45694: Remove deprecated executor argument '-announcer-enable'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45694/#review126901 --- Ship it! Ship It! - Stephan Erb On April 4, 2016, 8:48 p.m

Re: Review Request 45694: Remove deprecated executor argument '-announcer-enable'

694/#comment189981> Seems like we missed to add that to the scheduler command line documentation. Would you mind adding it there? - Stephan Erb On April 4, 2016, 8:16 p.m., Bill Farner wrote: > > --- > This is an automatica

Re: Review Request 45177: Setting DiscoveryInfo.

lt;https://reviews.apache.org/r/45177/#comment189597> Should we consider using the inverse notation here? This would be `...` instead of `...`? @benley made a simmilar comment on the mailing list. What do you think? - Stephan Erb On March 31, 2016, 11:48 p.m., Zhit

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

src/main/java/org/apache/aurora/scheduler/http/LeaderHealth.java (line 36) <https://reviews.apache.org/r/45511/#comment189593> That's cool. Thanks :-) - Stephan Erb On April 1, 2016, 8:08 a.m., Ashwin Murthy wrote: > > ---

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On March 31, 2016, 1:17 p.m., Stephan Erb wrote: > > I have no clue about AWS & ELB, so just a couple of notes from the sideline: > > > > * The new feature should be listed in `RELEASE-NOTES.md` > > * We have to figure out how to document that properly (beyond

Re: Review Request 45521: Remove client-side validation of environment names

wever indicates that there are atleast 3 other places that also list the currently hard coded environment names - Stephan Erb On March 31, 2016, 7:55 a.m., Benjamin Staffin wrote: > > --- > This is an automatically generated e-

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

n be equivalent in how we handle the `mname` and `stuctdump` endpoints - Stephan Erb On March 31, 2016, 7:06 a.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.ap

Review Request 45444: Various minor documentation fixes

docs/reference/scheduler-configuration.md 0b1e3c779b534d2c6e2dbbd720a333fbea1c165f Diff: https://reviews.apache.org/r/45444/diff/ Testing --- Thanks, Stephan Erb

Re: Review Request 45436: Fixes to RELEASE-NOTES for new documentation structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45436/#review125915 --- Ship it! Ship It! - Stephan Erb On March 29, 2016, 6:46 p.m

<    3   4   5   6   7   8   9   10   11   >