---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45392/#review125731
-------
On March 28, 2016, 10:50 p.m., Stephan Erb wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45392/#review125730
---
@ReviewBot retry
- Stephan Erb
On March 28, 2016, 8:12 p.m
phanErb/aurora/tree/userguide_docu/docs
Thanks,
Stephan Erb
about the same
tests https://reviews.apache.org/r/31380/diff/1#index_header. What does Brian
mean with "calling .converge"?
- Stephan Erb
On March 28, 2016, 5:41 a.m., Bill Farner wrote:
>
> ---
> This is an automatical
> On March 25, 2016, 9:30 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line
> > 237
> > <https://reviews.apache.org/r/45177/diff/1/?file=1311046#file1311046line237>
> >
> > That can lead to non
e/marathon/state/DiscoveryInfo.scala#L25
Hardcoding this value to `TCP` should therefore probably work for us for now,
right?
- Stephan Erb
On March 22, 2016, 9:10 p.m., Zhitao Li wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45212/#review125432
---
Ship it!
Ship It!
- Stephan Erb
On March 23, 2016, 3:56 p.m
> On March 23, 2016, 3:31 p.m., Stephan Erb wrote:
> > Thinking out loud here, so please comment:
> >
> > We could move to a mode where we build against a specific Mesos version,
> > and recommend that version for deployment, but leave it up to the cluster
> >
> On March 23, 2016, 3:31 p.m., Stephan Erb wrote:
> > Thinking out loud here, so please comment:
> >
> > We could move to a mode where we build against a specific Mesos version,
> > and recommend that version for deployment, but leave it up to the cluster
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45167/#review125029
---
Ship it!
Ship It!
- Stephan Erb
On March 22, 2016, 11:40
update to Mesos 0.27 and Mesos 0.28
This should make it easier for us to keep up with the Mesos release train...
- Stephan Erb
On March 23, 2016, 2:26 p.m., Pierre Cheynier wrote:
>
> ---
> This is an automatically generated e-mail.
f84767a2c01bccc23182672123f9ca6701fcd696
Diff: https://reviews.apache.org/r/45182/diff/
Testing
---
./gradlew -Pq build
Verified rendering in Vagrant
Thanks,
Stephan Erb
t whas I thinking :-)
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45182/#review124907
---
On March 23, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45179/#review124910
---
Ship it!
Ship It!
- Stephan Erb
On March 22, 2016, 11:49
://reviews.apache.org/r/45182/diff/
Testing
---
./gradlew -Pq build
Verified rendering in Vagrant
Thanks,
Stephan Erb
java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
c774ac0f0e2fdda7fe9b64fd9181f107b3fd9eca
Diff: https://reviews.apache.org/r/45135/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
y working?
docs/installing.md (line 312)
<https://reviews.apache.org/r/45167/#comment187586>
I believe everything after the "-" is optional and does not need to be
included.
- Stephan Erb
On March 22, 2016, 6:48 p.m., John Sirois wrote:
>
> --
. Thanks! :-)
- Stephan Erb
On March 22, 2016, 6:02 p.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/ConfigurationManager.java
(line 254)
<https://reviews.apache.org/r/45112/#comment187508>
Shouldn't that rather be formulated as container != `MESOS`? As the Image
field will only work together with the Mesos containerizer.
- Stephan Erb
On March 22, 2016, 4:49 p.m., Joshua
/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
/resources/scheduler/assets/scheduler/index.html
383ca43dfc14448b67181e9d94dd805ac1bbfaa7
Diff: https://reviews.apache.org/r/45055/diff/
Testing
---
Thanks,
Stephan Erb
://reviews.apache.org/r/45055/diff/
Testing
---
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124420
---
@ReviewBot retry
- Stephan Erb
On March 19, 2016, 9 p.m
Attachments (updated)
aurora-landing-page.png
https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
Thanks,
Stephan Erb
Description
---
I have opted for a very simple, incremental improvement here.
Diffs
-
src/main/resources/scheduler/assets/index.html
d0bd897524a4c763d11a601898b663fec672e979
Diff: https://reviews.apache.org/r/45076/diff/
Testing
---
Thanks,
Stephan Erb
/
Testing
---
Rendered version online at
https://github.com/StephanErb/aurora/blob/cmdopts/docs/scheduler-configuration.md
Thanks,
Stephan Erb
tps://reviews.apache.org/r/44532/#comment186698>
That sounds a little bit like "ip" is a valid value. Using ``
might make this more clear.
- Stephan Erb
On March 18, 2016, 7:18 p.m., Kunal Thakar wrote:
>
> ---
> This is an
document has been loaded. They are executed in
order.
Diffs
-
src/main/resources/scheduler/assets/scheduler/index.html
383ca43dfc14448b67181e9d94dd805ac1bbfaa7
Diff: https://reviews.apache.org/r/45055/diff/
Testing
---
Thanks,
Stephan Erb
as an explicit assertion using `assert`?
For example, this could be done via
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.mock_calls
- Stephan Erb
On March 15, 2016, 7:31 p.m., Kunal Thakar wrote:
>
> ---
decent amount of modularization
> work). At the very least, that effort has lost momentum and we shouldn't
> block progress for it.
>
> Stephan Erb wrote:
> I mostly brought it up because the ticket also repeatedly mentions the
> default Mesos command executor. Supp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44806/#review123542
---
Ship it!
Ship It!
- Stephan Erb
On March 14, 2016, 9:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44770/#review123338
---
@ReviewBot retry
- Stephan Erb
On March 14, 2016, 12:21 a.m
/blob/cmdopts/docs/scheduler-configuration.md
Thanks,
Stephan Erb
On March 13, 2016, 1:04 p.m., John Sirois wrote:
> > While your patch is rather easy, I am not sure it is the best way to move
> > forward. It feels like it is crossing streams with
> > https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought
> > into this might be helpful in th
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44763/#review123325
---
Ship it!
Ship It!
- Stephan Erb
On March 13, 2016, 8:50 p.m
n Thermos?
While your patch is rather easy, I am not sure it is the best way to move
forward. It feels like it is crossing streams with
https://issues.apache.org/jira/browse/AURORA-1288. Putting some thought into
this might be helpful in the long run.
- Stephan Erb
On March 13, 2016, 3:48
> On March 10, 2016, 11:04 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 95
> > <https://reviews.apache.org/r/44532/diff/1/?file=1292348#file1292348line95>
> >
> > Specifying the command here feels kin
/process.py (line 151)
<https://reviews.apache.org/r/44680/#comment185141>
This means we would log the error as debug.
It has always bugged me that thermos logging was set to debug by default.
Now I know why :-). Unfortunate
- Stephan Erb
On März 10, 2016, 10:59 nachm., Joshua Cohen
/thermos_executor_main.py (line 95)
<https://reviews.apache.org/r/44532/#comment185136>
Specifying the command here feels kind of weird. All other options we have
take the value directly.
- Stephan Erb
On März 8, 2016, 11:33 nachm., Kunal Thakar
;*' on the slave attribute, the job constraint or both.
- Stephan Erb
On March 10, 2016, 1:25 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
Description
---
Add latest design documents
Diffs
-
docs/design-documents.md 71d6c4c4b90767f47493017c4ac3f263465f9679
Diff: https://reviews.apache.org/r/44589/diff/
Testing
---
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122784
---
Ship it!
Ship It!
- Stephan Erb
On March 8, 2016, 6:45 p.m
just have to
figure some review board permission stuff before hand.
- Stephan Erb
On March 7, 2016, 8:38 p.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/#review122597
---
Ship it!
Ship It!
- Stephan Erb
On March 8, 2016, 6:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43622/#review122038
---
Ship it!
Ship It!
- Stephan Erb
On March 4, 2016, 2:52 a.m
the ship it
above).
- Stephan Erb
On März 3, 2016, 9:16 nachm., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44354/#review121934
---
Ship it!
Ship It!
- Stephan Erb
On März 3, 2016, 9:16 nachm
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44219/#review121533
---
Ship it!
Ship It!
- Stephan Erb
On March 1, 2016, 11:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43866/#review120332
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 23, 2016, 5:19 a.m
lt;https://reviews.apache.org/r/43622/#comment181767>
Two important points are missing here:
* has to be copied into the db backup folder
* the `scheduler-backup...` is the file name and not a path
- Stephan Erb
-check how I
could have missed that...
- Stephan Erb
On Feb. 18, 2016, 1:01 a.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
this effort?
- Stephan Erb
On Oct. 7, 2015, 7:29 a.m., Brian Wickman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ithout silently discarding those in the set constructor.
That's a rather unlikely scenario, but the impact would be quite severe.
- Stephan Erb
On Feb. 17, 2016, 4:42 a.m., Zameer Manji wrote:
>
> ---
> This is an autom
take me a day
or two until I have time to look into that.
docs/storage-config.md (line 131)
<https://reviews.apache.org/r/43622/#comment180689>
What are the expected values for leader and non-leaders?
- Stephan Erb
On Feb. 16, 2016, 10:13 p.m., Maxim Khutornenko
d from `flush`. I did
not run into problems even when running with `assert self.isOpen()`
- Stephan Erb
On Jan. 22, 2016, 8:29 p.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
least once.
Diffs
-
build-support/virtualenv fedf6978045047bc92a7347685d8e26ceb9e11df
Diff: https://reviews.apache.org/r/43568/diff/
Testing
---
./pants test src/test/python::
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43567/#review119195
---
@ReviewBot retry
- Stephan Erb
On Feb. 14, 2016, 10:52 p.m
> On Feb. 14, 2016, 9:37 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java, line 164
> > <https://reviews.apache.org/r/43567/diff/1/?file=1241353#file1241353line164>
> >
> > Note: this `close` cannot be moved to `finall
6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062
Diff: https://reviews.apache.org/r/43567/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
virtualenv-14.0.5/virtualenv.py",
> > line 781, in call_subprocess
> > % (cmd_desc, proc.returncode))
> > OSError: Command /home/jenkins/jenkin...s.venv/bin/python2.7 -c "import
> > sys, pip; sys...d\"] + sys.argv[1:]))" setuptools pip wheel fail
(line 162)
<https://reviews.apache.org/r/43567/#comment180468>
Note: this `close` cannot be moved to `finally` and cannot be replaced by a
`flush`. It is mandatory at this position.
- Stephan Erb
On Feb. 14, 2016, 9:35 p.m., Stephan Erb
---
./gradlew -Pq build
Thanks,
Stephan Erb
tps://reviews.apache.org/r/43534/#comment180345>
I fear that the listed options here might easily become outdated without us
noticing.
- Stephan Erb
On Feb. 12, 2016, 7:44 p.m., John Sirois wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43503/#review118967
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 12, 2016, 12:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43458/#review118771
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 11, 2016, 1 a.m
> On Feb. 10, 2016, 10:39 p.m., Stephan Erb wrote:
> > Stupid question: Will there be another review request implementing instance
> > removal?
>
> Maxim Khutornenko wrote:
> It already exists: `aurora job kill`
>
> Stephan Erb wrote:
> I feel like thi
e to
https://github.com/apache/aurora/blob/master/docs/user-guide.md#task-updates
and https://github.com/apache/aurora/blob/master/docs/client-commands.md?
- Stephan Erb
On Feb. 11, 2016, 12:11 a.m., Maxim Khutornenko wrote:
>
> ---
> On Feb. 10, 2016, 10:39 p.m., Stephan Erb wrote:
> > Stupid question: Will there be another review request implementing instance
> > removal?
>
> Maxim Khutornenko wrote:
> It already exists: `aurora job kill`
I feel like this exposes an inconsistency of the AP
implementing instance
removal?
- Stephan Erb
On Feb. 10, 2016, 7:33 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
collected 654 items
...
649 passed, 5 skipped, 1 warnings in 365.30 seconds
Thanks,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43290/#review118194
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 6, 2016, 8:27 p.m
passed, 5 skipped, 1 warnings in 365.30 seconds
Thanks,
Stephan Erb
Mesos is calling this
callback](https://github.com/apache/mesos/blob/c7513a2d50a976a68a4881327a0c803c8d1b0a0e/src/sched/sched.cpp#L1057)
tends to indicated that thermos has crashed.
- Stephan Erb
On Feb. 5, 2016, 5:05 p.m., Joshua Cohen wrote
reflected here?
https://github.com/apache/aurora/blob/master/docs/thrift-deprecation.md
If yes, please write it down :-)
- Stephan Erb
On Feb. 4, 2016, 3:14 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generat
https://github.com/StephanErb/aurora/blob/tasklifecycle/docs/task-lifecycle.md
Thanks,
Stephan Erb
gt; Graceful Shutdown] a little more cleanly and provide a natural spot to note
> > the more detailed docs.
Good idea. to keep the user-guide intact for now.
My longterm goal is to get rid of the user-guide and replace it by a high-level
description, a document on service discovery
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43112/#review117502
---
Ship it!
Ship It!
- Stephan Erb
On Feb. 2, 2016, 11:13 p.m
https://reviews.apache.org/r/43109/diff/
Testing
---
Thanks,
Stephan Erb
---
I've splitted all releases with additions and deprecations into too sections.
This should make it much easier to track past deprecations.
Diffs
-
NEWS a6c2a906ee8e018cca756c1af0d20f221120d42f
Diff: https://reviews.apache.org/r/43109/diff/
Testing
---
Thanks,
Stephan Erb
---
./gradlew -Pq build
Thanks,
Stephan Erb
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review117281
---
On Jan. 27, 2016, 11:52 nachm., Stephan Erb wrote:
>
> ---
> This is an a
> On Feb. 1, 2016, 12:29 a.m., Stephan Erb wrote:
> > With the new proposed option we'd get `--execute-as-user`, `--nosetuid`,
> > and `--docker-setuid`. The last two are basically doing the same thing.
> >
> > Would it make sense to resolve this by pushing th
-user`, `--nosetuid`, and
`--docker-setuid`. The last two are basically doing the same thing.
Would it make sense to resolve this by pushing things up the stack and allow
cluster administrators to provide an executor config per containerizer?
- Stephan Erb
On Jan. 31, 2016, 7:50 a.m., Benjamin St
://reviews.apache.org/r/43013/diff/
Testing
---
Rendered version is available at
https://github.com/StephanErb/aurora/blob/tasklifecycle/docs/task-lifecycle.md
Thanks,
Stephan Erb
.
- Stephan Erb
On Jan. 29, 2016, 9:54 nachm., Joshua Cohen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116778
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 28, 2016, 5:53 a.m
.java
5368ba5a0c9a98b4bf8142c7ab59c0864e201706
Diff: https://reviews.apache.org/r/42879/diff/
Testing
---
./gradlew -Pq build
Thanks,
Stephan Erb
ssing a trailing dot.
Uups, good catch.
- Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review116639
---
On Jan.
---
./gradlew -Pq build
Thanks,
Stephan Erb
,
Stephan Erb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42727/#review116334
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 25, 2016, 7:03 p.m
in the
packaging repo? In an immediate additional review request or in a general
overhaul before the next release?
- Stephan Erb
On Jan. 25, 2016, 7:03 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42699/#review116087
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 24, 2016, 10:31 p.m
would
imply somebody is calling `flush()` on a closed transport.
- Stephan Erb
On Jan. 22, 2016, 8:29 p.m., Kunal Thakar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42445/#review114971
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 18, 2016, 12:42 a.m
.
- Stephan Erb
On Oct. 9, 2015, 2:41 p.m., Brice Arnould wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39170/
> --
.
- Stephan Erb
On Oct. 9, 2015, 2:41 p.m., Brice Arnould wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39170/
> --
request can be
closed.
- Stephan Erb
On Feb. 13, 2015, 11 a.m., lozh...@ebay.com zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
start failed processes. How does
this interact with Aurora commiting suicide at least onces a day?
- Stephan Erb
On Jan. 16, 2016, 8:26 a.m., Dmitriy Shirchenko wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42077/#review114058
---
Ship it!
Ship It!
- Stephan Erb
On Jan. 12, 2016, 8:58 p.m
801 - 900 of 1038 matches
Mail list logo
