ache/aurora/scheduler/state/TaskStateMachine.java
23f256a7d467c79dcd5d906f76af4f0261dfd81d
src/main/resources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d
Diff: https://reviews.apache.org/r/54269/diff/
Testing
---
Thanks,
Zameer Manji
staring at the tests, but I
think this is correct.
This is unfortunately a little complex to understand. For bonus points, would
it be possible to encode some of this information in a diagram?
The tests are thourough, which makes me comfortable in shipping this change.
- Zameer Manji
On Dec. 2
/BaseCuratorDiscoveryTest.java
a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583
src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
6ea49b0c690d288ff59d1d4798144bfa2d153d3a
Diff: https://reviews.apache.org/r/54288/diff/
Testing
---
Thanks,
Zameer Manji
d e-mail. To reply, visit:
https://reviews.apache.org/r/54269/#review157673
-------
On Dec. 1, 2016, 3:13 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generat
achine.java
23f256a7d467c79dcd5d906f76af4f0261dfd81d
src/main/resources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d
Diff: https://reviews.apache.org/r/54269/diff/
Testing
---
Thanks,
Zameer Manji
achine.java
23f256a7d467c79dcd5d906f76af4f0261dfd81d
src/main/resources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d
Diff: https://reviews.apache.org/r/54269/diff/
Testing
---
Thanks,
Zameer Manji
n/resources/logback.xml 84c175cec811fd95db44fd8dfcd514385606042d
Diff: https://reviews.apache.org/r/54269/diff/
Testing
---
Thanks,
Zameer Manji
x27;s suggestion of upgrading
Curator so we can use it's pluggable error handlers.
- Zameer Manji
On Dec. 1, 2016, 2:48 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54185/#review157345
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 29, 2016, 2:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54176/#review157337
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 29, 2016, 1:56 p.m
/InstrumentingInterceptor.java
(line 81)
<https://reviews.apache.org/r/54107/#comment227868>
Instead of having a hard dependency on `SlidingStats` constructor here.
Could we use `StatsProvider` to get the sliding stats for us?
- Zameer Manji
On Nov. 28, 2016, 6:36 p.m., Reza Motamedi
use it in AURORA-1799.
- Zameer Manji
On Nov. 23, 2016, 2:25 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
https://reviews.apache.org/r/54011/diff/
Testing
---
Thanks,
Zameer Manji
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54011/#review156727
---
On Nov. 22, 2016, 6:47 p.m., Zameer Manji wrote:
>
> --
StateManagerBenchmarks.InsertPendingTasksBenchmark.run 5
N/A thrpt 10 0.041 ± 0.006 ops/s
Diffs
-
src/jmh/java/org/apache/aurora/benchmark/StateManagerBenchmarks.java
PRE-CREATION
Diff: https://reviews.apache.org/r/54011/diff/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53918/#review156603
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 22, 2016, 4:49 a.m
> On Nov. 22, 2016, 10:07 a.m., David McLaughlin wrote:
> > Thanks for the patch! I think percentiles are crucial for analyzing
> > scheduling performance and I'm pretty excited about having them for our
> > latencies. However, I'm not sure if it makes sense to patch our local fork
> > of twit
-
>
> (Updated Nov. 19, 2016, 1:36 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1802
> https://issues.apache.org/jira/browse/AURORA-1802
>
>
> Repository: aurora
>
>
> Description
> -
ply, visit:
> https://reviews.apache.org/r/53918/
> ---
>
> (Updated Nov. 19, 2016, 1:36 a.m.)
>
>
> Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.
>
>
> Bugs: AURORA-1802
> https://issues.apache.org/jira/browse/AURORA-1802
>
>
> Reposit
and prevent cases like this.
- Zameer Manji
On Nov. 20, 2016, 10:50 a.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53928/#review156401
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 19, 2016, 6:23 a.m
future changes?
- Zameer Manji
On Nov. 18, 2016, 6:45 p.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Nov. 17, 2016, 1:48 p.m., Zameer Manji wrote:
> > Seems like a lot of patches to enable this behaviour. I'm not opposed but
> > it seems risky.
>
> John Sirois wrote:
> You find everything risky!
I'm just afraid that the more patches we have, the ha
to land it.
- Zameer Manji
On Nov. 17, 2016, 2:18 a.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
m not opposed but it
seems risky.
api/src/main/thrift/org/apache/aurora/gen/BUILD (line 34)
<https://reviews.apache.org/r/53836/#comment226435>
Can't we have our own 3rdparty thrift target that includes the thrift lib
and this prepare binary? Then we can put the dep in one place.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53862/#review156245
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 17, 2016, 11:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53831/#review156227
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 17, 2016, 8:43 a.m
/org/apache/aurora/scheduler/resources/ResourceManagerTest.java
(line 179)
<https://reviews.apache.org/r/53831/#comment226305>
You can remove the TODO here.
- Zameer Manji
On Nov. 16, 2016, 4:31 p.m., Renan DelValle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53829/#review156157
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 16, 2016, 4:19 p.m
> On Nov. 16, 2016, 2:44 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py, line 118
> > <https://reviews.apache.org/r/53590/diff/5/?file=1565457#file1565457line118>
> >
> > The only objection I have to this code is
> On Nov. 16, 2016, 2:44 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py, line 118
> > <https://reviews.apache.org/r/53590/diff/5/?file=1565457#file1565457line118>
> >
> > The only objection I have to this code is
> On Nov. 16, 2016, 2:44 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/executor/aurora_executor.py, line 118
> > <https://reviews.apache.org/r/53590/diff/5/?file=1565457#file1565457line118>
> >
> > The only objection I have to this code is
some return
RUNNING and
the rest return `None` we go to RUNNING. If one returns STARTING we poll
until
we reach the previous states.
What do you think about that?
- Zameer Manji
On Nov. 16, 2016, 1:38 p.m., Santhosh Kumar Shanm
a/org/apache/aurora/scheduler/storage/log/LogManagerTest.java
73440517cddda643c0b84cc04cb8463cdea2da28
Diff: https://reviews.apache.org/r/53796/diff/
Testing
---
Thanks,
Zameer Manji
.java
73440517cddda643c0b84cc04cb8463cdea2da28
Diff: https://reviews.apache.org/r/53796/diff/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53794/#review155979
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 15, 2016, 1:22 p.m
larify the role of the
callback? How many args is it supposed to have, when will it be called? etc.
- Zameer Manji
On Nov. 13, 2016, 9:09 p.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is an automatically generated e-mai
> On Nov. 11, 2016, 5:56 p.m., Zameer Manji wrote:
> > Some high level feedback.
> > * Remove the ticket from the title and the comment and attach it to the
> > review by filling out the bugs field.
> > * Please create a more detailed description. Use
> >
tats.java
(line 51)
<https://reviews.apache.org/r/53687/#comment225855>
What's the point of this constructor?
Why would we want to disable percentile reording here?
- Zameer Manji
On Nov. 11, 2016, 5:49 p.m., Reza Motamedi wrote:
>
> --
from the reviewers
list since is seems jcohen and serb are on it.
- Zameer Manji
On Nov. 11, 2016, 2:13 a.m., Jing Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
/dist/test-results"
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
end.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155027
---
@ReviewBot retry
- Zameer Manji
On Nov. 4, 2016, 4:54 p.m
sting
---
./pants test.pytest --junit-xml-dir="$PWD/dist/test-results"
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53508/#review155023
---
@ReviewBot retry
- Zameer Manji
On Nov. 4, 2016, 4:43 p.m
en to fix the build.
Post commit reviews are welcome.
- Zameer Manji
On Nov. 4, 2016, 4:43 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
l-dir="$PWD/dist/test-results"
src/{main,test}/python:: -- -v
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
es due to bugs in this low level code.
> > * We can provide propper logging here, as we have the necessary context
> > to explain what is going on and that it is safe to continue.
>
> Zameer Manji wrote:
> I've thought about this a lot, but kernel 3.4 was released i
/test_daemonizing_process.aurora
PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
67702d2c0f2e18ee10dcb798b6d421050bd7d4ca
Diff: https://reviews.apache.org/r/53418/diff/
Testing
---
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
s not lose track of double forking processes. On
> > task teardown the daemonized process should receive a signal to shut down
> > cleanly."
Done, good catch.
- Zameer
---
This is an automatically generated e-mail.
that.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53418/#review154914
-------
On Nov. 3, 2016, 4:48 p.m., Zameer Manji wrote:
&g
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53452/#review154905
-------
On Nov. 3, 2016, 5:52 p.m., Zameer Manji wrote:
>
>
sleep 10\ndone\n ", "final": false}], "name": "hello",
"finalization_wait": 30, "max_failures": 1, "max_concurrency": 0, "res
ources": {"gpu": 0, "disk": 134217728, "ram": 134217728, "cpu": 1.0},
"constraints": [{"order": ["hello"]}]}, "production": false, "role":
"www-data", "tier": "preemptible", "lifecycle": {"http":
{"graceful_shutdown_endpoint": "/quitquitquit", "port": "health",
"shutdown_endpoint": "/abortabortabort"}}, "priority": 0}',
name='AuroraExecutor'), requestedPorts=set([]), maxTaskFailures=1, priority=0,
ramMb=128, job=JobKey(environment='prod', role='www-data', name='hello'),
production=False, diskMb=128, resources=set([Resource(ramMb=None, numGpus=None,
namedPort=None, diskMb=None, numCpus=1.0), Resource(ramMb=128, numGpus=None,
namedPort=None, diskMb=None, numCpus=None), Resource(ramMb=None, numGpus=None,
namedPort=None, diskMb=128, numCpus=None)]), owner=Identity(user='vagrant'),
container=Container(docker=None, mesos=MesosContainer(image=None, volumes=[])),
metadata=set([]), numCpus=1.0, constraints=set([])),
taskId='www-data-prod-hello-0-f33684f5-58a7-4dbe-af8c-a4fe08a862b6', instanc
eId=0, assignedPorts={}, slaveHost='192.168.33.7',
slaveId='d8988ce6-c900-49a1-897d-bc141f390394-S0')
Thanks,
Zameer Manji
/test_daemonizing_process.aurora
PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
67702d2c0f2e18ee10dcb798b6d421050bd7d4ca
Diff: https://reviews.apache.org/r/53418/diff/
Testing
---
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
/test_daemonizing_process.aurora
PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
67702d2c0f2e18ee10dcb798b6d421050bd7d4ca
Diff: https://reviews.apache.org/r/53418/diff/
Testing
---
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
t; > fork](https://github.com/apache/aurora/blob/master/src/main/python/apache/thermos/core/process.py#L286)
> > that re-raises as Process.Error (which is then [properly handled by the
> > runner](https://github.com/apache/aurora/blob/master/src/main/python/apache/thermos/core/ru
/test_daemonizing_process.aurora
PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
67702d2c0f2e18ee10dcb798b6d421050bd7d4ca
Diff: https://reviews.apache.org/r/53418/diff/
Testing
---
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
h/org/apache/aurora/e2e/test_end_to_end.sh, line 412
> > <https://reviews.apache.org/r/53418/diff/1/?file=1552763#file1552763line412>
> >
> > fyi you're not quoting any variables throughout here, but i assume
> > that's safe to d
form this into a `Process.Error`. I will do that in a follow
up diff.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53418/#review154732
--
n info log.
Done in https://reviews.apache.org/r/53418/
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53403/#review154671
-
://reviews.apache.org/r/53418/diff/
Testing
---
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53408/#review154644
---
Ship it!
Ship It!
- Zameer Manji
On Nov. 2, 2016, 3:17 p.m
7b9013d11f6ff4172b6b7bf56e62299b0d11c977
Diff: https://reviews.apache.org/r/53403/diff/
Testing
---
no automated tests yet.
Validated behaviour with `ps` and `strace`.
Thanks,
Zameer Manji
7b9013d11f6ff4172b6b7bf56e62299b0d11c977
Diff: https://reviews.apache.org/r/53403/diff/
Testing
---
no automated tests yet.
Validated behaviour with `ps` and `strace`.
Thanks,
Zameer Manji
/process.py
3ec43e2719ef97026f399c4b2aa23002559b3153
src/main/python/apache/thermos/core/runner.py
7b9013d11f6ff4172b6b7bf56e62299b0d11c977
Diff: https://reviews.apache.org/r/53403/diff/
Testing
---
no automated tests yet.
Validated behaviour with `ps` and `strace`.
Thanks,
Zameer Manji
o consider.
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53403/#review154633
---
On Nov. 2, 2016, 1:32 p.m., Zameer Man
Diff: https://reviews.apache.org/r/53403/diff/
Testing
---
no automated tests yet.
Validated behaviour with `ps` and `strace`.
Thanks,
Zameer Manji
3ec43e2719ef97026f399c4b2aa23002559b3153
src/main/python/apache/thermos/core/runner.py
7b9013d11f6ff4172b6b7bf56e62299b0d11c977
Diff: https://reviews.apache.org/r/53403/diff/
Testing
---
no automated tests yet.
Validated behaviour with `ps` and `strace`.
Thanks,
Zameer Manji
1fe09090bfa3eeb0f6897e8c895782fb1ff949a1
Diff: https://reviews.apache.org/r/5/diff/
Testing
---
sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
1fe09090bfa3eeb0f6897e8c895782fb1ff949a1
Diff: https://reviews.apache.org/r/5/diff/
Testing
---
sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
---
sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
/org/apache/aurora/scheduler/thrift/Fixtures.java
95b371627d23f7ed3472561f17880bf3c4259b96
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
e578f5a3076b8f1aad86247b815d05c8244dddc8
Diff: https://reviews.apache.org/r/52588/diff/
Testing
---
Thanks,
Zameer Manji
ticket, having the latches
contain the same information as the leader is not possible with our current
wiring.
I am content with the latches having the hostname now.
- Zameer Manji
On Oct. 29, 2016, 3:05 a.m., Jing Chen wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53258/#review154145
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 28, 2016, 3:08 a.m
you still have bandwidth to review this?
- Zameer Manji
On Oct. 17, 2016, 4:35 p.m., Pradyumna Kaushik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/org/apache/aurora/scheduler/thrift/Fixtures.java
95b371627d23f7ed3472561f17880bf3c4259b96
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
e578f5a3076b8f1aad86247b815d05c8244dddc8
Diff: https://reviews.apache.org/r/52588/diff/
Testing
---
Thanks,
Zameer Manji
eve this is not true. Mesos is ignoring the mode, but the volume
> > is still writable. At least it used to be the case.
> >
> > In our setup, we are mounting a writable `/cache` folder into each
> > container as a spill area that is secured by default linux filesys
/org/apache/aurora/scheduler/thrift/Fixtures.java
95b371627d23f7ed3472561f17880bf3c4259b96
src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
e578f5a3076b8f1aad86247b815d05c8244dddc8
Diff: https://reviews.apache.org/r/52588/diff/
Testing
---
Thanks,
Zameer Manji
> On Oct. 10, 2016, 7:44 p.m., Santhosh Kumar Shanmugham wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java,
> > line 40
> > <https://reviews.apache.org/r/52588/diff/4/?file=1527279#file1527279line40>
> >
> > .setVol
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52479/#review153911
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 26, 2016, 10:14
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> -------
>
> (Updated Oct. 12, 2016, 4:17 p.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Repository: aurora-packagin
172.17.0.1: 172.17.0.1
> > Enumerating addresses of interface wlp3s0:
> > fe80:0:0:0:183:9e44:9c10:%wlp3s0:
> > fe80:0:0:0:183:9e44:9c10:%wlp3s0
> > 10.0.3.132: 10.0.3.132
> > ```
> >
> > I'm not sure
172.17.0.1: 172.17.0.1
> > Enumerating addresses of interface wlp3s0:
> > fe80:0:0:0:183:9e44:9c10:%wlp3s0:
> > fe80:0:0:0:183:9e44:9c10:%wlp3s0
> > 10.0.3.132: 10.0.3.132
> > ```
> >
> > I'm not sure
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53003/#review153190
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 18, 2016, 3:13 p.m
dropping the mesos-containerizer
and adding Pod support so we don't need these gross hacks anymore?
- Zameer Manji
On Oct. 18, 2016, 3:13 p.m., Justin Pinkul wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52804/#review153144
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 18, 2016, 11:22
return `null`. This now handles that case gracefully.
Diffs (updated)
-
src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java
1634cb88ac09c778c5bb277ca902f4ca35dd6c9d
Diff: https://reviews.apache.org/r/52957/diff/
Testing
---
Thanks,
Zameer Manji
/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java
1634cb88ac09c778c5bb277ca902f4ca35dd6c9d
Diff: https://reviews.apache.org/r/52957/diff/
Testing
---
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52821/#review152917
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 13, 2016, 2:27 a.m
t the reported bug is
very annoying.
Plus, I am excited for the prospect of having pants consume `./thriftw` instead
of pulling down it's own binary.
- Zameer Manji
On Oct. 15, 2016, 3:42 p.m., John Sirois wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52915/#review152795
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 15, 2016, 3:42 p.m
PyPI. We did once in the past
and we could make that apart of our release cycle (like creating binary
packages).
- Zameer Manji
On Oct. 14, 2016, 8:03 a.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-
--
>
> (Updated Oct. 13, 2016, 2:27 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Zameer Manji.
>
>
> Bugs: AURORA-1794
> https://issues.apache.org/jira/browse/AURORA-1794
>
>
> Repository: aurora
>
>
> Description
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52834/#review152561
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 13, 2016, 8:32 a.m
for (Mode mode : Mode.values()) {
enumValueMapper.addEnumValue("volume_modes", mode.getValue(),
mode.name());
}
```
This is done at the same time we load the schema.
- Zameer
---
This is an auto
eve this is not true. Mesos is ignoring the mode, but the volume
> > is still writable. At least it used to be the case.
> >
> > In our setup, we are mounting a writable `/cache` folder into each
> > container as a spill area that is secured by default linux filesys
(line 396)
<https://reviews.apache.org/r/52804/#comment221435>
Should we check if this is excutable?
I think we can do this via `os.access` and using the `os.X_OK` mask.
- Zameer Manji
On Oct. 12, 2016, 12:42 p.m., Justin Pinkul
, but I am not a packaging expert.
Renan, thanks for pointing to the distro specific egg.
- Zameer Manji
On Oct. 12, 2016, 4:17 p.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
David before he landed this change.
- Zameer Manji
On Oct. 12, 2016, 2:09 p.m., David McLaughlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
.
- Zameer Manji
On Oct. 11, 2016, 10:01 p.m., Kai Huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
201 - 300 of 945 matches
Mail list logo
